chore: require go 1.23.0 (#351)

sahidvelji · toddbaert · web-flow · commit 3c52fa7fe1dc · 2025-05-22T12:19:38.000-04:00
* chore: require go 1.23.0

Signed-off-by: Sahid Velji &lt;sahidvelji@gmail.com&gt;

* docs: update language version requirement to 1.23

Signed-off-by: Sahid Velji &lt;sahidvelji@gmail.com&gt;

* chore: require go 1.23.0

Signed-off-by: Sahid Velji &lt;sahidvelji@gmail.com&gt;

* chore: fix lint target in Makefile

Signed-off-by: Sahid Velji &lt;sahidvelji@gmail.com&gt;

* fix: fix linter findings

Signed-off-by: Sahid Velji &lt;sahidvelji@gmail.com&gt;

* chore: require go 1.23.0

Signed-off-by: Sahid Velji &lt;sahidvelji@gmail.com&gt;

---------

Signed-off-by: Sahid Velji &lt;sahidvelji@gmail.com&gt;
Co-authored-by: Todd Baert &lt;todd.baert@dynatrace.com&gt;
diff --git a/Makefile b/Makefile
@@ -12,7 +12,6 @@ test:
 e2e-test:
 	git submodule update --init --recursive && go test -tags testtools -race -cover ./e2e/...
 lint:
-	go install -v github.com/golangci/golangci-lint/cmd/golangci-lint@v1.54.1
-	${GOPATH}/bin/golangci-lint run --build-tags testtools --deadline=3m --timeout=3m ./... # Run linters
+	go run github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.1.6 run --build-tags testtools --timeout=3m ./...
 docs:
 	go run golang.org/x/pkgsite/cmd/pkgsite@latest -open .
diff --git a/README.md b/README.md
@@ -43,7 +43,7 @@
 
 ### Requirements
 
-Go language version: [1.20](https://go.dev/doc/devel/release#go1.20)
+Go language version: [1.23](https://go.dev/doc/devel/release#go1.23.0)
 
 > [!NOTE]
 > The OpenFeature Go SDK only supports currently maintained Go language versions.
diff --git a/go.mod b/go.mod
@@ -1,6 +1,6 @@
 module github.com/open-feature/go-sdk
 
-go 1.21
+go 1.23.0
 
 require (
 	github.com/cucumber/godog v0.15.0
diff --git a/openfeature/client.go b/openfeature/client.go
@@ -406,8 +406,8 @@ func (c *Client) BooleanValueDetails(ctx context.Context, flag string, defaultVa
 			Value:             defaultValue,
 			EvaluationDetails: evalDetails.EvaluationDetails,
 		}
-		boolEvalDetails.EvaluationDetails.ErrorCode = TypeMismatchCode
-		boolEvalDetails.EvaluationDetails.ErrorMessage = err.Error()
+		boolEvalDetails.ErrorCode = TypeMismatchCode
+		boolEvalDetails.ErrorMessage = err.Error()
 
 		return boolEvalDetails, err
 	}
@@ -450,8 +450,8 @@ func (c *Client) StringValueDetails(ctx context.Context, flag string, defaultVal
 			Value:             defaultValue,
 			EvaluationDetails: evalDetails.EvaluationDetails,
 		}
-		strEvalDetails.EvaluationDetails.ErrorCode = TypeMismatchCode
-		strEvalDetails.EvaluationDetails.ErrorMessage = err.Error()
+		strEvalDetails.ErrorCode = TypeMismatchCode
+		strEvalDetails.ErrorMessage = err.Error()
 
 		return strEvalDetails, err
 	}
@@ -494,8 +494,8 @@ func (c *Client) FloatValueDetails(ctx context.Context, flag string, defaultValu
 			Value:             defaultValue,
 			EvaluationDetails: evalDetails.EvaluationDetails,
 		}
-		floatEvalDetails.EvaluationDetails.ErrorCode = TypeMismatchCode
-		floatEvalDetails.EvaluationDetails.ErrorMessage = err.Error()
+		floatEvalDetails.ErrorCode = TypeMismatchCode
+		floatEvalDetails.ErrorMessage = err.Error()
 
 		return floatEvalDetails, err
 	}
@@ -538,8 +538,8 @@ func (c *Client) IntValueDetails(ctx context.Context, flag string, defaultValue
 			Value:             defaultValue,
 			EvaluationDetails: evalDetails.EvaluationDetails,
 		}
-		intEvalDetails.EvaluationDetails.ErrorCode = TypeMismatchCode
-		intEvalDetails.EvaluationDetails.ErrorMessage = err.Error()
+		intEvalDetails.ErrorCode = TypeMismatchCode
+		intEvalDetails.ErrorMessage = err.Error()
 
 		return intEvalDetails, err
 	}
diff --git a/openfeature/hooks/logging_hook_test.go b/openfeature/hooks/logging_hook_test.go
@@ -68,7 +68,7 @@ func TestLoggingHookLogsMessagesAsExpected(t *testing.T) {
 }
 
 func TestLoggingHookLogsMessagesAsExpectedIncludeEvaluationContext(t *testing.T) {
-	var buf *bytes.Buffer = new(bytes.Buffer)
+	var buf = new(bytes.Buffer)
 	handler := slog.NewJSONHandler(buf, &slog.HandlerOptions{Level: slog.LevelDebug})
 	logger := slog.New(handler)
 
@@ -184,7 +184,7 @@ func testLoggingHookLogsMessagesAsExpected(hook LoggingHook, logger *slog.Logger
 }
 
 func prepareOutput(buf *bytes.Buffer, t *testing.T) map[string]map[string]any {
-	var ms map[string]map[string]any = make(map[string]map[string]any)
+	var ms = make(map[string]map[string]any)
 	for _, line := range bytes.Split(buf.Bytes(), []byte{'\n'}) {
 		if len(line) == 0 {
 			continue
diff --git a/openfeature/resolution_error.go b/openfeature/resolution_error.go
@@ -121,7 +121,7 @@ func (e *ProviderInitError) Error() string {
 
 var (
 	// ProviderNotReadyError signifies that an operation failed because the provider is in a NOT_READY state.
-	ProviderNotReadyError = errors.New("provider not yet initialized")
+	ProviderNotReadyError = errors.New("provider not yet initialized") //nolint:staticcheck // Renaming this would be a breaking change
 	// ProviderFatalError signifies that an operation failed because the provider is in a FATAL state.
-	ProviderFatalError = errors.New("provider is in an irrecoverable error state")
+	ProviderFatalError = errors.New("provider is in an irrecoverable error state") //nolint:staticcheck // Renaming this would be a breaking change
 )
diff --git a/openfeature/telemetry/telemetry.go b/openfeature/telemetry/telemetry.go
@@ -45,46 +45,46 @@ func CreateEvaluationEvent(hookContext openfeature.HookContext, details openfeat
 		TelemetryProvider: hookContext.ProviderMetadata().Name,
 	}
 
-	if details.EvaluationDetails.ResolutionDetail.Reason != "" {
-		attributes[TelemetryReason] = strings.ToLower(string(details.ResolutionDetail.Reason))
+	if details.Reason != "" {
+		attributes[TelemetryReason] = strings.ToLower(string(details.Reason))
 	} else {
 		attributes[TelemetryReason] = strings.ToLower(string(openfeature.UnknownReason))
 	}
 
 	body := map[string]any{}
 
 	if details.Variant != "" {
-		attributes[TelemetryVariant] = details.EvaluationDetails.ResolutionDetail.Variant
+		attributes[TelemetryVariant] = details.Variant
 	} else {
 		body[TelemetryBody] = details.Value
 	}
 
-	contextID, exists := details.EvaluationDetails.ResolutionDetail.FlagMetadata[TelemetryFlagMetaContextId]
+	contextID, exists := details.FlagMetadata[TelemetryFlagMetaContextId]
 	if !exists {
 		contextID = hookContext.EvaluationContext().TargetingKey()
 	}
 
 	attributes[TelemetryContextID] = contextID
 
-	setID, exists := details.EvaluationDetails.ResolutionDetail.FlagMetadata[TelemetryFlagMetaFlagSetId]
+	setID, exists := details.FlagMetadata[TelemetryFlagMetaFlagSetId]
 	if exists {
 		attributes[TelemetryFlagSetID] = setID
 	}
 
-	version, exists := details.EvaluationDetails.ResolutionDetail.FlagMetadata[TelemetryFlagMetaVersion]
+	version, exists := details.FlagMetadata[TelemetryFlagMetaVersion]
 	if exists {
 		attributes[TelemetryVersion] = version
 	}
 
-	if details.EvaluationDetails.ResolutionDetail.Reason == openfeature.ErrorReason {
-		if details.ResolutionDetail.ErrorCode != "" {
-			attributes[TelemetryErrorCode] = details.ResolutionDetail.ErrorCode
+	if details.Reason == openfeature.ErrorReason {
+		if details.ErrorCode != "" {
+			attributes[TelemetryErrorCode] = details.ErrorCode
 		} else {
 			attributes[TelemetryErrorCode] = openfeature.GeneralCode
 		}
 
-		if details.ResolutionDetail.ErrorMessage != "" {
-			attributes[TelemetryErrorMsg] = details.ResolutionDetail.ErrorMessage
+		if details.ErrorMessage != "" {
+			attributes[TelemetryErrorMsg] = details.ErrorMessage
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -406,8 +406,8 @@ func (c *Client) BooleanValueDetails(ctx context.Context, flag string, defaultVa`
`406`	`406`	`Value: defaultValue,`
`407`	`407`	`EvaluationDetails: evalDetails.EvaluationDetails,`
`408`	`408`	`}`
`409`		`- boolEvalDetails.EvaluationDetails.ErrorCode = TypeMismatchCode`
`410`		`- boolEvalDetails.EvaluationDetails.ErrorMessage = err.Error()`
	`409`	`+ boolEvalDetails.ErrorCode = TypeMismatchCode`
	`410`	`+ boolEvalDetails.ErrorMessage = err.Error()`
`411`	`411`
`412`	`412`	`return boolEvalDetails, err`
`413`	`413`	`}`
`@@ -450,8 +450,8 @@ func (c *Client) StringValueDetails(ctx context.Context, flag string, defaultVal`
`450`	`450`	`Value: defaultValue,`
`451`	`451`	`EvaluationDetails: evalDetails.EvaluationDetails,`
`452`	`452`	`}`
`453`		`- strEvalDetails.EvaluationDetails.ErrorCode = TypeMismatchCode`
`454`		`- strEvalDetails.EvaluationDetails.ErrorMessage = err.Error()`
	`453`	`+ strEvalDetails.ErrorCode = TypeMismatchCode`
	`454`	`+ strEvalDetails.ErrorMessage = err.Error()`
`455`	`455`
`456`	`456`	`return strEvalDetails, err`
`457`	`457`	`}`
`@@ -494,8 +494,8 @@ func (c *Client) FloatValueDetails(ctx context.Context, flag string, defaultValu`
`494`	`494`	`Value: defaultValue,`
`495`	`495`	`EvaluationDetails: evalDetails.EvaluationDetails,`
`496`	`496`	`}`
`497`		`- floatEvalDetails.EvaluationDetails.ErrorCode = TypeMismatchCode`
`498`		`- floatEvalDetails.EvaluationDetails.ErrorMessage = err.Error()`
	`497`	`+ floatEvalDetails.ErrorCode = TypeMismatchCode`
	`498`	`+ floatEvalDetails.ErrorMessage = err.Error()`
`499`	`499`
`500`	`500`	`return floatEvalDetails, err`
`501`	`501`	`}`
`@@ -538,8 +538,8 @@ func (c *Client) IntValueDetails(ctx context.Context, flag string, defaultValue`
`538`	`538`	`Value: defaultValue,`
`539`	`539`	`EvaluationDetails: evalDetails.EvaluationDetails,`
`540`	`540`	`}`
`541`		`- intEvalDetails.EvaluationDetails.ErrorCode = TypeMismatchCode`
`542`		`- intEvalDetails.EvaluationDetails.ErrorMessage = err.Error()`
	`541`	`+ intEvalDetails.ErrorCode = TypeMismatchCode`
	`542`	`+ intEvalDetails.ErrorMessage = err.Error()`
`543`	`543`
`544`	`544`	`return intEvalDetails, err`
`545`	`545`	`}`
Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ func TestLoggingHookLogsMessagesAsExpected(t *testing.T) {`
`68`	`68`	`}`
`69`	`69`
`70`	`70`	`func TestLoggingHookLogsMessagesAsExpectedIncludeEvaluationContext(t *testing.T) {`
`71`		`- var buf *bytes.Buffer = new(bytes.Buffer)`
	`71`	`+ var buf = new(bytes.Buffer)`
`72`	`72`	`handler := slog.NewJSONHandler(buf, &slog.HandlerOptions{Level: slog.LevelDebug})`
`73`	`73`	`logger := slog.New(handler)`
`74`	`74`
`@@ -184,7 +184,7 @@ func testLoggingHookLogsMessagesAsExpected(hook LoggingHook, logger *slog.Logger`
`184`	`184`	`}`
`185`	`185`
`186`	`186`	`func prepareOutput(buf bytes.Buffer, t testing.T) map[string]map[string]any {`
`187`		`- var ms map[string]map[string]any = make(map[string]map[string]any)`
	`187`	`+ var ms = make(map[string]map[string]any)`
`188`	`188`	`for _, line := range bytes.Split(buf.Bytes(), []byte{'\n'}) {`
`189`	`189`	`if len(line) == 0 {`
`190`	`190`	`continue`
Original file line number	Diff line number	Diff line change
`@@ -121,7 +121,7 @@ func (e *ProviderInitError) Error() string {`
`121`	`121`
`122`	`122`	`var (`
`123`	`123`	`// ProviderNotReadyError signifies that an operation failed because the provider is in a NOT_READY state.`
`124`		`- ProviderNotReadyError = errors.New("provider not yet initialized")`
	`124`	`+ ProviderNotReadyError = errors.New("provider not yet initialized") //nolint:staticcheck // Renaming this would be a breaking change`
`125`	`125`	`// ProviderFatalError signifies that an operation failed because the provider is in a FATAL state.`
`126`		`- ProviderFatalError = errors.New("provider is in an irrecoverable error state")`
	`126`	`+ ProviderFatalError = errors.New("provider is in an irrecoverable error state") //nolint:staticcheck // Renaming this would be a breaking change`
`127`	`127`	`)`
Original file line number	Diff line number	Diff line change
`@@ -45,46 +45,46 @@ func CreateEvaluationEvent(hookContext openfeature.HookContext, details openfeat`
`45`	`45`	`TelemetryProvider: hookContext.ProviderMetadata().Name,`
`46`	`46`	`}`
`47`	`47`
`48`		`- if details.EvaluationDetails.ResolutionDetail.Reason != "" {`
`49`		`- attributes[TelemetryReason] = strings.ToLower(string(details.ResolutionDetail.Reason))`
	`48`	`+ if details.Reason != "" {`
	`49`	`+ attributes[TelemetryReason] = strings.ToLower(string(details.Reason))`
`50`	`50`	`} else {`
`51`	`51`	`attributes[TelemetryReason] = strings.ToLower(string(openfeature.UnknownReason))`
`52`	`52`	`}`
`53`	`53`
`54`	`54`	`body := map[string]any{}`
`55`	`55`
`56`	`56`	`if details.Variant != "" {`
`57`		`- attributes[TelemetryVariant] = details.EvaluationDetails.ResolutionDetail.Variant`
	`57`	`+ attributes[TelemetryVariant] = details.Variant`
`58`	`58`	`} else {`
`59`	`59`	`body[TelemetryBody] = details.Value`
`60`	`60`	`}`
`61`	`61`
`62`		`- contextID, exists := details.EvaluationDetails.ResolutionDetail.FlagMetadata[TelemetryFlagMetaContextId]`
	`62`	`+ contextID, exists := details.FlagMetadata[TelemetryFlagMetaContextId]`
`63`	`63`	`if !exists {`
`64`	`64`	`contextID = hookContext.EvaluationContext().TargetingKey()`
`65`	`65`	`}`
`66`	`66`
`67`	`67`	`attributes[TelemetryContextID] = contextID`
`68`	`68`
`69`		`- setID, exists := details.EvaluationDetails.ResolutionDetail.FlagMetadata[TelemetryFlagMetaFlagSetId]`
	`69`	`+ setID, exists := details.FlagMetadata[TelemetryFlagMetaFlagSetId]`
`70`	`70`	`if exists {`
`71`	`71`	`attributes[TelemetryFlagSetID] = setID`
`72`	`72`	`}`
`73`	`73`
`74`		`- version, exists := details.EvaluationDetails.ResolutionDetail.FlagMetadata[TelemetryFlagMetaVersion]`
	`74`	`+ version, exists := details.FlagMetadata[TelemetryFlagMetaVersion]`
`75`	`75`	`if exists {`
`76`	`76`	`attributes[TelemetryVersion] = version`
`77`	`77`	`}`
`78`	`78`
`79`		`- if details.EvaluationDetails.ResolutionDetail.Reason == openfeature.ErrorReason {`
`80`		`- if details.ResolutionDetail.ErrorCode != "" {`
`81`		`- attributes[TelemetryErrorCode] = details.ResolutionDetail.ErrorCode`
	`79`	`+ if details.Reason == openfeature.ErrorReason {`
	`80`	`+ if details.ErrorCode != "" {`
	`81`	`+ attributes[TelemetryErrorCode] = details.ErrorCode`
`82`	`82`	`} else {`
`83`	`83`	`attributes[TelemetryErrorCode] = openfeature.GeneralCode`
`84`	`84`	`}`
`85`	`85`
`86`		`- if details.ResolutionDetail.ErrorMessage != "" {`
`87`		`- attributes[TelemetryErrorMsg] = details.ResolutionDetail.ErrorMessage`
	`86`	`+ if details.ErrorMessage != "" {`
	`87`	`+ attributes[TelemetryErrorMsg] = details.ErrorMessage`
`88`	`88`	`}`
`89`	`89`	`}`
`90`	`90`