Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit c4c4620

Browse files
committedDec 21, 2024·
fix: updating tests based on new DefaultLogger constructor signature
Signed-off-by: Kevin Long <kmlong1183@gmail.com>
1 parent 587bf1a commit c4c4620

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed
 

‎packages/shared/src/hooks/logging-hook.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,8 @@ export class LoggingHook implements BaseHook {
5555
this.logger.error(payload);
5656
}
5757

58-
finally(hookContext: Readonly<HookContext<FlagValue>>, hookHints?: HookHints): void {
58+
59+
finally(hookContext: Readonly<HookContext<FlagValue>>, evaluationDetails: EvaluationDetails<FlagValue>, hookHints?: HookHints): void {
5960
this.logger.info(hookContext, hookHints);
6061
}
6162

‎packages/shared/test/logger-hook.spec.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { GeneralError } from '../src/errors';
22
import type { HookContext } from '../src/hooks/hooks';
33
import { LoggingHook } from '../src/hooks/logging-hook';
4-
import { DefaultLogger, SafeLogger } from '../src/logger';
4+
import { DefaultLogger, LOG_LEVELS, LogLevel, SafeLogger } from '../src/logger';
55

66
describe('LoggingHook', () => {
77
const FLAG_KEY = 'some-key';
@@ -21,7 +21,7 @@ describe('LoggingHook', () => {
2121
const ERROR_MESSAGE_KEY = 'error_message';
2222

2323
let hookContext: HookContext;
24-
const logger : SafeLogger = new SafeLogger(new DefaultLogger(true, true));
24+
const logger : SafeLogger = new SafeLogger(new DefaultLogger(LogLevel.DEBUG));
2525

2626
beforeEach(() => {
2727
const mockProviderMetaData = { name: PROVIDER_NAME };

0 commit comments

Comments
 (0)
Please sign in to comment.