fix: Refactor strategy implementation

Signed-off-by: tmakinde <[email protected]>

Author: Tmakinde

src/implementation/multiprovider/strategy/FirstMatchStrategy.php

@@ -61,7 +61,7 @@ public function shouldEvaluateNextProvider(
             // Check if error is ThrowableWithResolutionError with FLAG_NOT_FOUND
             if ($error instanceof ThrowableWithResolutionError) {
                 $resolutionError = $error->getResolutionError();
-                if ($resolutionError->getResolutionErrorCode() === ErrorCode::FLAG_NOT_FOUND()) {
+                if ($resolutionError->getResolutionErrorCode()->equals(ErrorCode::FLAG_NOT_FOUND())) {
                     // Continue to next provider for FLAG_NOT_FOUND
                     return true;
                 }
@@ -108,7 +108,7 @@ public function determineFinalResult(
                 $isFlagNotFound = false;
                 if ($error instanceof ThrowableWithResolutionError) {
                     $resolutionError = $error->getResolutionError();
-                    if ($resolutionError->getResolutionErrorCode() === ErrorCode::FLAG_NOT_FOUND()) {
+                    if ($resolutionError->getResolutionErrorCode()->equals(ErrorCode::FLAG_NOT_FOUND())) {
                         $isFlagNotFound = true;
                     }
                 }

src/implementation/multiprovider/strategy/FirstSuccessfulStrategy.php

@@ -49,9 +49,9 @@ public function shouldEvaluateNextProvider(
         StrategyPerProviderContext $context,
         ProviderResolutionResult $result,
     ): bool {
-        // If we found a successful result, stop here
-        // Otherwise, continue to next provider (even if there was an error)
-        return $result->isSuccessful();
+        // If we found a successful result, stop here (return false)
+        // Otherwise, continue to next provider (return true)
+        return !$result->isSuccessful();
     }
 
     /**