fix!: provider resolveObject interface (#78)

Signed-off-by: Tom Carrio <[email protected]>

Author: tcarrio

src/implementation/provider/AbstractProvider.php

@@ -4,7 +4,6 @@
 
 namespace OpenFeature\implementation\provider;
 
-use DateTime;
 use OpenFeature\implementation\common\Metadata;
 use OpenFeature\interfaces\common\Metadata as MetadataInterface;
 use OpenFeature\interfaces\flags\EvaluationContext;
@@ -35,11 +34,10 @@ abstract public function resolveIntegerValue(string $flagKey, int $defaultValue,
 
     abstract public function resolveFloatValue(string $flagKey, float $defaultValue, ?EvaluationContext $context = null): ResolutionDetailsInterface;
 
-    abstract public function resolveObjectValue(
-        string $flagKey,
-        bool | string | int | float | DateTime | array | null $defaultValue,
-        ?EvaluationContext $context = null
-    ): ResolutionDetailsInterface;
+    /**
+     * @param mixed[] $defaultValue
+     */
+    abstract public function resolveObjectValue(string $flagKey, array $defaultValue, ?EvaluationContext $context = null): ResolutionDetailsInterface;
 
     /**
      * @return Hook[]

src/implementation/provider/NoOpProvider.php

@@ -4,7 +4,6 @@
 
 namespace OpenFeature\implementation\provider;
 
-use DateTime;
 use OpenFeature\interfaces\flags\EvaluationContext;
 use OpenFeature\interfaces\provider\Provider;
 use OpenFeature\interfaces\provider\ResolutionDetails as ResolutionDetailsInterface;
@@ -34,13 +33,10 @@ public function resolveFloatValue(string $flagKey, float $defaultValue, ?Evaluat
     }
 
     /**
-     * @param bool|string|int|float|DateTime|mixed[]|null $defaultValue
+     * @param mixed[] $defaultValue
      */
-    public function resolveObjectValue(
-        string $flagKey,
-        bool | string | int | float | DateTime | array | null $defaultValue,
-        ?EvaluationContext $context = null
-    ): ResolutionDetailsInterface {
+    public function resolveObjectValue(string $flagKey, array $defaultValue, ?EvaluationContext $context = null): ResolutionDetailsInterface
+    {
         return ResolutionDetailsFactory::fromSuccess($defaultValue);
     }
 }

src/interfaces/provider/Provider.php

@@ -4,7 +4,6 @@
 
 namespace OpenFeature\interfaces\provider;
 
-use DateTime;
 use OpenFeature\interfaces\common\MetadataGetter;
 use OpenFeature\interfaces\flags\EvaluationContext;
 use OpenFeature\interfaces\hooks\HooksGetter;
@@ -48,11 +47,7 @@ public function resolveFloatValue(string $flagKey, float $defaultValue, ?Evaluat
     /**
      * Resolves the flag value for the provided flag key as an object
      *
-     * @param bool|string|int|float|DateTime|mixed[]|null $defaultValue
+     * @param mixed[] $defaultValue
      */
-    public function resolveObjectValue(
-        string $flagKey,
-        bool | string | int | float | DateTime | array | null $defaultValue,
-        ?EvaluationContext $context = null
-    ): ResolutionDetails;
+    public function resolveObjectValue(string $flagKey, array $defaultValue, ?EvaluationContext $context = null): ResolutionDetails;
 }

tests/TestProvider.php

@@ -4,7 +4,6 @@
 
 namespace OpenFeature\Test;
 
-use DateTime;
 use OpenFeature\implementation\common\Metadata;
 use OpenFeature\implementation\provider\ResolutionDetailsFactory;
 use OpenFeature\interfaces\common\Metadata as MetadataInterface;
@@ -59,9 +58,9 @@ public function resolveFloatValue(string $flagKey, float $defaultValue, ?Evaluat
     }
 
     /**
-     * @param bool|string|int|float|DateTime|mixed[]|null $defaultValue
+     * @param mixed[] $defaultValue
      */
-    public function resolveObjectValue(string $flagKey, bool | string | int | float | DateTime | array | null $defaultValue, ?EvaluationContext $context = null): ResolutionDetails
+    public function resolveObjectValue(string $flagKey, array $defaultValue, ?EvaluationContext $context = null): ResolutionDetails
     {
         return ResolutionDetailsFactory::fromSuccess($defaultValue);
     }