From 31b1a58ae330e222db967723fae7cf869eb25417 Mon Sep 17 00:00:00 2001
From: Jordan Bayles <jophba@chromium.org>
Date: Tue, 7 Apr 2026 20:39:33 -0700
Subject: [PATCH 1/6] ci: suppress Node 20 deprecation and missing
 python-version warnings

- Injects `FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true` in all workflows to
  opt-in to Node.js 24 and suppress the deprecation warnings from
  multiple GitHub Actions.
- Specifies `python-version: '3.x'` for `actions/setup-python@v5` in
  `meson.yml` to fix the missing input warning.
---
 .github/workflows/clang-format.yml           | 3 +++
 .github/workflows/cmake.yml                  | 4 ++++
 .github/workflows/meson.yml                  | 7 +++++++
 .github/workflows/update-project-version.yml | 3 +++
 4 files changed, 17 insertions(+)

diff --git a/.github/workflows/clang-format.yml b/.github/workflows/clang-format.yml
index 221f8b839..eca3c31f5 100644
--- a/.github/workflows/clang-format.yml
+++ b/.github/workflows/clang-format.yml
@@ -1,6 +1,9 @@
 name: clang-format check
 on: [check_run, pull_request, push]
 
+env:
+  FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true
+
 jobs:
   formatting-check:
     name: formatting check
diff --git a/.github/workflows/cmake.yml b/.github/workflows/cmake.yml
index 91f387a50..55452ac25 100644
--- a/.github/workflows/cmake.yml
+++ b/.github/workflows/cmake.yml
@@ -1,5 +1,9 @@
 name: cmake
 on: [check_run, push, pull_request]
+
+env:
+  FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true
+
 jobs:
   cmake-publish:
     runs-on: ${{ matrix.os }}
diff --git a/.github/workflows/meson.yml b/.github/workflows/meson.yml
index 22fe32f72..92d04862f 100644
--- a/.github/workflows/meson.yml
+++ b/.github/workflows/meson.yml
@@ -2,6 +2,9 @@ name: meson build and test
 run-name: update pushed to ${{ github.ref }}
 on: [check_run, push, pull_request]
 
+env:
+  FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true
+
 jobs:
   meson-publish:
     runs-on: ${{ matrix.os }}
@@ -17,6 +20,8 @@ jobs:
         
       - name: setup python
         uses: actions/setup-python@v5
+        with:
+          python-version: '3.x'
       
       - name: meson build
         uses: BSFishy/meson-build@v1.0.3
@@ -41,6 +46,8 @@ jobs:
         
       - name: setup python
         uses: actions/setup-python@v5
+        with:
+          python-version: '3.x'
       
       - name: meson build
         uses: BSFishy/meson-build@v1.0.3
diff --git a/.github/workflows/update-project-version.yml b/.github/workflows/update-project-version.yml
index c00363837..c47e53790 100644
--- a/.github/workflows/update-project-version.yml
+++ b/.github/workflows/update-project-version.yml
@@ -11,6 +11,9 @@ on:
         description: 'next soversion (e.g., 28). leave blank to keep current.'
         required: false
 
+env:
+  FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true
+
 jobs:
   bump-and-verify:
     runs-on: ubuntu-latest

From f7bc5a38571a0ad23edecb55bdbc948649ce594e Mon Sep 17 00:00:00 2001
From: Jordan Bayles <jophba@chromium.org>
Date: Tue, 7 Apr 2026 21:58:40 -0700
Subject: [PATCH 2/6] Fix C++11 ABI breakage when compiled with C++17 (#1668)

When JSONCPP_HAS_STRING_VIEW was defined, the library dropped the
`const char*` and `const String&` overloads for `operator[]`, `get`,
`removeMember`, and `isMember`, breaking ABI compatibility for projects
consuming the library with C++11.

This change unconditionally declares and defines the legacy overloads
so they are always exported, restoring compatibility.
---
 include/json/value.h        | 15 +++++----------
 src/lib_json/json_value.cpp | 15 +++++----------
 2 files changed, 10 insertions(+), 20 deletions(-)

diff --git a/include/json/value.h b/include/json/value.h
index f32f45609..1369f9207 100644
--- a/include/json/value.h
+++ b/include/json/value.h
@@ -501,7 +501,7 @@ class JSON_API Value {
   /// that name.
   /// \param key may contain embedded nulls.
   const Value& operator[](std::string_view key) const;
-#else
+#endif
   /// Access an object value by name, create a null member if it does not exist.
   /// \note Because of our implementation, keys are limited to 2^30 -1 chars.
   /// Exceeding that will cause an exception.
@@ -516,7 +516,6 @@ class JSON_API Value {
   /// that name.
   /// \param key may contain embedded nulls.
   const Value& operator[](const String& key) const;
-#endif
   /** \brief Access an object value by name, create a null member if it does not
    * exist.
    *
@@ -534,7 +533,7 @@ class JSON_API Value {
   /// Return the member named key if it exist, defaultValue otherwise.
   /// \note deep copy
   Value get(std::string_view key, const Value& defaultValue) const;
-#else
+#endif
   /// Return the member named key if it exist, defaultValue otherwise.
   /// \note deep copy
   Value get(const char* key, const Value& defaultValue) const;
@@ -542,7 +541,6 @@ class JSON_API Value {
   /// \note deep copy
   /// \param key may contain embedded nulls.
   Value get(const String& key, const Value& defaultValue) const;
-#endif
   /// Return the member named key if it exist, defaultValue otherwise.
   /// \note deep copy
   /// \note key may contain embedded nulls.
@@ -589,12 +587,11 @@ class JSON_API Value {
   /// \post type() is unchanged
 #if JSONCPP_HAS_STRING_VIEW
   void removeMember(std::string_view key);
-#else
+#endif
   void removeMember(const char* key);
   /// Same as removeMember(const char*)
   /// \param key may contain embedded nulls.
   void removeMember(const String& key);
-#endif
   /** \brief Remove the named map member.
    *
    *  Update 'removed' iff removed.
@@ -603,12 +600,11 @@ class JSON_API Value {
    */
 #if JSONCPP_HAS_STRING_VIEW
   bool removeMember(std::string_view key, Value* removed);
-#else
+#endif
   bool removeMember(String const& key, Value* removed);
   /// Same as removeMember(const char* begin, const char* end, Value* removed),
   /// but 'key' is null-terminated.
   bool removeMember(const char* key, Value* removed);
-#endif
   /// Same as removeMember(String const& key, Value* removed)
   bool removeMember(const char* begin, const char* end, Value* removed);
   /** \brief Remove the indexed array element.
@@ -623,14 +619,13 @@ class JSON_API Value {
   /// Return true if the object has a member named key.
   /// \param key may contain embedded nulls.
   bool isMember(std::string_view key) const;
-#else
+#endif
   /// Return true if the object has a member named key.
   /// \note 'key' must be null-terminated.
   bool isMember(const char* key) const;
   /// Return true if the object has a member named key.
   /// \param key may contain embedded nulls.
   bool isMember(const String& key) const;
-#endif
   /// Same as isMember(String const& key)const
   bool isMember(const char* begin, const char* end) const;
 
diff --git a/src/lib_json/json_value.cpp b/src/lib_json/json_value.cpp
index 74f77896f..953d58eae 100644
--- a/src/lib_json/json_value.cpp
+++ b/src/lib_json/json_value.cpp
@@ -1200,7 +1200,7 @@ const Value& Value::operator[](std::string_view key) const {
 Value& Value::operator[](std::string_view key) {
   return resolveReference(key.data(), key.data() + key.length());
 }
-#else
+#endif
 const Value& Value::operator[](const char* key) const {
   Value const* found = find(key, key + strlen(key));
   if (!found)
@@ -1221,7 +1221,6 @@ Value& Value::operator[](const char* key) {
 Value& Value::operator[](const String& key) {
   return resolveReference(key.data(), key.data() + key.length());
 }
-#endif
 
 Value& Value::operator[](const StaticString& key) {
   return resolveReference(key.c_str());
@@ -1265,14 +1264,13 @@ Value Value::get(char const* begin, char const* end,
 Value Value::get(std::string_view key, const Value& defaultValue) const {
   return get(key.data(), key.data() + key.length(), defaultValue);
 }
-#else
+#endif
 Value Value::get(char const* key, Value const& defaultValue) const {
   return get(key, key + strlen(key), defaultValue);
 }
 Value Value::get(String const& key, Value const& defaultValue) const {
   return get(key.data(), key.data() + key.length(), defaultValue);
 }
-#endif
 
 bool Value::removeMember(const char* begin, const char* end, Value* removed) {
   if (type() != objectValue) {
@@ -1292,14 +1290,13 @@ bool Value::removeMember(const char* begin, const char* end, Value* removed) {
 bool Value::removeMember(std::string_view key, Value* removed) {
   return removeMember(key.data(), key.data() + key.length(), removed);
 }
-#else
+#endif
 bool Value::removeMember(const char* key, Value* removed) {
   return removeMember(key, key + strlen(key), removed);
 }
 bool Value::removeMember(String const& key, Value* removed) {
   return removeMember(key.data(), key.data() + key.length(), removed);
 }
-#endif
 
 #ifdef JSONCPP_HAS_STRING_VIEW
 void Value::removeMember(std::string_view key) {
@@ -1312,7 +1309,7 @@ void Value::removeMember(std::string_view key) {
                      CZString::noDuplication);
   value_.map_->erase(actualKey);
 }
-#else
+#endif
 void Value::removeMember(const char* key) {
   JSON_ASSERT_MESSAGE(type() == nullValue || type() == objectValue,
                       "in Json::Value::removeMember(): requires objectValue");
@@ -1323,7 +1320,6 @@ void Value::removeMember(const char* key) {
   value_.map_->erase(actualKey);
 }
 void Value::removeMember(const String& key) { removeMember(key.c_str()); }
-#endif
 
 bool Value::removeIndex(ArrayIndex index, Value* removed) {
   if (type() != arrayValue) {
@@ -1357,14 +1353,13 @@ bool Value::isMember(char const* begin, char const* end) const {
 bool Value::isMember(std::string_view key) const {
   return isMember(key.data(), key.data() + key.length());
 }
-#else
+#endif
 bool Value::isMember(char const* key) const {
   return isMember(key, key + strlen(key));
 }
 bool Value::isMember(String const& key) const {
   return isMember(key.data(), key.data() + key.length());
 }
-#endif
 
 Value::Members Value::getMemberNames() const {
   JSON_ASSERT_MESSAGE(

From 60149bcb54b320bdd722ea78e311b031cf0357bb Mon Sep 17 00:00:00 2001
From: Jordan Bayles <jophba@chromium.org>
Date: Wed, 8 Apr 2026 12:16:57 -0700
Subject: [PATCH 3/6] ci: add ABI compatibility matrix workflow

This adds a new GitHub Actions workflow to verify ABI compatibility across C++ standard boundaries. It explicitly tests the scenario where JsonCpp is built with one standard (e.g., C++11) and consumed by an application built with a newer one (e.g., C++23), and vice versa.

To facilitate testing the specific `std::string_view` boundary that is conditionally compiled, a new `stringView` demo application has been added to the `example/` directory and is consumed directly by the CI matrix to ensure standard library symbols link correctly across standard versions, build types (shared/static), and operating systems.
---
 .github/workflows/abi-compatibility.yml | 79 +++++++++++++++++++++++++
 example/BUILD.bazel                     |  6 ++
 example/CMakeLists.txt                  |  1 +
 example/stringView/stringView.cpp       | 29 +++++++++
 4 files changed, 115 insertions(+)
 create mode 100644 .github/workflows/abi-compatibility.yml
 create mode 100644 example/stringView/stringView.cpp

diff --git a/.github/workflows/abi-compatibility.yml b/.github/workflows/abi-compatibility.yml
new file mode 100644
index 000000000..881c4e8e0
--- /dev/null
+++ b/.github/workflows/abi-compatibility.yml
@@ -0,0 +1,79 @@
+name: ABI Compatibility
+
+on: [check_run, push, pull_request]
+
+env:
+  FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true
+
+jobs:
+  abi-compatibility:
+    runs-on: ${{ matrix.os }}
+
+    strategy:
+      fail-fast: false
+      matrix:
+        os: [ubuntu-latest, windows-latest, macos-latest]
+        shared_libs: [ON, OFF]
+        include:
+          - jsoncpp_std: 11
+            app_std: 23
+          - jsoncpp_std: 23
+            app_std: 11
+
+    steps:
+      - name: checkout project
+        uses: actions/checkout@v4
+
+      - name: build and install JsonCpp (C++${{ matrix.jsoncpp_std }})
+        shell: bash
+        run: |
+          mkdir build-jsoncpp
+          cd build-jsoncpp
+          cmake .. -DCMAKE_CXX_STANDARD=${{ matrix.jsoncpp_std }} \
+                   -DCMAKE_CXX_STANDARD_REQUIRED=ON \
+                   -DCMAKE_INSTALL_PREFIX=$GITHUB_WORKSPACE/install-jsoncpp \
+                   -DBUILD_SHARED_LIBS=${{ matrix.shared_libs }} \
+                   -DJSONCPP_WITH_TESTS=OFF
+          cmake --build . --config Release
+          cmake --install . --config Release
+
+      - name: create example app
+        shell: bash
+        run: |
+          mkdir example-app
+          cat << 'EOF' > example-app/CMakeLists.txt
+          cmake_minimum_required(VERSION 3.10)
+          project(abi_test)
+
+          find_package(jsoncpp REQUIRED CONFIG)
+
+          add_executable(abi_test stringView.cpp)
+          target_link_libraries(abi_test PRIVATE JsonCpp::JsonCpp)
+          EOF
+
+          cp $GITHUB_WORKSPACE/example/stringView/stringView.cpp example-app/stringView.cpp
+
+      - name: build example app (C++${{ matrix.app_std }})
+        shell: bash
+        run: |
+          cd example-app
+          mkdir build
+          cd build
+          cmake .. -DCMAKE_CXX_STANDARD=${{ matrix.app_std }} \
+                   -DCMAKE_CXX_STANDARD_REQUIRED=ON \
+                   -DCMAKE_PREFIX_PATH=$GITHUB_WORKSPACE/install-jsoncpp
+          cmake --build . --config Release
+
+      - name: run example app
+        shell: bash
+        run: |
+          if [ "$RUNNER_OS" == "Windows" ]; then
+            export PATH=$GITHUB_WORKSPACE/install-jsoncpp/bin:$PATH
+            ./example-app/build/Release/abi_test.exe
+          elif [ "$RUNNER_OS" == "macOS" ]; then
+            export DYLD_LIBRARY_PATH=$GITHUB_WORKSPACE/install-jsoncpp/lib:$DYLD_LIBRARY_PATH
+            ./example-app/build/abi_test
+          else
+            export LD_LIBRARY_PATH=$GITHUB_WORKSPACE/install-jsoncpp/lib:$LD_LIBRARY_PATH
+            ./example-app/build/abi_test
+          fi
diff --git a/example/BUILD.bazel b/example/BUILD.bazel
index ebbd0b58e..35813085b 100644
--- a/example/BUILD.bazel
+++ b/example/BUILD.bazel
@@ -33,3 +33,9 @@ cc_binary(
     srcs = ["stringWrite/stringWrite.cpp"],
     deps = ["//:jsoncpp"],
 )
+
+cc_binary(
+    name = "stringView",
+    srcs = ["stringView/stringView.cpp"],
+    deps = ["//:jsoncpp"],
+)
diff --git a/example/CMakeLists.txt b/example/CMakeLists.txt
index 230d1bd7b..0666db763 100644
--- a/example/CMakeLists.txt
+++ b/example/CMakeLists.txt
@@ -4,6 +4,7 @@ set(EXAMPLES
     readFromStream
     stringWrite
     streamWrite
+    stringView
 )
 add_definitions(-D_GLIBCXX_USE_CXX11_ABI)
 
diff --git a/example/stringView/stringView.cpp b/example/stringView/stringView.cpp
new file mode 100644
index 000000000..34f6841db
--- /dev/null
+++ b/example/stringView/stringView.cpp
@@ -0,0 +1,29 @@
+#include "json/json.h"
+#include <iostream>
+#include <cstdlib>
+
+#if defined(JSONCPP_HAS_STRING_VIEW)
+#include <string_view>
+#endif
+
+/**
+ * \brief Example using std::string_view with JsonCpp.
+ */
+int main() {
+  Json::Value root;
+  root["key"] = "value";
+
+#if defined(JSONCPP_HAS_STRING_VIEW)
+  std::cout << "Has string_view support" << std::endl;
+  std::string_view sv("key");
+  if (root.isMember(sv)) {
+    std::cout << root[sv].asString() << std::endl;
+  }
+#else
+  std::cout << "No string_view support" << std::endl;
+  if (root.isMember("key")) {
+    std::cout << root["key"].asString() << std::endl;
+  }
+#endif
+  return EXIT_SUCCESS;
+}

From 3b927e488dd8a54ba1465864cd19d186744e581d Mon Sep 17 00:00:00 2001
From: Jordan Bayles <jophba@chromium.org>
Date: Thu, 9 Apr 2026 10:23:07 -0700
Subject: [PATCH 4/6] fix: inline std::string_view methods to prevent ABI
 breaks

This commit completely eliminates the ABI breakage that occurs across C++ standard boundaries when using `std::string_view`.

Previously, when the library was built with C++17+, CMake would leak `JSONCPP_HAS_STRING_VIEW=1` as a PUBLIC definition. A C++11 consumer would receive this definition, attempt to parse the header, and fail with compiler errors because `std::string_view` is not available in their environment.

Conversely, if the library was built in C++11 (without `string_view` symbols), a C++17 consumer would naturally define `JSONCPP_HAS_STRING_VIEW` based on `__cplusplus` inside `value.h`. The consumer would then call the declared `string_view` methods, resulting in linker errors because the methods weren't compiled into the library.

By moving all `std::string_view` overloads directly into `value.h` as `inline` methods that delegate to the fundamental `const char*, const char*` methods:
1. The consumer's compiler dictates whether the overloads are visible (via `__cplusplus >= 201703L`).
2. The consumer compiles the inline wrappers locally, removing any reliance on the library's exported symbols for `std::string_view`.
3. CMake no longer needs to pollute the consumer's environment with PUBLIC compile definitions.
---
 include/json/value.h        | 39 +++++++++++++++++++-----
 src/lib_json/CMakeLists.txt |  9 ------
 src/lib_json/json_value.cpp | 59 -------------------------------------
 3 files changed, 31 insertions(+), 76 deletions(-)

diff --git a/include/json/value.h b/include/json/value.h
index 1369f9207..2007e6b42 100644
--- a/include/json/value.h
+++ b/include/json/value.h
@@ -357,7 +357,8 @@ class JSON_API Value {
   Value(const StaticString& value);
   Value(const String& value);
 #ifdef JSONCPP_HAS_STRING_VIEW
-  Value(std::string_view value);
+  inline Value(std::string_view value)
+      : Value(value.data(), value.data() + value.length()) {}
 #endif
   Value(bool value);
   Value(std::nullptr_t ptr) = delete;
@@ -405,7 +406,14 @@ class JSON_API Value {
   /** Get string_view of string-value.
    *  \return false if !string. (Seg-fault if str is NULL.)
    */
-  bool getString(std::string_view* str) const;
+  inline bool getString(std::string_view* str) const {
+    char const* begin;
+    char const* end;
+    if (!getString(&begin, &end))
+      return false;
+    *str = std::string_view(begin, static_cast<size_t>(end - begin));
+    return true;
+  }
 #endif
   Int asInt() const;
   UInt asUInt() const;
@@ -496,11 +504,18 @@ class JSON_API Value {
 #ifdef JSONCPP_HAS_STRING_VIEW
   /// Access an object value by name, create a null member if it does not exist.
   /// \param key may contain embedded nulls.
-  Value& operator[](std::string_view key);
+  inline Value& operator[](std::string_view key) {
+    return resolveReference(key.data(), key.data() + key.length());
+  }
   /// Access an object value by name, returns null if there is no member with
   /// that name.
   /// \param key may contain embedded nulls.
-  const Value& operator[](std::string_view key) const;
+  inline const Value& operator[](std::string_view key) const {
+    Value const* found = find(key.data(), key.data() + key.length());
+    if (!found)
+      return nullSingleton();
+    return *found;
+  }
 #endif
   /// Access an object value by name, create a null member if it does not exist.
   /// \note Because of our implementation, keys are limited to 2^30 -1 chars.
@@ -532,7 +547,9 @@ class JSON_API Value {
 #ifdef JSONCPP_HAS_STRING_VIEW
   /// Return the member named key if it exist, defaultValue otherwise.
   /// \note deep copy
-  Value get(std::string_view key, const Value& defaultValue) const;
+  inline Value get(std::string_view key, const Value& defaultValue) const {
+    return get(key.data(), key.data() + key.length(), defaultValue);
+  }
 #endif
   /// Return the member named key if it exist, defaultValue otherwise.
   /// \note deep copy
@@ -586,7 +603,9 @@ class JSON_API Value {
   /// \pre type() is objectValue or nullValue
   /// \post type() is unchanged
 #if JSONCPP_HAS_STRING_VIEW
-  void removeMember(std::string_view key);
+  inline void removeMember(std::string_view key) {
+    removeMember(key.data(), key.data() + key.length(), nullptr);
+  }
 #endif
   void removeMember(const char* key);
   /// Same as removeMember(const char*)
@@ -599,7 +618,9 @@ class JSON_API Value {
    *  \return true iff removed (no exceptions)
    */
 #if JSONCPP_HAS_STRING_VIEW
-  bool removeMember(std::string_view key, Value* removed);
+  inline bool removeMember(std::string_view key, Value* removed) {
+    return removeMember(key.data(), key.data() + key.length(), removed);
+  }
 #endif
   bool removeMember(String const& key, Value* removed);
   /// Same as removeMember(const char* begin, const char* end, Value* removed),
@@ -618,7 +639,9 @@ class JSON_API Value {
 #ifdef JSONCPP_HAS_STRING_VIEW
   /// Return true if the object has a member named key.
   /// \param key may contain embedded nulls.
-  bool isMember(std::string_view key) const;
+  inline bool isMember(std::string_view key) const {
+    return isMember(key.data(), key.data() + key.length());
+  }
 #endif
   /// Return true if the object has a member named key.
   /// \note 'key' must be null-terminated.
diff --git a/src/lib_json/CMakeLists.txt b/src/lib_json/CMakeLists.txt
index 03e933552..a0695e9eb 100644
--- a/src/lib_json/CMakeLists.txt
+++ b/src/lib_json/CMakeLists.txt
@@ -131,9 +131,6 @@ if(BUILD_SHARED_LIBS)
 
     target_compile_features(${SHARED_LIB} PUBLIC ${REQUIRED_FEATURES})
 
-    if(JSONCPP_HAS_STRING_VIEW)
-        target_compile_definitions(${SHARED_LIB} PUBLIC JSONCPP_HAS_STRING_VIEW=1)
-    endif()
 
     target_include_directories(${SHARED_LIB} PUBLIC
         $<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>
@@ -168,9 +165,6 @@ if(BUILD_STATIC_LIBS)
 
     target_compile_features(${STATIC_LIB} PUBLIC ${REQUIRED_FEATURES})
 
-    if(JSONCPP_HAS_STRING_VIEW)
-        target_compile_definitions(${STATIC_LIB} PUBLIC JSONCPP_HAS_STRING_VIEW=1)
-    endif()
 
     target_include_directories(${STATIC_LIB} PUBLIC
         $<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>
@@ -198,9 +192,6 @@ if(BUILD_OBJECT_LIBS)
 
     target_compile_features(${OBJECT_LIB} PUBLIC ${REQUIRED_FEATURES})
 
-    if(JSONCPP_HAS_STRING_VIEW)
-        target_compile_definitions(${OBJECT_LIB} PUBLIC JSONCPP_HAS_STRING_VIEW=1)
-    endif()
 
     target_include_directories(${OBJECT_LIB} PUBLIC
         $<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>
diff --git a/src/lib_json/json_value.cpp b/src/lib_json/json_value.cpp
index 953d58eae..e1846dd86 100644
--- a/src/lib_json/json_value.cpp
+++ b/src/lib_json/json_value.cpp
@@ -441,13 +441,6 @@ Value::Value(const String& value) {
       value.data(), static_cast<unsigned>(value.length()));
 }
 
-#ifdef JSONCPP_HAS_STRING_VIEW
-Value::Value(std::string_view value) {
-  initBasic(stringValue, true);
-  value_.string_ = duplicateAndPrefixStringValue(
-      value.data(), static_cast<unsigned>(value.length()));
-}
-#endif
 
 Value::Value(const StaticString& value) {
   initBasic(stringValue);
@@ -656,20 +649,6 @@ bool Value::getString(char const** begin, char const** end) const {
   return true;
 }
 
-#ifdef JSONCPP_HAS_STRING_VIEW
-bool Value::getString(std::string_view* str) const {
-  if (type() != stringValue)
-    return false;
-  if (value_.string_ == nullptr)
-    return false;
-  const char* begin;
-  unsigned length;
-  decodePrefixedString(this->isAllocated(), this->value_.string_, &length,
-                       &begin);
-  *str = std::string_view(begin, length);
-  return true;
-}
-#endif
 
 String Value::asString() const {
   switch (type()) {
@@ -1190,17 +1169,6 @@ Value* Value::demand(char const* begin, char const* end) {
                       "objectValue or nullValue");
   return &resolveReference(begin, end);
 }
-#ifdef JSONCPP_HAS_STRING_VIEW
-const Value& Value::operator[](std::string_view key) const {
-  Value const* found = find(key.data(), key.data() + key.length());
-  if (!found)
-    return nullSingleton();
-  return *found;
-}
-Value& Value::operator[](std::string_view key) {
-  return resolveReference(key.data(), key.data() + key.length());
-}
-#endif
 const Value& Value::operator[](const char* key) const {
   Value const* found = find(key, key + strlen(key));
   if (!found)
@@ -1260,11 +1228,6 @@ Value Value::get(char const* begin, char const* end,
   Value const* found = find(begin, end);
   return !found ? defaultValue : *found;
 }
-#ifdef JSONCPP_HAS_STRING_VIEW
-Value Value::get(std::string_view key, const Value& defaultValue) const {
-  return get(key.data(), key.data() + key.length(), defaultValue);
-}
-#endif
 Value Value::get(char const* key, Value const& defaultValue) const {
   return get(key, key + strlen(key), defaultValue);
 }
@@ -1286,11 +1249,6 @@ bool Value::removeMember(const char* begin, const char* end, Value* removed) {
   value_.map_->erase(it);
   return true;
 }
-#ifdef JSONCPP_HAS_STRING_VIEW
-bool Value::removeMember(std::string_view key, Value* removed) {
-  return removeMember(key.data(), key.data() + key.length(), removed);
-}
-#endif
 bool Value::removeMember(const char* key, Value* removed) {
   return removeMember(key, key + strlen(key), removed);
 }
@@ -1298,18 +1256,6 @@ bool Value::removeMember(String const& key, Value* removed) {
   return removeMember(key.data(), key.data() + key.length(), removed);
 }
 
-#ifdef JSONCPP_HAS_STRING_VIEW
-void Value::removeMember(std::string_view key) {
-  JSON_ASSERT_MESSAGE(type() == nullValue || type() == objectValue,
-                      "in Json::Value::removeMember(): requires objectValue");
-  if (type() == nullValue)
-    return;
-
-  CZString actualKey(key.data(), unsigned(key.length()),
-                     CZString::noDuplication);
-  value_.map_->erase(actualKey);
-}
-#endif
 void Value::removeMember(const char* key) {
   JSON_ASSERT_MESSAGE(type() == nullValue || type() == objectValue,
                       "in Json::Value::removeMember(): requires objectValue");
@@ -1349,11 +1295,6 @@ bool Value::isMember(char const* begin, char const* end) const {
   Value const* value = find(begin, end);
   return nullptr != value;
 }
-#ifdef JSONCPP_HAS_STRING_VIEW
-bool Value::isMember(std::string_view key) const {
-  return isMember(key.data(), key.data() + key.length());
-}
-#endif
 bool Value::isMember(char const* key) const {
   return isMember(key, key + strlen(key));
 }

From 853a9d08593994e19c1220e9769f1648cf0bf8f0 Mon Sep 17 00:00:00 2001
From: Jordan Bayles <jophba@chromium.org>
Date: Thu, 9 Apr 2026 10:29:51 -0700
Subject: [PATCH 5/6] run clang format

---
 src/lib_json/json_value.cpp | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/lib_json/json_value.cpp b/src/lib_json/json_value.cpp
index e1846dd86..a8eb72d6b 100644
--- a/src/lib_json/json_value.cpp
+++ b/src/lib_json/json_value.cpp
@@ -441,7 +441,6 @@ Value::Value(const String& value) {
       value.data(), static_cast<unsigned>(value.length()));
 }
 
-
 Value::Value(const StaticString& value) {
   initBasic(stringValue);
   value_.string_ = const_cast<char*>(value.c_str());
@@ -649,7 +648,6 @@ bool Value::getString(char const** begin, char const** end) const {
   return true;
 }
 
-
 String Value::asString() const {
   switch (type()) {
   case nullValue:

From a7f60c7ad2dce6850f6ae0f928b9ea7859b659a4 Mon Sep 17 00:00:00 2001
From: Jordan Bayles <jophba@chromium.org>
Date: Thu, 9 Apr 2026 10:32:38 -0700
Subject: [PATCH 6/6] finish clang format

---
 example/stringView/stringView.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/example/stringView/stringView.cpp b/example/stringView/stringView.cpp
index 34f6841db..b5e33e9fd 100644
--- a/example/stringView/stringView.cpp
+++ b/example/stringView/stringView.cpp
@@ -1,6 +1,6 @@
 #include "json/json.h"
-#include <iostream>
 #include <cstdlib>
+#include <iostream>
 
 #if defined(JSONCPP_HAS_STRING_VIEW)
 #include <string_view>