-
Notifications
You must be signed in to change notification settings - Fork 81
Feature/compose click name from modifiers #1408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feature/compose click name from modifiers #1408
Conversation
(cherry picked from commit 7e36c1efb2c450051da424d868be2a5fbaad5628)
(cherry picked from commit 7883fbdd4bd53a2c41f96fb0a0f1a6db4a27d100)
(cherry picked from commit a088638b217ec60e707adad03c04bbb2be35f8d1)
(cherry picked from commit c2b4483761a40eed2a771e74190c7b25e57f8134)
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1408 +/- ##
==========================================
- Coverage 64.12% 63.41% -0.71%
==========================================
Files 154 160 +6
Lines 3063 3154 +91
Branches 316 331 +15
==========================================
+ Hits 1964 2000 +36
- Misses 1009 1059 +50
- Partials 90 95 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hey @Mateusz-Stasielowicz - as this is marked as draft I'm assuming it doesn't need review yet. Please comment here or mark it as ready for review when the time comes. |
This PR enchances the compose-click module for better detection of the name of tapped compose element.
It introduces two ways of detecting name of the tapped element:
Modifier.opentelemetry- introduces a custom Modifier (similar solution is used by other telemetry SDKs like Datadog and Sentry. Developers can use this modifier to mark a composable element and give it a name. Then the compose-click module will be able to easily find such tapped element and retrieve a name from it.Modifier.testTag- handling as a fallback to read the TestTag value of tapped element. TestTag is often used for Unit tests and therefore it is useful to take it during composable element name discovery.