Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmd/telemetrygen] Add support for different exporters in telemetrygen API #37175

Open
Erog38 opened this issue Jan 13, 2025 · 3 comments
Open
Labels
cmd/telemetrygen telemetrygen command enhancement New feature or request

Comments

@Erog38
Copy link
Contributor

Erog38 commented Jan 13, 2025

Component(s)

cmd/telemetrygen

Is your feature request related to a problem? Please describe.

In order to run testing for various telemetry signals against differing exporter types, I'd like to propose updating the configurations for traces, metrics, and logs, in order to push in a custom exporter or trace provider.

Describe the solution you'd like

In conjunction with #37044, this could look something like this:

func MetricExporterFactory() (sdkmetric.Exporter, error) {
...
   return otlpmetricgrpc.New(context.Background(), exporterOpts...)
}

...
mc := metrics.NewConfig()
mc.Endpoint = "localhost:1234"
mc.RunDuration = 5 * time.Second
mc.ExporterFactory = MetricExporterFactory
err := metrics.Start(mc)

Describe alternatives you've considered

No response

Additional context

This concept does rely on #37044 to go forward which would open up the API in general allowing for use of the telemetry generation logic. I'm hopeful we can make it work 😄

@Erog38 Erog38 added enhancement New feature or request needs triage New item requiring triage labels Jan 13, 2025
@github-actions github-actions bot added the cmd/telemetrygen telemetrygen command label Jan 13, 2025
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@Erog38
Copy link
Contributor Author

Erog38 commented Jan 13, 2025

The immediate thought on this is to help support things like Apache Arrow via letting users configure telemetry generation tests using exporters other than OTLP based on business needs

@crobert-1
Copy link
Member

Removing needs triage as this issue makes sense to me and was filed by a code owner.

@crobert-1 crobert-1 removed the needs triage New item requiring triage label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/telemetrygen telemetrygen command enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants