Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/elasticsearch] Omit process.executable.name to avoid mapping conflict in ECS mode #37211

Open
carsonip opened this issue Jan 14, 2025 · 4 comments
Labels

Comments

@carsonip
Copy link
Contributor

carsonip commented Jan 14, 2025

Component(s)

exporter/elasticsearch

Is your feature request related to a problem? Please describe.

As process.executable.path will be translated to process.executable in ECS mode, if there's also a process.executable.name, after dedot and dedup, it will look like this, possibly causing mapping conflict / breaking the UI

{
  ...
  "executable":{
    "name":"foo",
    "value":"/usr/bin/foo"
    ...
}

Describe the solution you'd like

Silently omit process.executable.name

Describe alternatives you've considered

No response

Additional context

No response

@carsonip carsonip added enhancement New feature or request needs triage New item requiring triage labels Jan 14, 2025
@carsonip
Copy link
Contributor Author

/label -needs-triage

Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot removed the needs triage New item requiring triage label Jan 14, 2025
@felixbarny
Copy link
Contributor

Combining this with any process.executable in record level attributes, it will even become an invalid json:

Are you able to reproduce this scenario? I tried but wasn't able to. If it's reproducible, we should fix that as well.

@carsonip
Copy link
Contributor Author

No, that is not reproducible. The data point attribute process.executable will override process.executable.value. I have updated the issue to remove the incorrect description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants