-
Notifications
You must be signed in to change notification settings - Fork 1.9k
bump minimum version of go to 1.25 #14567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Follows the normal procedure with the release of go 1.26 Signed-off-by: alex boten <[email protected]>
Signed-off-by: alex boten <[email protected]>
|
Looks like oldstable has not been updated yet |
mx-psi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo the oldstable update
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (81.81%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #14567 +/- ##
==========================================
- Coverage 91.82% 91.79% -0.03%
==========================================
Files 679 679
Lines 42857 42839 -18
==========================================
- Hits 39352 39324 -28
- Misses 2438 2444 +6
- Partials 1067 1071 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Okay after retrying we seem to have the following issues:
|
|
The contrib tests failures will be fixed with open-telemetry/opentelemetry-collector-contrib#45903 |
|
Okay @ycombinator would appreciate your help! |
Signed-off-by: alex boten <[email protected]>
Signed-off-by: alex boten <[email protected]>
|
@mx-psi i think that's all the linter errors, i don't know what to do about the fips thing |
|
From golang/go#74630 (comment):
Should we disable the check for now? |
|
A comment on another thread Azure/azure-sdk-for-go#25848 (comment):
|
+1 to this |
This is blocking the go upgrade, see open-telemetry#14567 for more details. Part of open-telemetry#13925 Signed-off-by: alex boten <[email protected]>
|
Disabled it in a separate PR, see #14571 |
This is blocking the go upgrade, see #14567 for more details. Part of #13925 Signed-off-by: alex boten <[email protected]>
b81f7c7
Follows the normal procedure with the release of go 1.26