Skip to content

Commit 950f940

Browse files
authored
rename jaeger exporter target (#918)
1 parent db8289f commit 950f940

File tree

2 files changed

+15
-12
lines changed

2 files changed

+15
-12
lines changed

examples/jaeger/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,4 @@ target_link_libraries(jaeger_foo_library ${CMAKE_THREAD_LIBS_INIT}
77
add_executable(example_jaeger main.cc)
88
target_link_libraries(
99
example_jaeger ${CMAKE_THREAD_LIBS_INIT} jaeger_foo_library
10-
opentelemetry_trace jaeger_trace_exporter)
10+
opentelemetry_trace opentelemetry_exporter_jaeger_trace)

exporters/jaeger/CMakeLists.txt

Lines changed: 14 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -13,32 +13,34 @@ set(JAEGER_EXPORTER_SOURCES
1313
src/jaeger_exporter.cc src/thrift_sender.cc src/udp_transport.cc
1414
src/recordable.cc src/TUDPTransport.cc)
1515

16-
add_library(jaeger_trace_exporter ${JAEGER_EXPORTER_SOURCES}
17-
${JAEGER_THRIFT_GENCPP_SOURCES})
16+
add_library(opentelemetry_exporter_jaeger_trace ${JAEGER_EXPORTER_SOURCES}
17+
${JAEGER_THRIFT_GENCPP_SOURCES})
1818

19-
set_target_properties(jaeger_trace_exporter PROPERTIES EXPORT_NAME
20-
jaeger_trace_exporter)
19+
set_target_properties(
20+
opentelemetry_exporter_jaeger_trace
21+
PROPERTIES EXPORT_NAME opentelemetry_exporter_jaeger_trace)
2122

2223
target_include_directories(
23-
jaeger_trace_exporter
24+
opentelemetry_exporter_jaeger_trace
2425
PUBLIC "$<BUILD_INTERFACE:${CMAKE_CURRENT_LIST_DIR}/include>"
2526
"$<INSTALL_INTERFACE:include>")
2627

2728
target_link_libraries(
28-
jaeger_trace_exporter
29+
opentelemetry_exporter_jaeger_trace
2930
PUBLIC opentelemetry_resources
3031
PRIVATE thrift::thrift)
3132

3233
if(MSVC)
33-
target_compile_definitions(jaeger_trace_exporter PUBLIC NOMINMAX)
34+
target_compile_definitions(opentelemetry_exporter_jaeger_trace
35+
PUBLIC NOMINMAX)
3436
if(NOT BUILD_SHARED_LIBS)
35-
target_compile_definitions(jaeger_trace_exporter
37+
target_compile_definitions(opentelemetry_exporter_jaeger_trace
3638
PUBLIC THRIFT_STATIC_DEFINE)
3739
endif()
3840
endif()
3941

4042
install(
41-
TARGETS jaeger_trace_exporter
43+
TARGETS opentelemetry_exporter_jaeger_trace
4244
EXPORT "${PROJECT_NAME}-target"
4345
RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR}
4446
LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}
@@ -52,8 +54,9 @@ install(
5254

5355
if(BUILD_TESTING)
5456
add_executable(jaeger_recordable_test test/jaeger_recordable_test.cc)
55-
target_link_libraries(jaeger_recordable_test ${GTEST_BOTH_LIBRARIES}
56-
${CMAKE_THREAD_LIBS_INIT} jaeger_trace_exporter)
57+
target_link_libraries(
58+
jaeger_recordable_test ${GTEST_BOTH_LIBRARIES} ${CMAKE_THREAD_LIBS_INIT}
59+
opentelemetry_exporter_jaeger_trace)
5760

5861
gtest_add_tests(
5962
TARGET jaeger_recordable_test

0 commit comments

Comments
 (0)