Skip to content

Conversation

@zeitlinger
Copy link
Member

Follow up to #7496

@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

❌ Patch coverage is 76.92308% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.15%. Comparing base (2c379c7) to head (fdc808c).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...ator/internal/ObfuscatedExtendedOpenTelemetry.java 33.33% 6 Missing ⚠️

❌ Your patch check has failed because the patch coverage (76.92%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7799      +/-   ##
============================================
- Coverage     90.16%   90.15%   -0.01%     
- Complexity     7202     7220      +18     
============================================
  Files           816      820       +4     
  Lines         21737    21790      +53     
  Branches       2130     2135       +5     
============================================
+ Hits          19599    19645      +46     
- Misses         1468     1474       +6     
- Partials        670      671       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zeitlinger
Copy link
Member Author

@jack-berg we missed that in the last PR on extended open telemetry

Copy link
Member

@jack-berg jack-berg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Thanks!

Method getOpenTelemetrySdk =
openTelemetrySdkAutoConfiguration.getMethod("getOpenTelemetrySdk");
return new ObfuscatedOpenTelemetry(
return IncubatingUtil.obfuscatedOpenTelemetry(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#nit: I think we should consider moving the logic from IncubatingUtil.obfuscatedOpenTelemetry into GlobalOpenTelemetry. Its a bit jarring to see code that looks like it will be using incubating code even when the incubator is not present. Also allows the standard ObfuscatedOpenTelemetry class to stay put here. It looks like its incubating when it lives as an inner class of IncubatingUtil.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

2 participants