Skip to content

Commit 1c70783

Browse files
committed
address review feedback: remove redundant public API tests and unrelated changes
- Drop TestPublicApi test class; griffe already verifies the public API in CI - Revert test-requirements.txt and tox.ini changes (unrelated to this PR) Assisted-by: Claude Sonnet 4.6
1 parent 5b31b44 commit 1c70783

3 files changed

Lines changed: 5 additions & 21 deletions

File tree

opentelemetry-sdk/tests/logs/test_multi_log_processor.py

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -46,18 +46,6 @@ def force_flush(self, timeout_millis=30000):
4646
return True
4747

4848

49-
class TestPublicApi(unittest.TestCase):
50-
def test_synchronous_multi_log_record_processor_is_public(self):
51-
from opentelemetry.sdk._logs import ( # noqa: F401
52-
SynchronousMultiLogRecordProcessor,
53-
)
54-
55-
def test_concurrent_multi_log_record_processor_is_public(self):
56-
from opentelemetry.sdk._logs import ( # noqa: F401
57-
ConcurrentMultiLogRecordProcessor,
58-
)
59-
60-
6149
class TestLogRecordProcessor(unittest.TestCase):
6250
def test_log_record_processor(self):
6351
provider = LoggerProvider()

tests/opentelemetry-test-utils/test-requirements.txt

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,8 @@ wrapt==1.16.0
1111
-e opentelemetry-sdk
1212
-e opentelemetry-semantic-conventions
1313
-e tests/opentelemetry-test-utils
14-
# these are required for weaver integration tests
15-
# excluded on PyPy + Windows: there's no grpcio PyPy wheel and the gRPC C core
16-
# fails to build from source with MSVC (test skips via _HAS_GRPC guard)
17-
./opentelemetry-proto ; platform_python_implementation != 'PyPy' or platform_system != 'Windows'
18-
./exporter/opentelemetry-exporter-otlp-proto-common ; platform_python_implementation != 'PyPy' or platform_system != 'Windows'
19-
./exporter/opentelemetry-exporter-otlp-proto-grpc ; platform_python_implementation != 'PyPy' or platform_system != 'Windows'
14+
# these are required for weaver integration tests, we're running that only on linux / CPython
15+
# because of lack of support for gRPC wheels on some platforms
16+
./opentelemetry-proto ; platform_python_implementation != 'PyPy'
17+
./exporter/opentelemetry-exporter-otlp-proto-common ; platform_python_implementation != 'PyPy'
18+
./exporter/opentelemetry-exporter-otlp-proto-grpc ; platform_python_implementation != 'PyPy'

tox.ini

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -106,9 +106,6 @@ envlist =
106106
lint-opentelemetry-propagator-jaeger
107107

108108
; skip py314t until grpc gets wheels for it or we stop using grpc exporter in weaver tests
109-
; pypy3 runs the weaver tests on Linux only: weaver now uses tonic (pure Rust), so the
110-
; grpc C core crash is gone (see issue #5176), but grpcio still has no PyPy wheel and won't
111-
; build from source on Windows — there the weaver tests skip via the _HAS_GRPC guard
112109
py3{10,11,12,13,14}-test-opentelemetry-test-utils
113110
pypy3-test-opentelemetry-test-utils
114111
lint-opentelemetry-test-utils

0 commit comments

Comments
 (0)