build: remove update-version.sh wrappers, patch repo.ini in Python

Both .github/scripts/update-version*.sh existed only to sed the new
version into repo.ini before invoking the corresponding Python
script, a holdover from eachdist.py never accepting a target version
as a CLI argument. update_version.py and update_patch_version.py now
take the new versions directly and patch repo.ini themselves via
update_repo_ini_version() (an in-place text substitution equivalent
to the old sed command, not a ConfigParser round-trip, so comments
and formatting in repo.ini are preserved). The 3 call sites in
prepare-release-branch.yml and prepare-patch-release.yml now invoke
the Python scripts directly.

Author: ocelotl

.changelog/5381.removed

@@ -1 +1 @@
-Removed `scripts/eachdist.py` in favor of tox and small purpose-built scripts: `scripts/version.py`, `scripts/update_version.py`, and `scripts/update_patch_version.py` for release version bumping, and `scripts/repo_targets.py` for distribution discovery. Renamed `eachdist.ini` to `repo.ini`.
+Removed `scripts/eachdist.py` and the `.github/scripts/update-version*.sh` wrappers in favor of tox and small purpose-built scripts: `scripts/version.py`, `scripts/update_version.py`, and `scripts/update_patch_version.py` for release version bumping, and `scripts/repo_targets.py` for distribution discovery. Renamed `eachdist.ini` to `repo.ini`.

.github/scripts/update-version-patch.sh

@@ -55,7 +55,7 @@ jobs:
           echo "UNSTABLE_VERSION_PREV=$unstable_version_prev" >> $GITHUB_ENV
 
       - name: Update version
-        run: .github/scripts/update-version-patch.sh $STABLE_VERSION $UNSTABLE_VERSION $STABLE_VERSION_PREV $UNSTABLE_VERSION_PREV
+        run: ./scripts/update_patch_version.py --stable_version=$STABLE_VERSION --unstable_version=$UNSTABLE_VERSION --stable_version_prev=$STABLE_VERSION_PREV --unstable_version_prev=$UNSTABLE_VERSION_PREV
 
       - name: Generate changelog
         run: towncrier build --yes --version "$STABLE_VERSION/$UNSTABLE_VERSION"

.github/scripts/update-version.sh

@@ -81,7 +81,7 @@ jobs:
           echo "RELEASE_BRANCH_NAME=$release_branch_name" >> $GITHUB_ENV
 
       - name: Update version
-        run: .github/scripts/update-version.sh $STABLE_VERSION $UNSTABLE_VERSION
+        run: ./scripts/update_version.py --stable_version=$STABLE_VERSION --unstable_version=$UNSTABLE_VERSION
 
       - name: Generate changelog
         run: towncrier build --yes --version "$STABLE_VERSION/$UNSTABLE_VERSION"
@@ -175,7 +175,7 @@ jobs:
           echo "UNSTABLE_NEXT_VERSION=${unstable_next_version}.dev" >> $GITHUB_ENV
 
       - name: Update version
-        run: .github/scripts/update-version.sh $STABLE_NEXT_VERSION $UNSTABLE_NEXT_VERSION
+        run: ./scripts/update_version.py --stable_version=$STABLE_NEXT_VERSION --unstable_version=$UNSTABLE_NEXT_VERSION
 
       - name: Generate changelog
         run: towncrier build --yes --version "$STABLE_VERSION/$UNSTABLE_VERSION"

.github/workflows/prepare-patch-release.yml

@@ -7,7 +7,11 @@
 from sys import exit
 
 from repo_targets import find_projectroot, find_targets_unordered
-from version_files import update_patch_dependencies, update_version_files
+from version_files import (
+    update_patch_dependencies,
+    update_repo_ini_version,
+    update_version_files,
+)
 
 
 def parse_args():
@@ -28,6 +32,10 @@ def main():
 
     rootpath = find_projectroot()
     targets = list(find_targets_unordered(rootpath))
+
+    update_repo_ini_version(rootpath, "stable", args.stable_version)
+    update_repo_ini_version(rootpath, "prerelease", args.unstable_version)
+
     cfg = ConfigParser()
     cfg.read(str(rootpath / "repo.ini"))
 

.github/workflows/prepare-release-branch.yml

@@ -7,14 +7,19 @@
 from sys import exit
 
 from repo_targets import find_projectroot, find_targets_unordered
-from version_files import update_dependencies, update_version_files
+from version_files import (
+    update_dependencies,
+    update_repo_ini_version,
+    update_version_files,
+)
 
 
 def parse_args():
     parser = ArgumentParser(
         description="Updates version numbers, used by maintainers and CI"
     )
-    parser.add_argument("--versions", required=True)
+    parser.add_argument("--stable_version", required=True)
+    parser.add_argument("--unstable_version", required=True)
     return parser.parse_args()
 
 
@@ -25,13 +30,18 @@ def main():
 
     rootpath = find_projectroot()
     targets = list(find_targets_unordered(rootpath))
+
+    update_repo_ini_version(rootpath, "stable", args.stable_version)
+    update_repo_ini_version(rootpath, "prerelease", args.unstable_version)
+
     cfg = ConfigParser()
     cfg.read(str(rootpath / "repo.ini"))
 
-    for group in args.versions.split(","):
-        mcfg = cfg[group]
-        version = mcfg["version"]
-        packages = mcfg["packages"].split()
+    for group, version in (
+        ("stable", args.stable_version),
+        ("prerelease", args.unstable_version),
+    ):
+        packages = cfg[group]["packages"].split()
         print(f"update {group} packages to {version}")
         update_dependencies(targets, version, packages)
         update_version_files(targets, version, packages)

scripts/update_patch_version.py

@@ -72,6 +72,18 @@ def update_files(targets, filename, search, replace):
             _file.write(sub(search, replace, text))
 
 
+def update_repo_ini_version(rootpath, section, version):
+    repo_ini_path = rootpath / "repo.ini"
+    text = repo_ini_path.read_text(encoding="utf-8")
+    text = sub(
+        rf"(\[{section}\]\nversion=).*",
+        lambda match: match.group(1) + version,
+        text,
+        count=1,
+    )
+    repo_ini_path.write_text(text, encoding="utf-8")
+
+
 def update_dependencies(targets, version, packages):
     print("updating dependencies")
     for pkg in packages: