Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fr] Move new observability-primer page under docs #5913

Open
chalin opened this issue Jan 10, 2025 · 2 comments · May be fixed by #5927
Open

[fr] Move new observability-primer page under docs #5913

chalin opened this issue Jan 10, 2025 · 2 comments · May be fixed by #5927
Labels
bug Something isn't working docs lang:fr

Comments

@chalin
Copy link
Contributor

chalin commented Jan 10, 2025

Originally posted by @chalin in #5833 (comment):

@iguitton - ah, it's because the newly added page isn't under docs. The page was published at:

You'll need to move it to be under content/fr/docs, i.e., https://opentelemetry.io/fr/docs/concepts/observability-primer/.
@chalin chalin mentioned this issue Jan 10, 2025
Merged
@chalin chalin added lang:fr bug Something isn't working docs labels Jan 10, 2025
@chalin
Copy link
Contributor Author

chalin commented Jan 10, 2025 •
edited
Loading

@open-telemetry/docs-maintainers - for the record, we could have detected this via:

$ npm run check:i18n | grep fr/
File not found  content/en/concepts/observability-primer.md - content/fr/concepts/observability-primer.md - en was removed or renamed

Should we fail a build check when locale pages are no longer found? Or maybe have a PR check that would add a comment to that effect? I'd say not at this point, but it might be worth considering.

@iguitton
Copy link
Contributor

Thanks @chalin for investigating this issue and for providing me with the solution to fix it. I will make the required changes.

iguitton added a commit to iguitton/opentelemetry.io that referenced this issue Jan 14, 2025
@iguitton
Issue open-telemetry#5913 Move new observability primer page
32e5fea 
* moved observability-primer.md under fr/docs/concepts
iguitton added a commit to iguitton/opentelemetry.io that referenced this issue Jan 14, 2025
@iguitton
Issue open-telemetry#5913: Move new observability primer page
2c92ec7 
* Updated hastag in what-is-opentelemetry.md
iguitton added a commit to iguitton/opentelemetry.io that referenced this issue Jan 14, 2025
@iguitton
Issue open-telemetry#5913 Move new observability primer page
dda9adc 
New attempt to fix the link issue
iguitton added a commit to iguitton/opentelemetry.io that referenced this issue Jan 14, 2025
@iguitton
Issue open-telemetry#5913 Move new observability primer page
07f7135 
* Testing a fix
iguitton added a commit to iguitton/opentelemetry.io that referenced this issue Jan 14, 2025
@iguitton
Issue open-telemetry#5913 Move new observability primer page
9779583 
* Attempt to fix the link issue from _index.md
iguitton added a commit to iguitton/opentelemetry.io that referenced this issue Jan 14, 2025
@iguitton
Issue open-telemetry#5913: Move new observability primer page
edb0baa 
* Fixed the link issue (adopted the same url format as the Spanish and Portuguese versions)
iguitton added a commit to iguitton/opentelemetry.io that referenced this issue Jan 14, 2025
@iguitton
Issue open-telemetry#5913 Move the new observability primer page
2249f26 
* Fixed remaining bug
@chalin chalin linked a pull request Jan 14, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working docs lang:fr
Projects
SIG Comms: PRs & Issues
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[fr] Move new observability primer page iguitton/opentelemetry.io
2 participants
@chalin @iguitton