Skip to content

Commit 052b052

Browse files
authored
Enable ghost_commit feature by default (#6041)
## Summary - enable the ghost_commit feature flag by default ## Testing - just fmt ------ https://chatgpt.com/codex/tasks/task_i_6904ce2d0370832dbb3c2c09a90fb188
1 parent 6951872 commit 052b052

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

codex-rs/core/src/features.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -284,7 +284,7 @@ pub const FEATURES: &[FeatureSpec] = &[
284284
id: Feature::GhostCommit,
285285
key: "ghost_commit",
286286
stage: Stage::Experimental,
287-
default_enabled: false,
287+
default_enabled: true,
288288
},
289289
FeatureSpec {
290290
id: Feature::WindowsSandbox,

codex-rs/core/tests/suite/otel.rs

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
use codex_core::features::Feature;
12
use codex_protocol::protocol::AskForApproval;
23
use codex_protocol::protocol::EventMsg;
34
use codex_protocol::protocol::Op;
@@ -101,6 +102,7 @@ async fn process_sse_emits_failed_event_on_parse_error() {
101102

102103
let TestCodex { codex, .. } = test_codex()
103104
.with_config(move |config| {
105+
config.features.disable(Feature::GhostCommit);
104106
config.model_provider.request_max_retries = Some(0);
105107
config.model_provider.stream_max_retries = Some(0);
106108
})
@@ -141,6 +143,7 @@ async fn process_sse_records_failed_event_when_stream_closes_without_completed()
141143

142144
let TestCodex { codex, .. } = test_codex()
143145
.with_config(move |config| {
146+
config.features.disable(Feature::GhostCommit);
144147
config.model_provider.request_max_retries = Some(0);
145148
config.model_provider.stream_max_retries = Some(0);
146149
})
@@ -193,6 +196,7 @@ async fn process_sse_failed_event_records_response_error_message() {
193196

194197
let TestCodex { codex, .. } = test_codex()
195198
.with_config(move |config| {
199+
config.features.disable(Feature::GhostCommit);
196200
config.model_provider.request_max_retries = Some(0);
197201
config.model_provider.stream_max_retries = Some(0);
198202
})
@@ -243,6 +247,7 @@ async fn process_sse_failed_event_logs_parse_error() {
243247

244248
let TestCodex { codex, .. } = test_codex()
245249
.with_config(move |config| {
250+
config.features.disable(Feature::GhostCommit);
246251
config.model_provider.request_max_retries = Some(0);
247252
config.model_provider.stream_max_retries = Some(0);
248253
})
@@ -288,6 +293,7 @@ async fn process_sse_failed_event_logs_missing_error() {
288293

289294
let TestCodex { codex, .. } = test_codex()
290295
.with_config(move |config| {
296+
config.features.disable(Feature::GhostCommit);
291297
config.model_provider.request_max_retries = Some(0);
292298
config.model_provider.stream_max_retries = Some(0);
293299
})
@@ -333,6 +339,7 @@ async fn process_sse_failed_event_logs_response_completed_parse_error() {
333339

334340
let TestCodex { codex, .. } = test_codex()
335341
.with_config(move |config| {
342+
config.features.disable(Feature::GhostCommit);
336343
config.model_provider.request_max_retries = Some(0);
337344
config.model_provider.stream_max_retries = Some(0);
338345
})
@@ -438,6 +445,7 @@ async fn handle_response_item_records_tool_result_for_custom_tool_call() {
438445

439446
let TestCodex { codex, .. } = test_codex()
440447
.with_config(move |config| {
448+
config.features.disable(Feature::GhostCommit);
441449
config.model_provider.request_max_retries = Some(0);
442450
config.model_provider.stream_max_retries = Some(0);
443451
})
@@ -497,6 +505,7 @@ async fn handle_response_item_records_tool_result_for_function_call() {
497505

498506
let TestCodex { codex, .. } = test_codex()
499507
.with_config(move |config| {
508+
config.features.disable(Feature::GhostCommit);
500509
config.model_provider.request_max_retries = Some(0);
501510
config.model_provider.stream_max_retries = Some(0);
502511
})
@@ -566,6 +575,7 @@ async fn handle_response_item_records_tool_result_for_local_shell_missing_ids()
566575

567576
let TestCodex { codex, .. } = test_codex()
568577
.with_config(move |config| {
578+
config.features.disable(Feature::GhostCommit);
569579
config.model_provider.request_max_retries = Some(0);
570580
config.model_provider.stream_max_retries = Some(0);
571581
})
@@ -619,6 +629,7 @@ async fn handle_response_item_records_tool_result_for_local_shell_call() {
619629

620630
let TestCodex { codex, .. } = test_codex()
621631
.with_config(move |config| {
632+
config.features.disable(Feature::GhostCommit);
622633
config.model_provider.request_max_retries = Some(0);
623634
config.model_provider.stream_max_retries = Some(0);
624635
})

0 commit comments

Comments
 (0)