Skip to content

Commit d13ee79

Browse files
authored
[MCP] Don't require experimental_use_rmcp_client for no-auth http servers (#4689)
The `experimental_use_rmcp_client` flag is still useful to: 1. Toggle between stdio clients 2. Enable oauth beacuse we want to land modelcontextprotocol/rust-sdk#469, #4677, and binary signing before we enable it by default However, for no-auth http servers, there is only one option so we don't need the flag and it seems to be working pretty well.
1 parent bde468f commit d13ee79

File tree

1 file changed

+0
-14
lines changed

1 file changed

+0
-14
lines changed

codex-rs/core/src/mcp_connection_manager.rs

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -108,9 +108,6 @@ impl McpClientAdapter {
108108
params: mcp_types::InitializeRequestParams,
109109
startup_timeout: Duration,
110110
) -> Result<Self> {
111-
info!(
112-
"new_stdio_client use_rmcp_client: {use_rmcp_client} program: {program:?} args: {args:?} env: {env:?} params: {params:?} startup_timeout: {startup_timeout:?}"
113-
);
114111
if use_rmcp_client {
115112
let client = Arc::new(RmcpClient::new_stdio_client(program, args, env).await?);
116113
client.initialize(params, Some(startup_timeout)).await?;
@@ -205,17 +202,6 @@ impl McpConnectionManager {
205202
continue;
206203
}
207204

208-
if matches!(
209-
cfg.transport,
210-
McpServerTransportConfig::StreamableHttp { .. }
211-
) && !use_rmcp_client
212-
{
213-
info!(
214-
"skipping MCP server `{server_name}` because the legacy MCP client only supports stdio servers",
215-
);
216-
continue;
217-
}
218-
219205
let startup_timeout = cfg.startup_timeout_sec.unwrap_or(DEFAULT_STARTUP_TIMEOUT);
220206
let tool_timeout = cfg.tool_timeout_sec.unwrap_or(DEFAULT_TOOL_TIMEOUT);
221207

0 commit comments

Comments
 (0)