-
Notifications
You must be signed in to change notification settings - Fork 3.6k
add summary operation to codex-rs/core #1527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aibrahim-oai
wants to merge
9
commits into
main
Choose a base branch
from
summary_op
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+77
−0
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
658d69e
add summary operation
aibrahim-oai f77fab3
adding tests
aibrahim-oai 99df99d
progress
aibrahim-oai f8d6e97
review
aibrahim-oai 133ad67
review
aibrahim-oai f30e25a
warnings
aibrahim-oai 80c5891
Merge branch 'main' into summary_op
aibrahim-oai 2bc78ea
Merge branch 'main' into summary_op
aibrahim-oai a026e1e
Merge branch 'main' into summary_op
aibrahim-oai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
#![expect(clippy::unwrap_used, clippy::expect_used)] | ||
|
||
//! Tests for the `Op::SummarizeContext` operation added to verify that | ||
//! summarization requests are properly handled and injected as user input. | ||
|
||
use std::time::Duration; | ||
|
||
use codex_core::Codex; | ||
use codex_core::protocol::EventMsg; | ||
use codex_core::protocol::Op; | ||
mod test_support; | ||
use tempfile::TempDir; | ||
use test_support::load_default_config_for_test; | ||
use tokio::time::timeout; | ||
|
||
/// Helper function to set up a codex session and wait for it to be configured | ||
async fn setup_configured_codex_session() -> Codex { | ||
let codex_home = TempDir::new().unwrap(); | ||
let config = load_default_config_for_test(&codex_home); | ||
let (codex, _, _) = codex_core::codex_wrapper::init_codex(config).await.unwrap(); | ||
codex | ||
} | ||
|
||
#[tokio::test] | ||
async fn test_summarize_context_spawns_new_agent_task() { | ||
// Test the specific behavior: when there's no current task, | ||
// SummarizeContext should spawn a new AgentTask with the summarization prompt | ||
let codex = setup_configured_codex_session().await; | ||
|
||
// At this point, there should be no current task running | ||
let _sub_id = codex.submit(Op::SummarizeContext).await.unwrap(); | ||
|
||
let event = timeout(Duration::from_secs(5), codex.next_event()) | ||
.await | ||
.expect("timeout waiting for task started event") | ||
.expect("codex closed"); | ||
|
||
assert!( | ||
matches!(event.msg, EventMsg::TaskStarted), | ||
"Expected TaskStarted when no current task exists - should spawn new AgentTask" | ||
); | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.