Skip to content

Use shared network gating helper in chat completion tests #6461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2025
Merged

Use shared network gating helper in chat completion tests #6461

merged 1 commit into from
Nov 14, 2025
+18 −106

Conversation

@aibrahim-oai
Copy link
Collaborator

@aibrahim-oai aibrahim-oai commented Nov 10, 2025

Summary

  • replace the bespoke network check in the chat completion payload and SSE tests with the existing skip_if_no_network! helper so they follow the same gating convention as the rest of the suite

Testing

  • just fmt

Codex Task

@etraut-openai etraut-openai added the oai-pr PRs posted by Codex team members label Nov 10, 2025
@aibrahim-oai aibrahim-oai merged commit f3c6b13 into main Nov 14, 2025
25 checks passed
@aibrahim-oai aibrahim-oai deleted the codex/refactor-network-gating-helpers-for-consistency branch November 14, 2025 01:11
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pakrym-oai pakrym-oai pakrym-oai approved these changes

Assignees

No one assigned

Labels

codex oai-pr PRs posted by Codex team members

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aibrahim-oai @pakrym-oai @etraut-openai