Skip to content

Commit 632e4a0

Browse files
committed
Address Copilot comments
1 parent 66ede34 commit 632e4a0

File tree

3 files changed

+9
-8
lines changed

3 files changed

+9
-8
lines changed

src/guardrails/agents.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -644,7 +644,7 @@ def __new__(
644644
prompt_arg: Any | None = agent_kwargs.get("prompt")
645645
resolved_instructions = _resolve_agent_instructions(instructions, prompt_arg)
646646

647-
if resolved_instructions is None and prompt_arg is None:
647+
if resolved_instructions is None:
648648
raise ValueError(
649649
"GuardrailAgent requires either 'instructions' or 'prompt' to initialize the underlying Agent."
650650
)

tests/conftest.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
import types
1313
from collections.abc import Iterator
1414
from dataclasses import dataclass
15+
from pathlib import Path
1516
from types import SimpleNamespace
1617
from typing import Any
1718

@@ -55,6 +56,11 @@ class _DummyResponse:
5556
delta: str | None = None
5657

5758

59+
_GUARDRAILS_PACKAGE_STUB = types.ModuleType("guardrails")
60+
_GUARDRAILS_PACKAGE_STUB.__path__ = [str(Path(__file__).resolve().parents[1] / "src" / "guardrails")]
61+
sys.modules.setdefault("guardrails", _GUARDRAILS_PACKAGE_STUB)
62+
63+
5864
_STUB_OPENAI_MODULE = types.ModuleType("openai")
5965
_STUB_OPENAI_MODULE.AsyncOpenAI = _StubAsyncOpenAI
6066
_STUB_OPENAI_MODULE.OpenAI = _StubSyncOpenAI

tests/unit/test_agents.py

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,18 +6,13 @@
66
import types
77
from collections.abc import Callable
88
from dataclasses import dataclass
9-
from pathlib import Path
109
from types import SimpleNamespace
1110
from typing import Any
1211

1312
import pytest
1413

15-
guardrails_pkg = types.ModuleType("guardrails")
16-
guardrails_pkg.__path__ = [str(Path(__file__).resolve().parents[2] / "src" / "guardrails")]
17-
sys.modules.setdefault("guardrails", guardrails_pkg)
18-
19-
from guardrails._openai_utils import SAFETY_IDENTIFIER_HEADER, SAFETY_IDENTIFIER_VALUE # noqa: E402
20-
from guardrails.types import GuardrailResult # noqa: E402
14+
from guardrails._openai_utils import SAFETY_IDENTIFIER_HEADER, SAFETY_IDENTIFIER_VALUE
15+
from guardrails.types import GuardrailResult
2116

2217
# ---------------------------------------------------------------------------
2318
# Stub agents SDK module so guardrails.agents can import required symbols.

0 commit comments

Comments
 (0)