Skip to content
This repository has been archived by the owner on Jun 14, 2023. It is now read-only.

Data view : Display tiny label with emoji #12

Open
tdurand opened this issue Jan 6, 2021 · 8 comments
Open

Data view : Display tiny label with emoji #12

tdurand opened this issue Jan 6, 2021 · 8 comments
Labels
enhancement New feature or request

Comments

@tdurand
Copy link
Member

tdurand commented Jan 6, 2021

Right now we are displaying 6 mobility classes, but ideally would be better to just display the 6 most counted classes depending on the data recorded... I'm testing on my desk and would love to see some laptop / coffee / chair OpenMojis ;-)

TODO:

  • need to map all the COCO classes to an emoji in the config.json
  • rewrite a bit the code to display the 6 most counted items
@tdurand tdurand added the enhancement New feature or request label Jan 6, 2021
@b-g
Copy link
Member

b-g commented Jan 7, 2021

RE: need to map all the COCO classes to an emoji in the config.json
Where is the config.json file, couldn't find it in the repo? What about pulling the latest OpenMoji 13 version?

@tdurand
Copy link
Member Author

tdurand commented Jan 7, 2021

yep, need to also update to the latest OpenMoji SVGs

there is not config.json in this repo, we use the one from the main repo.

Just need to complete the DISPLAY_CLASSES

https://github.com/opendatacam/opendatacam/blob/master/config.json#L24

The coco classes: "person", "bicycle", "car", "motorcycle", "airplane", "bus", "train", "truck", "boat", "traffic light",
"fire hydrant", "stop sign", "parking meter", "bench", "bird", "cat", "dog", "horse", "sheep", "cow",
"elephant", "bear", "zebra", "giraffe", "backpack", "umbrella", "handbag", "tie", "suitcase", "frisbee",
"skis", "snowboard", "sports ball", "kite", "baseball bat", "baseball glove", "skateboard", "surfboard",
"tennis racket", "bottle", "wine glass", "cup", "fork", "knife", "spoon", "bowl", "banana", "apple",
"sandwich", "orange", "broccoli", "carrot", "hot dog", "pizza", "donut", "cake", "chair", "couch",
"potted plant", "bed", "dining table", "toilet", "tv", "laptop", "mouse", "remote", "keyboard", "cell phone",
"microwave", "oven", "toaster", "sink", "refrigerator", "book", "clock", "vase", "scissors", "teddy bear",
"hair drier", "toothbrush"

@b-g
Copy link
Member

b-g commented Jan 7, 2021

Will do ... tomorrow.

@b-g
Copy link
Member

b-g commented Jan 8, 2021

Ok. Mapped all COCO classes to hexcodes (and OpenMoji) ... see https://docs.google.com/spreadsheets/d/1PuwHMTkRK5TMgS-xrN99U6Wnv8CoFT8nmvJW5sOIiWg/edit?usp=sharing (it might be a good idea to link this doc somewhere in the readme, as it gives a nice overview, where?).

What to do with the one e.g. parking meter, where there is no hexcode / no OpenMoji extra available? Maybe "missing font/char" https://openmoji.org/library/#search=missing&emoji=25A1?

@b-g
Copy link
Member

b-g commented Jan 8, 2021

PS. the config.json might hold a small bug. Check motorcycle vs. motorbike.

@tdurand
Copy link
Member Author

tdurand commented Jan 8, 2021

nice thanks ! working on including this for next beta... and yes I think "missing font/char" is ok...

yes will add on the documentation here: https://github.com/opendatacam/opendatacam/blob/master/documentation/CONFIG.md#display-custom-classes

@tdurand
Copy link
Member Author

tdurand commented Jan 10, 2021

got this implemented.. currently displaying the most counted classes, and if there is just one, display just one... makes things a bit clearer.. now I think should also add the label as the emoji sometimes isn't available + not necessary very clear

@b-g
Copy link
Member

b-g commented Jan 11, 2021

Yes to tiny labels. In case the the counter detail view is big enough I would also add a hint in the title e.g. "{counter-name} (top 6 classes)"

@tdurand tdurand changed the title Data view : Display 6 most counted classes Data view : Display tiny label with emoji Jan 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants