Skip to content
This repository has been archived by the owner on Jun 14, 2023. It is now read-only.

Init screen #15

Open
tdurand opened this issue Jan 6, 2021 · 1 comment
Open

Init screen #15

tdurand opened this issue Jan 6, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@tdurand
Copy link
Member

tdurand commented Jan 6, 2021

Note for my future self 😁

I added the loading screen so now we have a much cleaner experience.. the transition is still not very very good when we are loading the localhost:8080 view (the app) once the node.js app has started.. there is a quick flicker of 1 second where we jump from the "fake" loading screen (a simple index.html file) to the "real" one served by node.

the solution for this is to entirely get rid of the "real" loading screen as when node.js has started on Android YOLO has already started so we could directly render the main UI ..

But cause of some shortcut I took in the implementation this is not super straightforward to do.. as we expect that the main UI is rendered on the client and not on the server / or on a static generation.. there is some reliance on the window object that needs to be removed and then we could bypass it.

See some window reliance : https://github.com/opendatacam/opendatacam/blob/master/utils/colors.js#L29

Then we should be able to set true to isListeningToYOLO at init: https://github.com/opendatacam/opendatacam/blob/master/statemanagement/app/AppStateManagement.js#L30 , and it should render the UI : https://github.com/opendatacam/opendatacam/blob/master/components/MainPage.js#L92

@tdurand tdurand added the enhancement New feature or request label Jan 6, 2021
@tdurand tdurand changed the title Loading screen flickering Loading screen transition Jan 6, 2021
@tdurand tdurand changed the title Loading screen transition Init screen Jan 11, 2021
@tdurand
Copy link
Member Author

tdurand commented Jan 11, 2021

  • to fix, right now we can't download the logs on the init screen as they very briefly show up..

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant