fix: Fixing get_storage functionality as per new django52.
#421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #421 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 16 16
Lines 435 442 +7
Branches 47 49 +2
=========================================
+ Hits 435 442 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
awais786
commented
May 20, 2025
requirements/test.in
Outdated
| @@ -9,3 +9,4 @@ pytest-cov # pytest extension for code coverage statistics | |||
| pytest-django # pytest extension for better Django support | |||
| rules # Authorization rules for test cases | |||
| testfixtures # Provides the LogCapture utility used in some tests | |||
| django-storages | |||
There was a problem hiding this comment.
Adding for tests only.
|
@feanil Please review this. |
UsamaSadiq
approved these changes
May 21, 2025
|
@feanil waiting for your approval on this PR to merge this. |
|
@feanil its ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing get_storage method.