Skip to content

Commit 77fe61c

Browse files
authored
fix: CourseEnrollment list serializer error on deleted Course (#36378)
If a course is deleted or unpublished, the CourseEnrollment list serializer was causing a AttributeErrors when called for a learner who had been enrolled in the formerly-existing course. Why no test? Because cache invalidation is the worst problem. tl;dr I could create a mock response for the `course_overview` property, but if I mocked up a response to the queryset filter in `CourseEnrollmentsApiListView`, I was effectively guessing that my code worked correctly and then creating a mock response that was an assertion of correctness. That would make any mocked test deceptive; it would appear to test behavior but it would actually just test that I had constructed a mock that passed the test. I wanted to make an actual test for what would happen if a Course was deleted, so I made one character code fix, and then spent two days unsuccessfully attempting to completely clear out the ModuleStore so I could actually test what would happen in this instance. IMO an actual verification by hand (which I performed, and it works) was the better part of valor. in short, cache invalidation aaaaaaaaargh. FIXES: APER-3913
1 parent 62e5904 commit 77fe61c

File tree

1 file changed

+1
-1
lines changed
  • openedx/core/djangoapps/enrollments

1 file changed

+1
-1
lines changed

openedx/core/djangoapps/enrollments/views.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -1017,7 +1017,7 @@ def get_queryset(self):
10171017
emails = form.cleaned_data.get("email")
10181018

10191019
if course_id:
1020-
queryset = queryset.filter(course_id=course_id)
1020+
queryset = queryset.filter(course__id=course_id)
10211021
if usernames:
10221022
queryset = queryset.filter(user__username__in=usernames)
10231023
if emails:

0 commit comments

Comments
 (0)