feat: refactor country disable logic into the Embargo app #36202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deborahgu
requested changes
Feb 3, 2025
deborahgu
added
the
waiting on author
hassan-raza-1
changed the title
hassan-raza-1
changed the title
hassan-raza-1
force-pushed
the
hraza/add_embargo_restricted_country
branch
from
b786611 to
682e58e
Compare
deborahgu
added
waiting for eng review
muhammadadeeltajamul
approved these changes
Feb 6, 2025
deborahgu
added
waiting on author
|
@hassan-raza-1 @AhtishamShahid looks like this just has a couple of conflicts to resolve and then we can merge it. |
hassan-raza-1
force-pushed
the
hraza/add_embargo_restricted_country
branch
from
391e0d8 to
8a5b10f
Compare
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
AhtishamShahid
added a commit
that referenced
this pull request
Mar 17, 2025
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the existing implementation of DISABLED_COUNTRIES, which previously controlled country visibility in the Legacy registration form and restrict users from switching to disabled countries. Validation errors were implemented separately in Authn MFE and Account MFE due to their different country listing mechanisms. The new approach moves the disabled countries logic from environment settings to a database-driven model within the Embargo Django App. As part of this refactor, the DISABLED_COUNTRIES setting will be deprecated, and all related functionality will be transitioned to the new model-based system.
Related links
Internal 2U Ticket: https://2u-internal.atlassian.net/browse/INF-1760
Testing instructions