fix: add target='_blank' for videos hosted outside edx #36361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
leoaulasneo98
pushed a commit
to aulasneo/edx-platform
that referenced
this pull request
Mar 25, 2025
leoaulasneo98
pushed a commit
to aulasneo/edx-platform
that referenced
this pull request
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When an author or learner clicks the "Download Video" button in the Video XBlock, the resulting behavior is inconsistent. Some videos download directly, while others remain in the same tab, and some redirect the user to a new page within the same tab.
Currently, when users click on a video file hosted outside of the edX platform, it opens in the same tab, disrupting the user experience. To improve consistency and usability, we propose modifying the behavior so that clicking the "Download Video" button always opens the video in a new tab, regardless of the hosting origin.
Useful information to include:
Supporting information
Testing instructions
Please provide detailed step-by-step instructions for testing this change.
Deadline
"None" if there's no rush, or provide a specific date or event (and reason) if there is one.
before
Screen.Recording.2025-03-11.at.8.10.44.PM.mov
after
Screen.Recording.2025-03-11.at.8.12.00.PM.mov