Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: remove eslint with frontend code removal ADR #36383

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

style: remove eslint with frontend code removal ADR #36383

wants to merge 2 commits into from
+58 −421

Conversation

robrap
Copy link
Contributor

@robrap robrap commented Mar 14, 2025

Description

  • Add ADR for frontend code removal
  • Drop eslint, as explained in the ADR

Supporting information

See new ADR for details.

Other information

  • package-lock.json has not yet been rebuilt. How is this done properly?
  • eslint related comments have been left in place, and will go away with the javascript files.
  • there may be other clean-up possible, but this is a start.

@robrap
style: remove eslint with frontend code removal ADR
2103a9e 
- Add ADR for frontend code removal
- Drop eslint, as explained in the ADR
@robrap robrap force-pushed the robrap/remove-eslint branch from 32141b8 to 2103a9e Compare March 14, 2025 06:55
@bradenmacdonald
Copy link
Contributor

bradenmacdonald commented Mar 14, 2025 •
edited
Loading

package-lock.json has not yet been rebuilt. How is this done properly?

Delete it and run npm install to re-generate it. This may lead to different versions of indirect dependencies being installed though.

bradenmacdonald
bradenmacdonald approved these changes Mar 14, 2025
View reviewed changes
Copy link
Contributor

@bradenmacdonald bradenmacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me. I haven't tested this branch but I imagine removing lint tooling is low risk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bradenmacdonald bradenmacdonald bradenmacdonald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robrap @bradenmacdonald