fix: move links with status None to forbidden link #36453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Faraz32123
requested review from
schenedx,
saadyousafarbi,
hinakhadim and
mfarhan943
- move external links with status None to external forbidden links - also modified the tests that fails for previous code
Faraz32123
force-pushed
the
fix/move_external_links_with_status_None_to_external_forbidden
branch
from
0603e80 to
bf991c0
Compare
hinakhadim
approved these changes
Mar 27, 2025
|
@hinakhadim there's is 404 category for links, if you see in above image, link actually returns 404. I don't think we should move these kind of links to any other category as they return 404 and keep showing these as broken. |
|
404 are considered as broken links. |
|
yes, other than these we don't have any other errors for external links. |
Faraz32123
deleted the
fix/move_external_links_with_status_None_to_external_forbidden
branch
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: TNL-11930
This link: https://www.geo.arizona.edu/Antevs/ecol438/lect18.html#01 belongs to retries_list and has status None. But in browser this link works fine. So in this commit, moving the external links with status None to external forbidden links category.
Before:
As shown below, this link goes to general broken link category.
After:
Now this link goes to Manual link check category.