-
Notifications
You must be signed in to change notification settings - Fork 37
fix: Convert UUIDField columns to uuid type for MariaDB #321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the pull request, @blarghmatey! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
b48497d to
f655c22
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #321 +/- ##
=======================================
Coverage 95.89% 95.89%
=======================================
Files 23 23
Lines 3022 3022
Branches 121 121
=======================================
Hits 2898 2898
Misses 113 113
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| dependencies = [ | ||
| ('submissions', '0005_submissionfile'), | ||
| ('submissions', '0006_mariadb_uuid_conversion'), | ||
| ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@blarghmatey: Why was this necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first iteration of this PR was erroring on a migrations check because of parallel histories.
Converts UUIDField columns from char(32) to uuid type for MariaDB Django 5 compatibility. This migration converts the following columns: - submissions_submission.uuid - submissions_studentitem.uuid - submissions_score.uuid See: https://docs.djangoproject.com/en/5.2/releases/5.0/#migrating-uuidfield
f655c22 to
c37ca40
Compare
Description
The behavior of the MariaDB backend has changed for UUIDField from a
CharField(32)to an actualuuidtype in Django 5. This migration converts affected columns to prevent data insertion errors.This migration converts the following columns:
submissions_submission.uuidsubmissions_studentitem.uuidsubmissions_score.uuidSupporting information
https://docs.djangoproject.com/en/5.2/releases/5.0/#migrating-uuidfield
Related PRs