Skip to content

Conversation

@blarghmatey
Copy link
Contributor

Description

The behavior of the MariaDB backend has changed for UUIDField from a CharField(32) to an actual uuid type in Django 5. This migration converts affected columns to prevent data insertion errors.

This migration converts the following columns:

  • submissions_submission.uuid
  • submissions_studentitem.uuid
  • submissions_score.uuid

Supporting information

https://docs.djangoproject.com/en/5.2/releases/5.0/#migrating-uuidfield

Related PRs

@openedx-webhooks
Copy link

Thanks for the pull request, @blarghmatey!

This repository is currently maintained by @openedx/committers-edx-submissions.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.89%. Comparing base (81cc930) to head (c37ca40).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #321   +/-   ##
=======================================
  Coverage   95.89%   95.89%           
=======================================
  Files          23       23           
  Lines        3022     3022           
  Branches      121      121           
=======================================
  Hits         2898     2898           
  Misses        113      113           
  Partials       11       11           
Flag Coverage Δ
unittests 95.89% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment on lines +8 to +11
dependencies = [
('submissions', '0005_submissionfile'),
('submissions', '0006_mariadb_uuid_conversion'),
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blarghmatey: Why was this necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first iteration of this PR was erroring on a migrations check because of parallel histories.

Converts UUIDField columns from char(32) to uuid type for MariaDB Django 5 compatibility.

This migration converts the following columns:
- submissions_submission.uuid
- submissions_studentitem.uuid
- submissions_score.uuid

See: https://docs.djangoproject.com/en/5.2/releases/5.0/#migrating-uuidfield
@blarghmatey blarghmatey force-pushed the mariadb_uuid_field_conversion branch from f655c22 to c37ca40 Compare October 21, 2025 14:15
@ormsbee ormsbee moved this from Needs Triage to Waiting on Author in Contributions Oct 21, 2025
@ormsbee ormsbee merged commit d9cc3b6 into openedx:master Oct 23, 2025
19 checks passed
@github-project-automation github-project-automation bot moved this from Waiting on Author to Done in Contributions Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants