-
Notifications
You must be signed in to change notification settings - Fork 271
build: Upgrade to Node 24 #1753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
build: Upgrade to Node 24 #1753
Conversation
Thanks for the pull request, @PKulkoRaccoonGang! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Update the status of your PRYour PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
cabf862
to
c8647b3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1753 +/- ##
==========================================
- Coverage 90.46% 90.45% -0.02%
==========================================
Files 344 344
Lines 5812 5812
Branches 1360 1403 +43
==========================================
- Hits 5258 5257 -1
+ Misses 537 536 -1
- Partials 17 19 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@@ -22,22 +22,4 @@ const config = createConfig('jest', { | |||
testEnvironment: 'jsdom', | |||
}); | |||
|
|||
// delete config.testURL; | |||
|
|||
config.reporters = [...(config.reporters || []), ["jest-console-group-reporter", { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing the configuration for jest-console-group-reporter caused this error
TypeError: Cannot read properties of undefined (reading 'isSet')
at SummaryReporter._getTestSummary (/Users/peterkulko/dev/tutor_workspaces/tutor-oex-main/src/frontend-app-learning/node_modules/@jest/reporters/build/index.js:1560:33)
at SummaryReporter.onRunComplete (/Users/peterkulko/dev/tutor_workspaces/tutor-oex-main/src/frontend-app-learning/node_modules/@jest/reporters/build/index.js:1506:104)
at JestConsoleGroupReporter.onRunComplete (/Users/peterkulko/dev/tutor_workspaces/tutor-oex-main/src/frontend-app-learning/node_modules/jest-console-group-reporter/dist/index.js:476:30)
at ReporterDispatcher.onRunComplete (/Users/peterkulko/dev/tutor_workspaces/tutor-oex-main/src/frontend-app-learning/node_modules/@jest/core/build/ReporterDispatcher.js:71:24)
at TestScheduler.scheduleTests (/Users/peterkulko/dev/tutor_workspaces/tutor-oex-main/src/frontend-app-learning/node_modules/@jest/core/build/TestScheduler.js:306:28)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async runJest (/Users/peterkulko/dev/tutor_workspaces/tutor-oex-main/src/frontend-app-learning/node_modules/@jest/core/build/runJest.js:367:19)
at async _run10000 (/Users/peterkulko/dev/tutor_workspaces/tutor-oex-main/src/frontend-app-learning/node_modules/@jest/core/build/cli/index.js:343:7)
at async runCLI (/Users/peterkulko/dev/tutor_workspaces/tutor-oex-main/src/frontend-app-learning/node_modules/@jest/core/build/cli/index.js:198:3)
at async Object.run (/Users/peterkulko/dev/tutor_workspaces/tutor-oex-main/src/frontend-app-learning/node_modules/jest-cli/build/run.js:130:37)
I searched the OeX repositories where jest-console-group-reporter
is still used and it turned out that this is the only repository where logging is improved due to this package.
I suggest getting rid of this.
Note
Awaiting a merge:
Description
As a second step in the Node 24 upgrade process, upgrade
.nvmrc
and regeneratepackage-lock.json
from scratch using Node 24. Also make the Node 24 test a blocking one.See #1735 for futher information.