Skip to content

Commit 8ef3a27

Browse files
regisbarbrandes
authored andcommitted
chore: remove husky 🪓🐶
We remove husky, which is triggering pre-push git hooks, including running "npm lint". This is causing failures when building Docker images, because "npm clean-install --omit=dev" automatically triggers "npm prepare", which attemps to run "husky". But husky is not listed in the build dependencies, only in devDependencies. As a consequence, package installation is failing with the following error: 14.13 > @edx/[email protected] prepare 14.13 > husky install 14.13 14.15 sh: 1: husky: not found Similar to: openedx/frontend-app-learning#1622
1 parent e084199 commit 8ef3a27

File tree

2 files changed

+0
-23
lines changed

2 files changed

+0
-23
lines changed

package-lock.json

-17
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

-6
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,6 @@
1717
"files": [
1818
"/dist"
1919
],
20-
"husky": {
21-
"hooks": {
22-
"pre-commit": "npm run lint"
23-
}
24-
},
2520
"repository": {
2621
"type": "git",
2722
"url": "git+https://github.com/openedx/frontend-component-header.git"
@@ -42,7 +37,6 @@
4237
"@testing-library/dom": "^10.4.0",
4338
"@testing-library/jest-dom": "5.17.0",
4439
"@testing-library/react": "^16.2.0",
45-
"husky": "8.0.3",
4640
"jest": "29.7.0",
4741
"jest-chain": "1.1.6",
4842
"prop-types": "15.8.1",

0 commit comments

Comments
 (0)