Cannot compile using STM32duino core

[TeguhTeknisi]

Hi,
Thanks for EmonLib,
Why i cannot compile it, when I use the code example and using STM32 branch of Emonlib

My Setup:
Kubuntu OS
Arduino 1.8.19 and STM32duino v2.3.0 ( https://github.com/stm32duino/Arduino_Core_STM32/releases/tag/2.3.0 )
STM32 BluePill F103C6 (32K)

I use STM32F103C6T6 board and for the Sensor, i'am using ZMPT101B Transformer and Acs712 30A
Using this recommendation https://community.openenergymonitor.org/t/power-power-factor-reading-issue-while-using-acs712-zmpt101b-module/16333/8

I use the code from here https://github.com/openenergymonitor/STM32/blob/master/docs/STM32Duino/EmonLib.md

// EmonLibrary examples openenergymonitor.org, Licence GNU GPL V3
#include "EmonLib.h"             // Include Emon Library
EnergyMonitor emon1;             // Create an instance

void setup()
{  
  Serial.begin(9600);
  
  emon1.voltage(PA_0, 268.97, 1.7);  // Voltage: input pin, calibration, phase_shift
  emon1.current(PA_1, 60.606);       // Current: input pin, calibration.
}

void loop()
{
  emon1.calcVI(20,2000);         // Calculate all. No.of half wavelengths (crossings), time-out
  emon1.serialprint();           // Print out all variables (realpower, apparent power, Vrms, Irms, power factor)
  
  float realPower       = emon1.realPower;        //extract Real Power into variable
  float apparentPower   = emon1.apparentPower;    //extract Apparent Power into variable
  float powerFActor     = emon1.powerFactor;      //extract Power Factor into Variable
  float supplyVoltage   = emon1.Vrms;             //extract Vrms into Variable
  float Irms            = emon1.Irms;             //extract Irms into Variable
}

Using EmonLib from github

teguh@Teguh-X201EV:~/STM32F103$ git clone https://github.com/openenergymonitor/EmonLib.git
Cloning into 'EmonLib'...
remote: Enumerating objects: 182, done.
remote: Total 182 (delta 0), reused 0 (delta 0), pack-reused 182
Receiving objects: 100% (182/182), 47.49 KiB | 1013.00 KiB/s, done.
Resolving deltas: 100% (66/66), done.
teguh@Teguh-X201EV:~/STM32F103$ cd EmonLib
teguh@Teguh-X201EV:~/STM32F103/EmonLib$ git checkout STM32
Branch 'STM32' set up to track remote branch 'STM32' from 'origin'.
Switched to a new branch 'STM32'
teguh@Teguh-X201EV:~/STM32F103/EmonLib$

Here the error:

/opt/arduino-1.8.19/portable/sketchbook/libraries/EmonLib/EmonLib.cpp: In member function 'void EnergyMonitor::calcVI(unsigned int, unsigned int)':
/opt/arduino-1.8.19/portable/sketchbook/libraries/EmonLib/EmonLib.cpp:62:35: error: too few arguments to function 'uint16_t adc_read_value(PinName, uint32_t)'
   62 |     startV = adc_read_value(inPinV);                    //using the voltage waveform
      |                                   ^
In file included from /opt/arduino-1.8.19/portable/packages/STMicroelectronics/hardware/stm32/2.3.0/cores/arduino/board.h:8,
                 from /opt/arduino-1.8.19/portable/packages/STMicroelectronics/hardware/stm32/2.3.0/cores/arduino/wiring.h:40,
                 from /opt/arduino-1.8.19/portable/packages/STMicroelectronics/hardware/stm32/2.3.0/cores/arduino/Arduino.h:36,
                 from /opt/arduino-1.8.19/portable/sketchbook/libraries/EmonLib/EmonLib.h:15,
                 from /opt/arduino-1.8.19/portable/sketchbook/libraries/EmonLib/EmonLib.cpp:13:
/opt/arduino-1.8.19/portable/packages/STMicroelectronics/hardware/stm32/2.3.0/cores/arduino/stm32/analog.h:55:10: note: declared here
   55 | uint16_t adc_read_value(PinName pin, uint32_t resolution);
      |          ^~~~~~~~~~~~~~
/opt/arduino-1.8.19/portable/sketchbook/libraries/EmonLib/EmonLib.cpp:80:36: error: too few arguments to function 'uint16_t adc_read_value(PinName, uint32_t)'
   80 |     sampleV = adc_read_value(inPinV);                 //Read in raw voltage signal
      |                                    ^
In file included from /opt/arduino-1.8.19/portable/packages/STMicroelectronics/hardware/stm32/2.3.0/cores/arduino/board.h:8,
                 from /opt/arduino-1.8.19/portable/packages/STMicroelectronics/hardware/stm32/2.3.0/cores/arduino/wiring.h:40,
                 from /opt/arduino-1.8.19/portable/packages/STMicroelectronics/hardware/stm32/2.3.0/cores/arduino/Arduino.h:36,
                 from /opt/arduino-1.8.19/portable/sketchbook/libraries/EmonLib/EmonLib.h:15,
                 from /opt/arduino-1.8.19/portable/sketchbook/libraries/EmonLib/EmonLib.cpp:13:
/opt/arduino-1.8.19/portable/packages/STMicroelectronics/hardware/stm32/2.3.0/cores/arduino/stm32/analog.h:55:10: note: declared here
   55 | uint16_t adc_read_value(PinName pin, uint32_t resolution);
      |          ^~~~~~~~~~~~~~
/opt/arduino-1.8.19/portable/sketchbook/libraries/EmonLib/EmonLib.cpp:81:36: error: too few arguments to function 'uint16_t adc_read_value(PinName, uint32_t)'
   81 |     sampleI = adc_read_value(inPinI);                 //Read in raw current signal
      |                                    ^
In file included from /opt/arduino-1.8.19/portable/packages/STMicroelectronics/hardware/stm32/2.3.0/cores/arduino/board.h:8,
                 from /opt/arduino-1.8.19/portable/packages/STMicroelectronics/hardware/stm32/2.3.0/cores/arduino/wiring.h:40,
                 from /opt/arduino-1.8.19/portable/packages/STMicroelectronics/hardware/stm32/2.3.0/cores/arduino/Arduino.h:36,                                                         
                 from /opt/arduino-1.8.19/portable/sketchbook/libraries/EmonLib/EmonLib.h:15,                                                                                           
                 from /opt/arduino-1.8.19/portable/sketchbook/libraries/EmonLib/EmonLib.cpp:13:
/opt/arduino-1.8.19/portable/packages/STMicroelectronics/hardware/stm32/2.3.0/cores/arduino/stm32/analog.h:55:10: note: declared here
   55 | uint16_t adc_read_value(PinName pin, uint32_t resolution);
      |          ^~~~~~~~~~~~~~
/opt/arduino-1.8.19/portable/sketchbook/libraries/EmonLib/EmonLib.cpp: In member function 'double EnergyMonitor::calcIrms(unsigned int)':
/opt/arduino-1.8.19/portable/sketchbook/libraries/EmonLib/EmonLib.cpp:167:36: error: too few arguments to function 'uint16_t adc_read_value(PinName, uint32_t)'
  167 |     sampleI = adc_read_value(inPinI);
      |                                    ^
In file included from /opt/arduino-1.8.19/portable/packages/STMicroelectronics/hardware/stm32/2.3.0/cores/arduino/board.h:8,
                 from /opt/arduino-1.8.19/portable/packages/STMicroelectronics/hardware/stm32/2.3.0/cores/arduino/wiring.h:40,
                 from /opt/arduino-1.8.19/portable/packages/STMicroelectronics/hardware/stm32/2.3.0/cores/arduino/Arduino.h:36,
                 from /opt/arduino-1.8.19/portable/sketchbook/libraries/EmonLib/EmonLib.h:15,
                 from /opt/arduino-1.8.19/portable/sketchbook/libraries/EmonLib/EmonLib.cpp:13:
/opt/arduino-1.8.19/portable/packages/STMicroelectronics/hardware/stm32/2.3.0/cores/arduino/stm32/analog.h:55:10: note: declared here
   55 | uint16_t adc_read_value(PinName pin, uint32_t resolution);
      |          ^~~~~~~~~~~~~~
exit status 1
Error compiling for board Generic STM32F1 series.

Best regrads,
Teguh

[fpistm]

Looking quickly to this issue, your code seems wrong: PA_0 is type of PinName while Arduino deal with pin number. So you have to use PA0 which represent the pin number. Same for PA_1 which sould be PA1

Edit: PinName well required.

[TeguhTeknisi]

Looking quickly to this issue, your code seems wrong: PA_0 is type of PinName while Arduino deal with pin number. So you have to use PA0 which represent the pin number. Same for PA_1 which sould be PA1

-  emon1.voltage(PA_0, 268.97, 1.7);  // Voltage: input pin, calibration, phase_shift
-  emon1.current(PA_1, 60.606);       // Current: input pin, calibration.
+  emon1.voltage(PA0, 268.97, 1.7);  // Voltage: input pin, calibration, phase_shift
+  emon1.current(PA1, 60.606);       // Current: input pin, calibration.

Thanks @fpistm

i use the code from here https://github.com/openenergymonitor/STM32/blob/master/docs/STM32Duino/EmonLib.md
In the screenshot in there, they use PA_0 and PA_1

When i use PA0 and PA1, i got the same error.

Lookslike, there something wrong in the emonlib code for stm32, its old library, perhaps the use the old stm32duino core to make emonlib stm32 port.

[fpistm]

OK. My bad. I never use it. Using PY_n naming is not Arduinoish while PYn is.

[fpistm]

Looking at the code it is well PinName which should be used.
Trying to read tour error (not easy as not properly formatted) it seems it uses PA0???? Are you sure you build against the correct library with STM32 branch?

[TeguhTeknisi]

Looking at the code it is well PinName which should be used. Trying to read tour error (not easy as not properly formatted) it seems it uses PA0???? Are you sure you build against the correct library with STM32 branch?

Thanks @fpistm
OMG.. i am sorry, that the error log when i use PA0 and PA1, i have update the first post.
I am sory, i don't know the proper format for the error log, i just copy and paste from konsole the error log

this the error log using PA_0 and PA_1

/opt/arduino-1.8.19/portable/sketchbook/libraries/EmonLib/EmonLib.cpp: In member function 'void EnergyMonitor::calcVI(unsigned int, unsigned int)':
/opt/arduino-1.8.19/portable/sketchbook/libraries/EmonLib/EmonLib.cpp:62:35: error: too few arguments to function 'uint16_t adc_read_value(PinName, uint32_t)'
   62 |     startV = adc_read_value(inPinV);                    //using the voltage waveform
      |                                   ^
In file included from /opt/arduino-1.8.19/portable/packages/STMicroelectronics/hardware/stm32/2.3.0/cores/arduino/board.h:8,
                 from /opt/arduino-1.8.19/portable/packages/STMicroelectronics/hardware/stm32/2.3.0/cores/arduino/wiring.h:40,
                 from /opt/arduino-1.8.19/portable/packages/STMicroelectronics/hardware/stm32/2.3.0/cores/arduino/Arduino.h:36,
                 from /opt/arduino-1.8.19/portable/sketchbook/libraries/EmonLib/EmonLib.h:15,
                 from /opt/arduino-1.8.19/portable/sketchbook/libraries/EmonLib/EmonLib.cpp:13:
/opt/arduino-1.8.19/portable/packages/STMicroelectronics/hardware/stm32/2.3.0/cores/arduino/stm32/analog.h:55:10: note: declared here
   55 | uint16_t adc_read_value(PinName pin, uint32_t resolution);
      |          ^~~~~~~~~~~~~~
/opt/arduino-1.8.19/portable/sketchbook/libraries/EmonLib/EmonLib.cpp:80:36: error: too few arguments to function 'uint16_t adc_read_value(PinName, uint32_t)'
   80 |     sampleV = adc_read_value(inPinV);                 //Read in raw voltage signal
      |                                    ^
In file included from /opt/arduino-1.8.19/portable/packages/STMicroelectronics/hardware/stm32/2.3.0/cores/arduino/board.h:8,
                 from /opt/arduino-1.8.19/portable/packages/STMicroelectronics/hardware/stm32/2.3.0/cores/arduino/wiring.h:40,
                 from /opt/arduino-1.8.19/portable/packages/STMicroelectronics/hardware/stm32/2.3.0/cores/arduino/Arduino.h:36,
                 from /opt/arduino-1.8.19/portable/sketchbook/libraries/EmonLib/EmonLib.h:15,
                 from /opt/arduino-1.8.19/portable/sketchbook/libraries/EmonLib/EmonLib.cpp:13:
/opt/arduino-1.8.19/portable/packages/STMicroelectronics/hardware/stm32/2.3.0/cores/arduino/stm32/analog.h:55:10: note: declared here
   55 | uint16_t adc_read_value(PinName pin, uint32_t resolution);
      |          ^~~~~~~~~~~~~~
/opt/arduino-1.8.19/portable/sketchbook/libraries/EmonLib/EmonLib.cpp:81:36: error: too few arguments to function 'uint16_t adc_read_value(PinName, uint32_t)'
   81 |     sampleI = adc_read_value(inPinI);                 //Read in raw current signal
      |                                    ^
In file included from /opt/arduino-1.8.19/portable/packages/STMicroelectronics/hardware/stm32/2.3.0/cores/arduino/board.h:8,
                 from /opt/arduino-1.8.19/portable/packages/STMicroelectronics/hardware/stm32/2.3.0/cores/arduino/wiring.h:40,
                 from /opt/arduino-1.8.19/portable/packages/STMicroelectronics/hardware/stm32/2.3.0/cores/arduino/Arduino.h:36,                                                         
                 from /opt/arduino-1.8.19/portable/sketchbook/libraries/EmonLib/EmonLib.h:15,                                                                                           
                 from /opt/arduino-1.8.19/portable/sketchbook/libraries/EmonLib/EmonLib.cpp:13:
/opt/arduino-1.8.19/portable/packages/STMicroelectronics/hardware/stm32/2.3.0/cores/arduino/stm32/analog.h:55:10: note: declared here
   55 | uint16_t adc_read_value(PinName pin, uint32_t resolution);
      |          ^~~~~~~~~~~~~~
/opt/arduino-1.8.19/portable/sketchbook/libraries/EmonLib/EmonLib.cpp: In member function 'double EnergyMonitor::calcIrms(unsigned int)':
/opt/arduino-1.8.19/portable/sketchbook/libraries/EmonLib/EmonLib.cpp:167:36: error: too few arguments to function 'uint16_t adc_read_value(PinName, uint32_t)'
  167 |     sampleI = adc_read_value(inPinI);
      |                                    ^
In file included from /opt/arduino-1.8.19/portable/packages/STMicroelectronics/hardware/stm32/2.3.0/cores/arduino/board.h:8,
                 from /opt/arduino-1.8.19/portable/packages/STMicroelectronics/hardware/stm32/2.3.0/cores/arduino/wiring.h:40,
                 from /opt/arduino-1.8.19/portable/packages/STMicroelectronics/hardware/stm32/2.3.0/cores/arduino/Arduino.h:36,
                 from /opt/arduino-1.8.19/portable/sketchbook/libraries/EmonLib/EmonLib.h:15,
                 from /opt/arduino-1.8.19/portable/sketchbook/libraries/EmonLib/EmonLib.cpp:13:
/opt/arduino-1.8.19/portable/packages/STMicroelectronics/hardware/stm32/2.3.0/cores/arduino/stm32/analog.h:55:10: note: declared here
   55 | uint16_t adc_read_value(PinName pin, uint32_t resolution);
      |          ^~~~~~~~~~~~~~
exit status 1
Error compiling for board Generic STM32F1 series.

and when i use PA0 and PA1, i got this error

In file included from /opt/arduino-1.8.19/portable/packages/STMicroelectronics/hardware/stm32/2.3.0/cores/arduino/pins_arduino.h:25,
                 from /opt/arduino-1.8.19/portable/packages/STMicroelectronics/hardware/stm32/2.3.0/cores/arduino/Arduino.h:56,
                 from sketch/ZMPT101B_ACS712_EmonLib.ino.cpp:1:
/opt/arduino-1.8.19/portable/sketchbook/ZMPT101B_ACS712_EmonLib/ZMPT101B_ACS712_EmonLib.ino: In function 'void setup()':
/opt/arduino-1.8.19/portable/packages/STMicroelectronics/hardware/stm32/2.3.0/cores/arduino/pins_arduino_analog.h:25:29: error: invalid conversion from 'int' to 'PinName' [-fpermissive]
   25 | #define PNUM_ANALOG_BASE    0xC0
      |                             ^~~~
      |                             |
      |                             int
/opt/arduino-1.8.19/portable/packages/STMicroelectronics/hardware/stm32/2.3.0/cores/arduino/pins_arduino_analog.h:60:22: note: in expansion of macro 'PNUM_ANALOG_BASE'
   60 | #define PIN_A0       PNUM_ANALOG_BASE
      |                      ^~~~~~~~~~~~~~~~
/opt/arduino-1.8.19/portable/packages/STMicroelectronics/hardware/stm32/2.3.0/variants/STM32F1xx/F103C4T_F103C6(T-U)/variant_BLUEPILL_F103C6.h:41:33: note: in expansion of macro 'PIN_A0'
   41 | #define PA0                     PIN_A0
      |                                 ^~~~~~
/opt/arduino-1.8.19/portable/sketchbook/ZMPT101B_ACS712_EmonLib/ZMPT101B_ACS712_EmonLib.ino:13:17: note: in expansion of macro 'PA0'
   13 |   emon1.voltage(PA0, 268.97, 1.7);
      |                 ^~~
In file included from /opt/arduino-1.8.19/portable/sketchbook/ZMPT101B_ACS712_EmonLib/ZMPT101B_ACS712_EmonLib.ino:3:
/opt/arduino-1.8.19/portable/sketchbook/libraries/EmonLib/EmonLib.h:49:26: note:   initializing argument 1 of 'void EnergyMonitor::voltage(PinName, double, double)'
   49 |     void voltage(PinName _inPinV, double _VCAL, double _PHASECAL);
      |                  ~~~~~~~~^~~~~~~
In file included from /opt/arduino-1.8.19/portable/packages/STMicroelectronics/hardware/stm32/2.3.0/cores/arduino/pins_arduino.h:25,
                 from /opt/arduino-1.8.19/portable/packages/STMicroelectronics/hardware/stm32/2.3.0/cores/arduino/Arduino.h:56,
                 from sketch/ZMPT101B_ACS712_EmonLib.ino.cpp:1:
/opt/arduino-1.8.19/portable/packages/STMicroelectronics/hardware/stm32/2.3.0/cores/arduino/pins_arduino_analog.h:62:31: error: invalid conversion from 'int' to 'PinName' [-fpermissive]
   62 |   #define PIN_A1      (PIN_A0 + 1)
      |                       ~~~~~~~~^~~~
      |                               |
      |                               int
/opt/arduino-1.8.19/portable/packages/STMicroelectronics/hardware/stm32/2.3.0/variants/STM32F1xx/F103C4T_F103C6(T-U)/variant_BLUEPILL_F103C6.h:42:33: note: in expansion of macro 'PIN_A1'
   42 | #define PA1                     PIN_A1
      |                                 ^~~~~~
/opt/arduino-1.8.19/portable/sketchbook/ZMPT101B_ACS712_EmonLib/ZMPT101B_ACS712_EmonLib.ino:14:17: note: in expansion of macro 'PA1'
   14 |   emon1.current(PA1, 60.606);
      |                 ^~~
In file included from /opt/arduino-1.8.19/portable/sketchbook/ZMPT101B_ACS712_EmonLib/ZMPT101B_ACS712_EmonLib.ino:3:
/opt/arduino-1.8.19/portable/sketchbook/libraries/EmonLib/EmonLib.h:50:26: note:   initializing argument 1 of 'void EnergyMonitor::current(PinName, double)'
   50 |     void current(PinName _inPinI, double _ICAL);
      |                  ~~~~~~~~^~~~~~~
exit status 1
Error compiling for board Generic STM32F1 series.

[TeguhTeknisi]

Looking quickly to this issue, your code seems wrong: PA_0 is type of PinName while Arduino deal with pin number. So you have to use PA0 which represent the pin number. Same for PA_1 which sould be PA1

Edit: PinName well required.

Thanks @fpistm

the difference STM32 branch of emonlib with the atmel emonlib is the PinName
the atmel emonlib.h

    void voltage(unsigned int _inPinV, double _VCAL, double _PHASECAL);
    void current(unsigned int _inPinI, double _ICAL);

    void voltageTX(double _VCAL, double _PHASECAL);
    void currentTX(unsigned int _channel, double _ICAL);

    void calcVI(unsigned int crossings, unsigned int timeout);
    double calcIrms(unsigned int NUMBER_OF_SAMPLES);
    void serialprint();

and the emonlib.h stm32 branch

    void voltage(PinName _inPinV, double _VCAL, double _PHASECAL);
    void current(PinName _inPinI, double _ICAL);

    void calcVI(unsigned int crossings, unsigned int timeout);
    double calcIrms(unsigned int NUMBER_OF_SAMPLES);
    void serialprint();

i don't know why they use it in STM32 branch.

Fyi, the use Atmel chip in the first release of emonlib
then they try to use Stm32 for the next project because it have 12bit and much more adc pin
but, in this year, they drop Stm32 and change to Avr-db chip because its cheaper and stm32 chip shortage ( https://community.openenergymonitor.org/t/avr-db-emontx-v4-new-hardware-in-progress/20209 )

when i use the atmel emonlib, i can compile it.
but i want to take advantage of HAL in stm32 with Emonlib,
so i try to use this branch

lookslike i need to give up....

Thanks again

Best regrads,
Teguh

[fpistm]

OK. So error comes from adc_read_value usage by the lib. Now it requires a second argument. So you have to update the emonlib to give also he resolution.
uint16_t adc_read_value(PinName pin, uint32_t resolution);

Change made 3 years ago:
stm32duino/Arduino_Core_STM32#829

[TeguhTeknisi]

@fpistm
Thanks Frederic,
I will try it, after i'am done with Emon board.
For now, i'am still busy desoldering the old prototype board and soldering to the new prototype board, to make it looks neat and better.

Best regrads,
Teguh

[TeguhTeknisi]

OK. So error comes from adc_read_value usage by the lib. Now it requires a second argument. So you have to update the emonlib to give also he resolution. uint16_t adc_read_value(PinName pin, uint32_t resolution);

Change made 3 years ago: stm32duino/Arduino_Core_STM32#829

Thanks Frederic, i can compile it.

Best Regrads,
Teguh.