Job/jobbase unification test fixtures (#177)

* job: update test fixtures for JobBase's renamed generateResult/innerJobs

* job: guard onMessage against undefined userUuid from JobBase

JobBase.userUuid (and JobSerialized.userUuid) was widened from string
to string | undefined upstream in arena-core as a defensive
null-safety change. Add an early return in JobManager.onMessage() so
tsc can narrow userUuid to a definite string for the rest of the
method, instead of failing to type-check the Map lookup, the
WebSocketServer.notifyUser call, and the workers.delete() call inside
the setTimeout closure.

Fixes TS2345 errors reported against jobManager.ts:22,24,30. A job
update message always carries a userUuid in practice (every job is
created for a specific user), so this is a no-op guard rather than a
change in expected behavior.

* Bump @openforis/arena-core to published v2.1.2

Points at the real published JobBase unification (was verified locally
via yarn link during development; this replaces that local link with
the actual published package now that the arena-core PR has merged).
Re-verified against the published package: tsc clean, full test suite
16/16 suites, 67/67 tests passing.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>

Author: SteRiccio

.yarn/install-state.gz

@@ -46,7 +46,7 @@
   "dependencies": {
     "@aws-sdk/client-s3": "^3.1112.0",
     "@godaddy/terminus": "^4.12.1",
-    "@openforis/arena-core": "^2.1.1",
+    "@openforis/arena-core": "^2.1.2",
     "bcryptjs": "^3.0.3",
     "compression": "^1.8.1",
     "cookie-parser": "^1.4.7",

package.json

@@ -19,6 +19,8 @@ export class JobManager {
 
     const { job } = msg
     const { userUuid, ended } = job
+    if (!userUuid) return
+
     const worker = JobManager.workers.get(userUuid)
 
     WebSocketServer.notifyUser(userUuid, WebSocketEvent.jobUpdate, job)

src/job/jobManager.ts

@@ -18,8 +18,7 @@ export class SimpleJob extends JobServer<SimpleJobContext, number> {
     return Promise.resolve()
   }
 
-  protected async prepareResult(): Promise<number> {
-    await super.prepareResult()
+  protected async generateResult(): Promise<number> {
     return this.context.result ?? 3
   }
 }
@@ -31,8 +30,7 @@ export class SimpleJobWithJobs extends SimpleJob {
     super(data, [new SimpleJob({ ...data, result: 4 }), new SimpleJob({ ...data, result: 2 })])
   }
 
-  protected async prepareResult(): Promise<number> {
-    await super.prepareResult()
-    return this.jobs.reduce<number>((total, job) => total + (job.result ?? 0), 0)
+  protected async generateResult(): Promise<number> {
+    return this.innerJobs.reduce<number>((total, job) => total + (job.result ?? 0), 0)
   }
 }

src/job/tests/testJobs.ts

@@ -1217,9 +1217,9 @@ __metadata:
   languageName: node
   linkType: hard
 
-"@openforis/arena-core@npm:^2.1.1":
-  version: 2.1.1
-  resolution: "@openforis/arena-core@npm:2.1.1::__archiveUrl=https%3A%2F%2Fnpm.pkg.github.com%2Fdownload%2F%40openforis%2Farena-core%2F2.1.1%2F299f3875319599f29e4d843261684beb48dbd742"
+"@openforis/arena-core@npm:^2.1.2":
+  version: 2.1.2
+  resolution: "@openforis/arena-core@npm:2.1.2::__archiveUrl=https%3A%2F%2Fnpm.pkg.github.com%2Fdownload%2F%40openforis%2Farena-core%2F2.1.2%2F15b52b1957c9acf1e050177ace9f617841e3eebe"
   dependencies:
     "@jsep-plugin/regex": "npm:^1.0.4"
     "@turf/bearing": "npm:^7.3.5"
@@ -1235,7 +1235,7 @@ __metadata:
     moment: "npm:^2.30.1"
     proj4: "npm:^2.20.9"
     uuid: "npm:^14.0.1"
-  checksum: 10c0/cf1425c772e2abb27dd32b3c62dc8edee625b518144d6952e9197f0d781dac80cfde6a3de2c31f5451afc878a8a6d0e4b82173fc16da3020363fd60a73561cc0
+  checksum: 10c0/8fc2ddac5cf6bb07f483d743dadf3b2f3c845218a7b8ad98b4ed65183f93acc95ed6a921de28746b7e17a5350df3a9cb6739258433d28eba6af8aca78fc14bf4
   languageName: node
   linkType: hard
 
@@ -1247,7 +1247,7 @@ __metadata:
     "@eslint/js": "npm:^10.0.1"
     "@godaddy/terminus": "npm:^4.12.1"
     "@machinomy/types-node-db-migrate": "npm:^0.0.2"
-    "@openforis/arena-core": "npm:^2.1.1"
+    "@openforis/arena-core": "npm:^2.1.2"
     "@types/bcryptjs": "npm:^3.0.0"
     "@types/compression": "npm:^1.8.1"
     "@types/cookie-parser": "npm:^1.4.10"