Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested cached/uncached chunks not properly working anymore #8

Open
exside opened this issue Oct 25, 2016 · 0 comments
Open

Nested cached/uncached chunks not properly working anymore #8

exside opened this issue Oct 25, 2016 · 0 comments

Comments

@exside
Copy link

exside commented Oct 25, 2016

I have a site that I recently updated from an old 2.2.x version to 2.5.1, the problem I face now is that chunks called via getCache do not work as expected anymore. By that I mean that an uncached snippet call again to getCache (or other uncached elements, doesn't matter) at the deepest level is processed and "hardcoded" into the output/result instead of staying in the cached output as a modx tag.

The structure is roughly as follows: Template with [[!getCache? <calling a chunk>]] > inside that chunk there are other cached chunks in a wrapper structure, e.g. <div>[[$somechunk]]</div><div>[[$anotherchunk]]</div> inside [[$somechunk]] there is another call [[!getCache? <calling a snippet>]], that last call was there as a modx tag in 2.2.x, I have proof of that, can send the exact cachefiles for both 2.2.x and 2.5.x. but in 2.5.x this tag is no longer there but it's the html output from that snippet call which is therefore cached in the main output of the initial getCache snippet call...resulting in stale HTML instead of fresh one (on each request).

I have no clue where that is coming from, maybe yoleg/revolution@eaa4ff7#diff-351a00a3f45f439700971494783acde4 ? I tried that systemsetting parser_recurse_uncacheable setting it from Yes to No and back, but no change...

any idea if this is something with getCache or a problem with the parser or the structure?

I use getCache in this instance because I can specify a specific cache partition to cache that chunk in and allow custom clearing of that cache partition via manager.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant