Skip to content

[MainUI] Missing plausibility check at „Add Items from Thing“ allows unpermissible circular group reference (recursion) #4276

Description

@FranzSchi

The problem

In the Add item for Thing dialog the Parent and the Equipment can be maintened the same this immediately creates a recursion.
Image

Expected behavior

Please check if they are identlical and do not allow to safe
Or even don’t allow that the Parent is below the Equipment

Steps to reproduce

Open a thing
Navigate to the Channels tab
then press „Add Equipment to Model“ at the bottom
In the new Dialog select for both Equipment and Parent Group the same value

Your environment

OH 5.2 M5
Debutant BookWork as host
Running in Docker 
X64

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingmain uiMain UI

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions