-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misunderstanding of what AuthorizedNamespaces is #462
Comments
I agree the paragraph needs correcting. However we should not restrict the response to IssuerSigned. DeviceSigned should be allowed as well. |
So, yeah, I mean, I don't disagree. But I don't think we can say anything about the encoding of the data... because the whole point of Here are three examples:
At least this is the spirit of device-signed and examples often used in ISO. So IOW, it's hard to specify what format the data used - if any - should be transmitted by the issuer. There's just nothing we can say about it. I do think we should allow implementations to put other things in |
@davidz25 could you please do a small quick PR removing |
This change removes the reference to AuthorizedNamespaces of the MobileSecurityObject since this doesn't apply to issuer-signed data. Fixes Issue openid#462. Signed-off-by: David Zeuthen <[email protected]>
Section A.2.4. Credential Response says the following
According to 18013-5
AuthorizedNamespaces
is a mechanism for the issuer to convey thatDeviceKey
is authorized to sign data elements in that name space and to be returned in DeviceSigned. So it doesn't make any sense to say "This structure SHOULD contain all Namespaces and IssuerSignedItems that are included in the AuthorizedNamespaces of the MobileSecurityObject.". (Also, if you look at MSOs being minted today across e.g. US mDL issuers, no-one is actually using DeviceSigned at all to return data elements, as far as I know.)I also don't think it make sense to specify what the structure SHOULD contain, I mean, it's already completely specified by 18013-5 what it contains. I would just strike the entire last sentence in the quoted paragraph.
The text was updated successfully, but these errors were encountered: