Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify unsupported transaction_data error #454

Open
andprian opened this issue Mar 13, 2025 · 2 comments
Open

Clarify unsupported transaction_data error #454

andprian opened this issue Mar 13, 2025 · 2 comments
Labels
question Further information is requested ready-for-PR transaction data
Milestone

Comments

@andprian
Copy link

Clause 8.4. Transaction Data states: "If the wallet does not support transaction_data parameter, it MUST return an error."

Clarify what is the error that needs to be returned when transaction_data is not supported.

@babisRoutis
Copy link

To my understanding, there is not a dedicated error to express that the wallet doesn't support the transaction_data feature.

The invalid_transaction_data is the closest match, since it can be used in case transaction_data

contains an unknown or unsupported transaction data type value,

@Sakurann Sakurann added question Further information is requested pending-close and removed pending-close labels Mar 20, 2025
@Sakurann
Copy link
Collaborator

yes, we can clarify that invalid_transaction_data error must be returned.

To my understanding, there is not a dedicated error to express that the wallet doesn't support the transaction_data feature.

Yes, this is because we do not want the wallet to return credentials when the verifier is sending transaction_data. so all wallets need to check if transaction_data parameter is in the request and return an error if they do not support it. we might need to clarify this in the definition of invalid_transaction_data error

The Wallet MUST ignore any unrecognized parameters, other than the transaction_data parameter. One exception to this rule is transaction_data parameter, and the wallets that do not support this parameter MUST reject requests that contain it.

@Sakurann Sakurann added this to the 1.1 milestone Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested ready-for-PR transaction data
Projects
None yet
Development

No branches or pull requests

3 participants