Skip to content

Commit b1d33cc

Browse files
fix: MCP link in breadcrumb (#206)
Co-authored-by: Łukasz Goral <[email protected]>
1 parent e82bf90 commit b1d33cc

File tree

6 files changed

+5
-17
lines changed

6 files changed

+5
-17
lines changed

src/AppRouter.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ function AppRouter() {
1616
<Route path="projects" element={<ProjectListView />} />
1717
<Route path="projects/:projectName" element={<ProjectPage />} />
1818
<Route
19-
path="projects/:projectName/workspaces/:workspaceName/mcps/:controlPlaneName/context/:contextName"
19+
path="projects/:projectName/workspaces/:workspaceName/mcps/:controlPlaneName"
2020
element={<McpPage />}
2121
/>
2222
</Route>

src/components/ControlPlanes/ConnectButton.tsx

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import yaml from 'js-yaml';
77
import { useRef, useState } from 'react';
88
import { DownloadKubeconfig } from './CopyKubeconfigButton.tsx';
99
import { useApiResource } from '../../lib/api/useApiResource.ts';
10-
import { extractWorkspaceNameFromNamespace } from '../../utils/index.ts';
10+
import { extractWorkspaceNameFromNamespace } from '../../utils';
1111
import { useTranslation } from 'react-i18next';
1212

1313
interface Props {
@@ -45,10 +45,6 @@ export default function ConnectButton(props: Props) {
4545

4646
// eslint-disable-next-line @typescript-eslint/no-explicit-any
4747
const contexts = kubeconfig.contexts as any[];
48-
const currentContext = kubeconfig['current-context'];
49-
if (!currentContext) {
50-
return <></>;
51-
}
5248

5349
if (contexts.length === 1) {
5450
return (
@@ -57,9 +53,7 @@ export default function ConnectButton(props: Props) {
5753
disabled={props.disabled}
5854
onClick={() =>
5955
navigate(
60-
`/mcp/projects/${props.projectName}/workspaces/${extractWorkspaceNameFromNamespace(
61-
props.workspaceName,
62-
)}/mcps/${props.controlPlaneName}/context/${currentContext}`,
56+
`/mcp/projects/${props.projectName}/workspaces/${extractWorkspaceNameFromNamespace(props.workspaceName)}/mcps/${props.controlPlaneName}`,
6357
)
6458
}
6559
>

src/lib/api/fetch.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ const useCrateClusterHeader = 'X-use-crate';
77
const projectNameHeader = 'X-project';
88
const workspaceNameHeader = 'X-workspace';
99
const mcpNameHeader = 'X-mcp';
10-
const contextHeader = 'X-context';
1110
const jqHeader = 'X-jq';
1211
const contentTypeHeader = 'Content-Type';
1312

@@ -37,7 +36,6 @@ export const fetchApiServer = async (
3736
headers[projectNameHeader] = config.mcpConfig.projectName;
3837
headers[workspaceNameHeader] = config.mcpConfig.workspaceName;
3938
headers[mcpNameHeader] = config.mcpConfig.controlPlaneName;
40-
headers[contextHeader] = config.mcpConfig.contextName;
4139
} else {
4240
headers[useCrateClusterHeader] = 'true';
4341
}

src/lib/api/types/apiConfig.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ type McpConfig = {
22
projectName: string;
33
workspaceName: string;
44
controlPlaneName: string;
5-
contextName: string;
65
};
76

87
//syntax basically combines all the atrributes from the types into one

src/lib/shared/McpContext.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ interface Mcp {
1010
project: string;
1111
workspace: string;
1212
name: string;
13-
context: string;
1413

1514
secretNamespace?: string;
1615
secretName?: string;
@@ -56,7 +55,6 @@ function RequireDownstreamLogin(props: { children?: ReactNode }) {
5655
<ApiConfigProvider
5756
apiConfig={{
5857
mcpConfig: {
59-
contextName: mcp.context,
6058
projectName: mcp.project,
6159
workspaceName: mcp.workspace,
6260
controlPlaneName: mcp.name,

src/spaces/mcp/pages/McpPage.tsx

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ import { isNotFoundError } from '../../../lib/api/error.ts';
2626
import { NotFoundBanner } from '../../../components/Ui/NotFoundBanner/NotFoundBanner.tsx';
2727

2828
export default function McpPage() {
29-
const { projectName, workspaceName, controlPlaneName, contextName } = useParams();
29+
const { projectName, workspaceName, controlPlaneName } = useParams();
3030
const { t } = useTranslation();
3131

3232
const {
@@ -39,7 +39,7 @@ export default function McpPage() {
3939
return <BusyIndicator active />;
4040
}
4141

42-
if (!projectName || !workspaceName || !controlPlaneName || !contextName || isNotFoundError(error)) {
42+
if (!projectName || !workspaceName || !controlPlaneName || isNotFoundError(error)) {
4343
return <NotFoundBanner entityType={t('Entities.ManagedControlPlane')} />;
4444
}
4545

@@ -53,7 +53,6 @@ export default function McpPage() {
5353
project: projectName,
5454
workspace: workspaceName,
5555
name: controlPlaneName,
56-
context: contextName,
5756
}}
5857
>
5958
<AuthProviderMcp>

0 commit comments

Comments
 (0)