From 5e8b3fd1880f92ac7dce30b14f83759fd2559763 Mon Sep 17 00:00:00 2001 From: Aadvik Date: Mon, 9 Feb 2026 02:03:58 +0530 Subject: [PATCH 1/6] Use SLF4J logging for exception handling in WebComponentRegistrar --- .../java/org/openmrs/web/WebComponentRegistrar.java | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/omod/src/main/java/org/openmrs/web/WebComponentRegistrar.java b/omod/src/main/java/org/openmrs/web/WebComponentRegistrar.java index 595f9335b..65166d83e 100644 --- a/omod/src/main/java/org/openmrs/web/WebComponentRegistrar.java +++ b/omod/src/main/java/org/openmrs/web/WebComponentRegistrar.java @@ -22,9 +22,16 @@ import org.springframework.stereotype.Component; import org.springframework.web.context.ServletContextAware; +//Added +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + @Component public class WebComponentRegistrar implements ServletContextAware { - + + //Added + private static final Logger log = LoggerFactory.getLogger(WebComponentRegistrar.class); + @Override public void setServletContext(ServletContext servletContext) { @@ -61,7 +68,9 @@ public void setServletContext(ServletContext servletContext) { //This happens on running openmrs after InitializationFilter or UpdateFilter //hence requiring a restart to see any page other than index.htm //After a restart, all mappings will then happen within Listener.contextInitialized() - ex.printStackTrace(); + + //Replaced + log.error("Error registering web component", ex); } } From 77a9e45b265315f4743fd82e806e65eee95e28f9 Mon Sep 17 00:00:00 2001 From: Aadvik krishna Date: Fri, 20 Feb 2026 01:01:33 +0530 Subject: [PATCH 2/6] Update omod/src/main/java/org/openmrs/web/WebComponentRegistrar.java Co-authored-by: suubi-joshua <78343336+suubi-joshua@users.noreply.github.com> --- omod/src/main/java/org/openmrs/web/WebComponentRegistrar.java | 1 - 1 file changed, 1 deletion(-) diff --git a/omod/src/main/java/org/openmrs/web/WebComponentRegistrar.java b/omod/src/main/java/org/openmrs/web/WebComponentRegistrar.java index 65166d83e..05d9e7473 100644 --- a/omod/src/main/java/org/openmrs/web/WebComponentRegistrar.java +++ b/omod/src/main/java/org/openmrs/web/WebComponentRegistrar.java @@ -22,7 +22,6 @@ import org.springframework.stereotype.Component; import org.springframework.web.context.ServletContextAware; -//Added import org.slf4j.Logger; import org.slf4j.LoggerFactory; From f7706790633e630707722a7fe3de8f6e06fc978a Mon Sep 17 00:00:00 2001 From: Aadvik krishna Date: Fri, 20 Feb 2026 01:11:17 +0530 Subject: [PATCH 3/6] Update omod/src/main/java/org/openmrs/web/WebComponentRegistrar.java Co-authored-by: suubi-joshua <78343336+suubi-joshua@users.noreply.github.com> --- omod/src/main/java/org/openmrs/web/WebComponentRegistrar.java | 1 - 1 file changed, 1 deletion(-) diff --git a/omod/src/main/java/org/openmrs/web/WebComponentRegistrar.java b/omod/src/main/java/org/openmrs/web/WebComponentRegistrar.java index 05d9e7473..41f4d6c56 100644 --- a/omod/src/main/java/org/openmrs/web/WebComponentRegistrar.java +++ b/omod/src/main/java/org/openmrs/web/WebComponentRegistrar.java @@ -28,7 +28,6 @@ @Component public class WebComponentRegistrar implements ServletContextAware { - //Added private static final Logger log = LoggerFactory.getLogger(WebComponentRegistrar.class); @Override From 373f6b094b71abdfb3dfa55306c70567c7e52538 Mon Sep 17 00:00:00 2001 From: Aadvik krishna Date: Fri, 20 Feb 2026 01:11:26 +0530 Subject: [PATCH 4/6] Update omod/src/main/java/org/openmrs/web/WebComponentRegistrar.java Co-authored-by: suubi-joshua <78343336+suubi-joshua@users.noreply.github.com> --- omod/src/main/java/org/openmrs/web/WebComponentRegistrar.java | 1 - 1 file changed, 1 deletion(-) diff --git a/omod/src/main/java/org/openmrs/web/WebComponentRegistrar.java b/omod/src/main/java/org/openmrs/web/WebComponentRegistrar.java index 41f4d6c56..c80b41cab 100644 --- a/omod/src/main/java/org/openmrs/web/WebComponentRegistrar.java +++ b/omod/src/main/java/org/openmrs/web/WebComponentRegistrar.java @@ -67,7 +67,6 @@ public void setServletContext(ServletContext servletContext) { //hence requiring a restart to see any page other than index.htm //After a restart, all mappings will then happen within Listener.contextInitialized() - //Replaced log.error("Error registering web component", ex); } } From 41208d0b435e4bf1cb34d1c51ae61b372bf17159 Mon Sep 17 00:00:00 2001 From: Aadvik krishna Date: Fri, 20 Feb 2026 01:11:36 +0530 Subject: [PATCH 5/6] Update omod/src/main/java/org/openmrs/web/WebComponentRegistrar.java Co-authored-by: suubi-joshua <78343336+suubi-joshua@users.noreply.github.com> --- omod/src/main/java/org/openmrs/web/WebComponentRegistrar.java | 1 - 1 file changed, 1 deletion(-) diff --git a/omod/src/main/java/org/openmrs/web/WebComponentRegistrar.java b/omod/src/main/java/org/openmrs/web/WebComponentRegistrar.java index c80b41cab..8a62bfce2 100644 --- a/omod/src/main/java/org/openmrs/web/WebComponentRegistrar.java +++ b/omod/src/main/java/org/openmrs/web/WebComponentRegistrar.java @@ -27,7 +27,6 @@ @Component public class WebComponentRegistrar implements ServletContextAware { - private static final Logger log = LoggerFactory.getLogger(WebComponentRegistrar.class); @Override From aa55aa9de5aa69f4be2accb3841511a372a5593a Mon Sep 17 00:00:00 2001 From: Aadvik Date: Sat, 21 Feb 2026 23:54:14 +0530 Subject: [PATCH 6/6] docs: remove duplicate info from README --- README.md | 3 --- 1 file changed, 3 deletions(-) diff --git a/README.md b/README.md index b21bfb22d..6409d7307 100644 --- a/README.md +++ b/README.md @@ -8,6 +8,3 @@ administrative functions that are not yet implemented in the new UI. maintain backwards compatibility. - The main idea behind this project is to move legacy UI functions into an OpenMRS module that these implementations can install until they are able to migrate away from it, since most of the implementations of OpenMRS around the world are running OpenMRS 1.9. - -- It is compulsory to run openmrs-module-legacyui against legacyui branch of openmrs-core -that I have created to eventually remove legacyui.