Skip to content

Commit fb1f022

Browse files
author
Joan Viladrosa
authored
Use non deprecated constructor (#18)
1 parent ca0bbd2 commit fb1f022

2 files changed

Lines changed: 42 additions & 3 deletions

File tree

src/main/java/org/openrewrite/java/dependencies/ChangeDependency.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,6 @@ public class ChangeDependency extends Recipe {
7070
@Nullable
7171
private final String versionPattern;
7272

73-
// Maven only parameters
7473
@Option(displayName = "Override managed version",
7574
description = "If the new dependency has a managed version, this flag can be used to explicitly set the version on the dependency. The default for this flag is `false`.",
7675
required = false)
@@ -102,7 +101,7 @@ public List<Recipe> getRecipeList() {
102101
!Objects.equals(changeGradleDependency.getNewVersion(), newVersion) ||
103102
!Objects.equals(changeGradleDependency.getVersionPattern(), versionPattern)
104103
) {
105-
changeGradleDependency = new org.openrewrite.gradle.ChangeDependency(oldGroupId, oldArtifactId, newGroupId, newArtifactId, newVersion, versionPattern);
104+
changeGradleDependency = new org.openrewrite.gradle.ChangeDependency(oldGroupId, oldArtifactId, newGroupId, newArtifactId, newVersion, versionPattern, overrideManagedVersion);
106105
changeMavenDependency = new org.openrewrite.maven.ChangeDependencyGroupIdAndArtifactId(oldGroupId, oldArtifactId, newGroupId, newArtifactId, newVersion, versionPattern, overrideManagedVersion);
107106
}
108107
return Arrays.asList(

src/test/java/org/openrewrite/java/dependencies/ChangeDependencyTest.java

Lines changed: 41 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ void changeMavenDependency() {
108108
}
109109

110110
@Test
111-
void doNotPinWhenNotVersioned() {
111+
void doNotPinWhenNotVersionedGradle() {
112112
rewriteRun(
113113
spec -> spec
114114
.beforeRecipe(withToolingApi())
@@ -146,4 +146,44 @@ void doNotPinWhenNotVersioned() {
146146
""")
147147
);
148148
}
149+
150+
@Test
151+
void pinWhenOverrideManagedVersionGradle() {
152+
rewriteRun(
153+
spec -> spec
154+
.beforeRecipe(withToolingApi())
155+
.recipe(new ChangeDependency("mysql", "mysql-connector-java", "com.mysql", "mysql-connector-j", "8.0.x", null, true)),
156+
buildGradle(
157+
"""
158+
plugins {
159+
id 'java'
160+
id 'org.springframework.boot' version '2.6.1'
161+
id 'io.spring.dependency-management' version '1.0.11.RELEASE'
162+
}
163+
164+
repositories {
165+
mavenCentral()
166+
}
167+
168+
dependencies {
169+
runtimeOnly 'mysql:mysql-connector-java'
170+
}
171+
""",
172+
"""
173+
plugins {
174+
id 'java'
175+
id 'org.springframework.boot' version '2.6.1'
176+
id 'io.spring.dependency-management' version '1.0.11.RELEASE'
177+
}
178+
179+
repositories {
180+
mavenCentral()
181+
}
182+
183+
dependencies {
184+
runtimeOnly 'com.mysql:mysql-connector-j:8.0.33'
185+
}
186+
""")
187+
);
188+
}
149189
}

0 commit comments

Comments
 (0)