enhance TestsShouldNotBePublicTest

[sullis]

What's changed?

improve test cases in TestsShouldNotBePublicTest

What's your motivation?

more test coverage

Checklist

• I've added unit tests to cover both positive and negative cases
• I've read and applied the recipe conventions and best practices
• I've used the IntelliJ IDEA auto-formatter on affected files

[timtebeek]

Hi @sullis ; thanks for the offer to help. In this case I'm not sure it's a clear improvement. We try to keep our unit tests as minimal as possible for the scenario they are testing, and in this case it doesn't make a difference whether the parent class is abstract or not, as it's the methods that we visit either way. The original test method already covers both sides of this conditional:

rewrite-testing-frameworks/src/main/java/org/openrewrite/java/testing/cleanup/TestsShouldNotBePublic.java

Lines 161 to 163 in 130079a

	if (m.hasModifier(J.Modifier.Type.Abstract) || TypeUtils.isOverride(method.getMethodType())) {
	return m;
	}

I'm afraid the added elements here distract from what we're testing, and might complicate stepping through with a debugger since there's more "skips" and mental parsing needed to figure out exactly what's asserted here. Because of that I'm leaning towards closing this PR for now.

Did you see or expect any issues that prompted you to add these additional elements?