S1144: Unused "private" methods should be removed

Signed-off-by: Vincent Potucek <[email protected]>

Author: Vincent Potucek

CHANGELOG.md

@@ -33,6 +33,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 - Grant access to testclusters dir for tests ([#19085](https://github.com/opensearch-project/OpenSearch/issues/19085))
 - Fix assertion error when collapsing search results with concurrent segment search enabled ([#19053](https://github.com/opensearch-project/OpenSearch/pull/19053))
 - Fix skip_unavailable setting changing to default during node drop issue ([#18766](https://github.com/opensearch-project/OpenSearch/pull/18766))
+- S1144: Unused "private" methods should be removed ([#18918](https://github.com/opensearch-project/OpenSearch/pull/18918))
 
 ### Dependencies
 - Bump `com.netflix.nebula.ospackage-base` from 12.0.0 to 12.1.0 ([#19019](https://github.com/opensearch-project/OpenSearch/pull/19019))

libs/task-commons/src/main/java/org/opensearch/task/commons/clients/TaskListRequest.java

@@ -71,16 +71,6 @@ public TaskListRequest taskType(TaskStatus... taskStatus) {
         return this;
     }
 
-    /**
-     * Update worker node to filter with in the request
-     * @param workerNode WorkerNode
-     * @return ListTaskRequest
-     */
-    private TaskListRequest workerNode(WorkerNode workerNode) {
-        this.workerNodes = workerNode;
-        return this;
-    }
-
     /**
      * Update page number to start with when fetching the list of tasks
      * @param startPageNumber startPageNumber

modules/cache-common/src/test/java/org/opensearch/cache/common/tier/TieredSpilloverCacheTests.java

@@ -2665,17 +2665,6 @@ private TieredSpilloverCache<String, String> getTieredSpilloverCache(
         return builder.build();
     }
 
-    private TieredSpilloverCache<String, String> initializeTieredSpilloverCache(
-        int keyValueSize,
-        int diskCacheSize,
-        RemovalListener<ICacheKey<String>, String> removalListener,
-        Settings settings,
-        long diskDeliberateDelay
-
-    ) {
-        return initializeTieredSpilloverCache(keyValueSize, diskCacheSize, removalListener, settings, diskDeliberateDelay, null, 256);
-    }
-
     private TieredSpilloverCache<String, String> initializeTieredSpilloverCache(
         int keyValueSize,
         int diskCacheSize,

plugins/arrow-flight-rpc/src/internalClusterTest/java/org/opensearch/arrow/flight/chaos/ChaosAgent.java

@@ -14,7 +14,6 @@
 import javassist.ClassPool;
 import javassist.CtClass;
 import javassist.CtConstructor;
-import javassist.CtMethod;
 
 /**
  * Java agent for bytecode injection of chaos testing
@@ -75,27 +74,6 @@ private boolean shouldTransform(String className) {
             return className.startsWith("org/opensearch/arrow/flight/transport/Flight");
         }
 
-        private void transformFlightTransport(CtClass ctClass) throws Exception {
-            CtMethod method = ctClass.getDeclaredMethod("openConnection");
-            method.insertBefore("org.opensearch.arrow.flight.chaos.ChaosScenario.injectChaos();");
-        }
-
-        private void transformFlightTransportChannel(CtClass ctClass) throws Exception {
-            CtMethod sendBatch = ctClass.getDeclaredMethod("sendResponseBatch");
-            sendBatch.insertBefore("org.opensearch.arrow.flight.chaos.ChaosScenario.injectChaos();");
-
-            CtMethod complete = ctClass.getDeclaredMethod("completeStream");
-            complete.insertBefore("org.opensearch.arrow.flight.chaos.ChaosScenario.injectChaos();");
-        }
-
-        private void transformFlightTransportResponse(CtClass ctClass) throws Exception {
-            CtMethod nextResponse = ctClass.getDeclaredMethod("nextResponse");
-            nextResponse.insertBefore("org.opensearch.arrow.flight.chaos.ChaosScenario.injectChaos();");
-
-            // CtMethod close = ctClass.getDeclaredMethod("close");
-            // close.insertBefore("org.opensearch.arrow.flight.chaos.ChaosInterceptor.beforeResponseClose();");
-        }
-
         private void transformFlightServerChannelWithDelay(CtClass ctClass) throws Exception {
             CtConstructor[] ctr = ctClass.getConstructors();
             ctr[0].insertBefore("org.opensearch.arrow.flight.chaos.ChaosScenario.injectChaos();");

plugins/arrow-flight-rpc/src/internalClusterTest/java/org/opensearch/arrow/flight/chaos/ChaosScenario.java

@@ -8,7 +8,6 @@
 
 package org.opensearch.arrow.flight.chaos;
 
-import org.opensearch.transport.stream.StreamErrorCode;
 import org.opensearch.transport.stream.StreamException;
 
 import java.util.concurrent.atomic.AtomicBoolean;
@@ -67,20 +66,6 @@ public static void injectChaos() throws StreamException {
         }
     }
 
-    private static void simulateUnresponsiveness() throws StreamException {
-        try {
-            Thread.sleep(timeoutDelayMs);
-        } catch (InterruptedException e) {
-            Thread.currentThread().interrupt();
-        }
-        throw new StreamException(StreamErrorCode.TIMED_OUT, "Client unresponsive");
-    }
-
-    private static void simulateClientNodeDeath() throws StreamException {
-        // Simulate node death followed by recovery
-        throw new StreamException(StreamErrorCode.UNAVAILABLE, "Client node death - connection lost");
-    }
-
     private static void simulateLongRunningOperation() throws StreamException {
         try {
             Thread.sleep(timeoutDelayMs);

plugins/arrow-flight-rpc/src/main/java/org/opensearch/arrow/flight/bootstrap/FlightClientManager.java

@@ -35,7 +35,6 @@
 import java.util.Map;
 import java.util.Objects;
 import java.util.Optional;
-import java.util.Set;
 import java.util.concurrent.CompletableFuture;
 import java.util.concurrent.ConcurrentHashMap;
 import java.util.concurrent.ExecutorService;
@@ -247,10 +246,6 @@ private static boolean isValidNode(DiscoveryNode node) {
         return node != null && !node.getVersion().before(MIN_SUPPORTED_VERSION) && FeatureFlags.isEnabled(ARROW_STREAMS_SETTING);
     }
 
-    private Set<String> getCurrentClusterNodes() {
-        return Objects.requireNonNull(clientConfig.clusterService).state().nodes().getNodes().keySet();
-    }
-
     @VisibleForTesting
     Map<String, ClientHolder> getFlightClients() {
         return flightClients;

plugins/cache-ehcache/src/test/java/org/opensearch/cache/store/disk/EhCacheDiskCacheTests.java

@@ -1264,35 +1264,6 @@ PersistentCacheManager buildCacheManager() {
         }
     }
 
-    private EhcacheDiskCache.Builder<String, String> createDummyBuilder(String storagePath) throws IOException {
-        Settings settings = Settings.builder().build();
-        MockRemovalListener<String, String> removalListener = new MockRemovalListener<>();
-        ToLongBiFunction<ICacheKey<String>, String> weigher = getWeigher();
-        try (NodeEnvironment env = newNodeEnvironment(settings)) {
-            if (storagePath == null || storagePath.isBlank()) {
-                storagePath = env.nodePaths()[0].path.toString() + "/request_cache";
-            }
-            return (EhcacheDiskCache.Builder<String, String>) new EhcacheDiskCache.Builder<String, String>().setThreadPoolAlias(
-                "ehcacheTest"
-            )
-                .setIsEventListenerModeSync(true)
-                .setStoragePath(storagePath)
-                .setKeyType(String.class)
-                .setValueType(String.class)
-                .setKeySerializer(new StringSerializer())
-                .setDiskCacheAlias("test1")
-                .setValueSerializer(new StringSerializer())
-                .setDimensionNames(List.of(dimensionName))
-                .setCacheType(CacheType.INDICES_REQUEST_CACHE)
-                .setSettings(settings)
-                .setExpireAfterAccess(TimeValue.MAX_VALUE)
-                .setMaximumWeightInBytes(CACHE_SIZE_IN_BYTES)
-                .setRemovalListener(removalListener)
-                .setWeigher(weigher)
-                .setStatsTrackingEnabled(false);
-        }
-    }
-
     private List<String> getRandomDimensions(List<String> dimensionNames) {
         Random rand = Randomness.get();
         int bound = 3;

server/src/internalClusterTest/java/org/opensearch/cluster/routing/allocation/decider/DiskThresholdDeciderIT.java

@@ -503,12 +503,6 @@ public void testDiskMonitorResetLastRuntimeMilliSecOnlyInFirstCall() throws Exce
         }, 30L, TimeUnit.SECONDS);
     }
 
-    private String populateNode(final String dataNodeName) throws Exception {
-        final String indexName = randomAlphaOfLength(10).toLowerCase(Locale.ROOT);
-        createAndPopulateIndex(indexName, dataNodeName);
-        return indexName;
-    }
-
     private void createIndex(String indexName, String nodeName, boolean isWarmIndex) throws Exception {
         final Settings.Builder indexSettingBuilder = Settings.builder()
             .put(IndexMetadata.SETTING_NUMBER_OF_REPLICAS, 0)

server/src/internalClusterTest/java/org/opensearch/remotestore/RemoteStoreClusterStateRestoreIT.java

@@ -83,10 +83,6 @@ protected Settings nodeSettings(int nodeOrdinal) {
         return Settings.builder().put(super.nodeSettings(nodeOrdinal)).put(REMOTE_CLUSTER_STATE_ENABLED_SETTING.getKey(), true).build();
     }
 
-    private void addNewNodes(int dataNodeCount, int clusterManagerNodeCount) {
-        internalCluster().startNodes(dataNodeCount + clusterManagerNodeCount);
-    }
-
     private Map<String, Long> initialTestSetup(int shardCount, int replicaCount, int dataNodeCount, int clusterManagerNodeCount) {
         prepareCluster(clusterManagerNodeCount, dataNodeCount, INDEX_NAME, replicaCount, shardCount);
         Map<String, Long> indexStats = indexData(1, false, INDEX_NAME);

server/src/main/java/org/opensearch/action/admin/cluster/node/info/NodesInfoRequest.java

@@ -146,19 +146,6 @@ public NodesInfoRequest removeMetric(String metric) {
         return this;
     }
 
-    /**
-     * Helper method for adding and removing metrics. Used when deserializing
-     * a NodesInfoRequest from an ordered list of booleans.
-     *
-     * @param addMetric Whether or not to include a metric.
-     * @param metricName Name of the metric to include or remove.
-     */
-    private void optionallyAddMetric(boolean addMetric, String metricName) {
-        if (addMetric) {
-            requestedMetrics.add(metricName);
-        }
-    }
-
     @Override
     public void writeTo(StreamOutput out) throws IOException {
         super.writeTo(out);