S1144: Unused "private" methods should be removed

Author: Vincent Potucek

.github/workflows/owasp.yml

@@ -14,7 +14,6 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 - Use S3CrtClient for higher throughput while uploading files to S3 ([#18800](https://github.com/opensearch-project/OpenSearch/pull/18800))
 - Add a dynamic setting to change skip_cache_factor and min_frequency for querycache ([#18351](https://github.com/opensearch-project/OpenSearch/issues/18351))
 - Add overload constructor for Translog to accept Channel Factory as a parameter ([#18918](https://github.com/opensearch-project/OpenSearch/pull/18918))
-- Introduce `Rewrite` fixing `S1144`: Unused "private" methods should be removed ([#18791](https://github.com/opensearch-project/OpenSearch/pull/18791))
 
 ### Changed
 - Add CompletionStage variants to methods in the Client Interface and default to ActionListener impl ([#18998](https://github.com/opensearch-project/OpenSearch/pull/18998))
@@ -34,6 +33,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 - Grant access to testclusters dir for tests ([#19085](https://github.com/opensearch-project/OpenSearch/issues/19085))
 - Fix assertion error when collapsing search results with concurrent segment search enabled ([#19053](https://github.com/opensearch-project/OpenSearch/pull/19053))
 - Fix skip_unavailable setting changing to default during node drop issue ([#18766](https://github.com/opensearch-project/OpenSearch/pull/18766))
+- S1144: Unused "private" methods should be removed ([#18918](https://github.com/opensearch-project/OpenSearch/pull/18918))
 
 ### Dependencies
 - Bump `com.netflix.nebula.ospackage-base` from 12.0.0 to 12.1.0 ([#19019](https://github.com/opensearch-project/OpenSearch/pull/19019))

.github/workflows/rewrite.yml

@@ -76,9 +76,9 @@ Fork [opensearch-project/OpenSearch](https://github.com/opensearch-project/OpenS
 
 #### JDK
 
-OpenSearch recommends building with the [Temurin/Adoptium](https://adoptium.net/temurin/releases/) distribution. JDK 11 is the minimum supported, and JDK-24 is the newest supported. You must have a supported JDK installed with the environment variable `JAVA_HOME` referencing the path to Java home for your JDK installation, e.g. `JAVA_HOME=/usr/lib/jvm/jdk-21`.
+OpenSearch recommends building with the [Temurin/Adoptium](https://adoptium.net/temurin/releases/) distribution. JDK 11 is the minimum supported, and JDK-24 is the newest supported. You must have a supported JDK installed with the environment variable `JAVA_HOME` referencing the path to Java home for your JDK installation, e.g. `JAVA_HOME=/usr/lib/jvm/jdk-21`. 
 
-Download Java 11 from [here](https://adoptium.net/releases.html?variant=openjdk11).
+Download Java 11 from [here](https://adoptium.net/releases.html?variant=openjdk11). 
 
 
 In addition, certain backward compatibility tests check out and compile the previous major version of OpenSearch, and therefore require installing [JDK 11](https://adoptium.net/temurin/releases/?version=11) and [JDK 17](https://adoptium.net/temurin/releases/?version=17) and setting the `JAVA11_HOME` and `JAVA17_HOME` environment variables. More to that, since 8.10 release, Gradle has deprecated the usage of the any JDKs below JDK-16. For smooth development experience, the recommendation is to install at least [JDK 17](https://adoptium.net/temurin/releases/?version=17) or [JDK 21](https://adoptium.net/temurin/releases/?version=21). If you still want to build with JDK-11 only, please add `-Dorg.gradle.warning.mode=none` when invoking any Gradle build task from command line, for example:
@@ -341,49 +341,6 @@ Please follow these formatting guidelines:
 * Note that JavaDoc and block comments i.e. `/* ... */` are not formatted, but line comments i.e `// ...` are.
 * There is an implicit rule that negative boolean expressions should use the form `foo == false` instead of `!foo` for better readability of the code. While this isn't strictly enforced, it might get called out in PR reviews as something to change.
 
-## 🚀 Code Transformation & Automated Rewriting
-*(Advanced Refactoring, Modernization, and Bulk Code Changes)*
-
-### 🔧 Automated Rewriting of Source Code
-The OpenSearch build system supports **automated, large-scale code transformations** using [Moderne](https://moderne.io/) and OpenRewrite. These tools enable:
-
-- **Safe Refactoring** (e.g., renaming methods, migrating deprecated APIs)
-- **Modernization** (e.g., adopting Java 17 features like `var`, `records`, or `switch` expressions)
-- **Anti-Pattern Fixes** (e.g., replacing `Vector` with `ArrayList`, removing redundant `StringBuilder`)
-- **Convention Enforcement** (e.g., consistent JUnit test naming, `final` keyword usage)
-- **Dependency Upgrades** (e.g., automatic migration when updating library versions)
-
-
-### ⚙️ Usage
-
-- **Dry-run (check for changes):**
-    - Full project:
-      - `./gradlew  rewriteDryRun`
-    - Subproject (e.g., `server`):
-      - `./gradlew server: rewriteDryRun`
----
-
-- **Apply transformations:**
-    - Full project:
-      - `./gradlew rewriteRun`
-    - Subproject:
-      - `./gradlew server:rewriteRun`
----
-### 🛠️ Example Transformations
-
-| **Before**                     | **After**                          | **Rule**                          |
-|--------------------------------|------------------------------------|-----------------------------------|
-| `new ArrayList<String>()`      | `new ArrayList<>()`                | Diamond Operator (Java 7+)        |
-| `if (x == false)`              | `if (!x)`                          | Boolean Simplification            |
-| `@Test public void testFoo()`  | `@Test void foo()`                 | JUnit 5 Convention                |
-
-### ⚠️ Notes
-
-- **Custom Rules**: Add project-specific rewrites in `code-convention.yml`.
-- **Exclusions**: Use `// rewrite:off` and `// rewrite:on` to opt out of transformations for specific code blocks.
-- **PR Reviews**: Automated rewrites are flagged in CI. Verify changes match intent before merging.
-- **javalangoutofmemoryerror**: https://docs.openrewrite.org/reference/faq#im-getting-javalangoutofmemoryerror-java-heap-space-when-running-openrewrite
-
 ## Adding Dependencies
 
 When adding a new dependency or removing an existing dependency via any `build.gradle` (that are not in the test scope), update the dependency LICENSE and library SHAs.

CHANGELOG.md

@@ -56,8 +56,6 @@ plugins {
   id 'opensearch.global-build-info'
   id "com.diffplug.spotless" version "6.25.0" apply false
   id "org.gradle.test-retry" version "1.6.2" apply false
-  id "org.openrewrite.rewrite" version "7.15.0" apply false
-  id "org.owasp.dependencycheck" version "12.1.3" apply false
   id "test-report-aggregation"
   id 'jacoco-report-aggregation'
 }
@@ -67,8 +65,6 @@ apply from: 'gradle/runtime-jdk-provision.gradle'
 apply from: 'gradle/ide.gradle'
 apply from: 'gradle/forbidden-dependencies.gradle'
 apply from: 'gradle/formatting.gradle'
-apply from: 'gradle/rewrite.gradle'
-apply from: 'gradle/owasp.gradle'
 apply from: 'gradle/local-distribution.gradle'
 apply from: 'gradle/run.gradle'
 apply from: 'gradle/missing-javadoc.gradle'

DEVELOPER_GUIDE.md

@@ -13,14 +13,13 @@
 org.gradle.caching=true
 org.gradle.warning.mode=none
 org.gradle.parallel=true
-org.gradle.configuration-cache=true
-org.gradle.jvmargs=-Xmx8g -XX:+HeapDumpOnOutOfMemoryError -Xss2m \
+org.gradle.jvmargs=-Xmx3g -XX:+HeapDumpOnOutOfMemoryError -Xss2m \
     --add-exports jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED \
     --add-exports jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED \
     --add-exports jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED \
     --add-exports jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED \
     --add-exports jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED
-options.forkOptions.memoryMaximumSize=8g
+options.forkOptions.memoryMaximumSize=3g
 
 # Disable duplicate project id detection
 # See https://docs.gradle.org/current/userguide/upgrading_version_6.html#duplicate_project_names_may_cause_publication_to_fail