Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all plugins in the default distribution have a PR check to run integ tests w/ security #5096

Open
cwperks opened this issue Feb 5, 2025 · 0 comments
Labels
enhancement New feature or request untriaged Require the attention of the repository maintainers and may need to be prioritized

Comments

@cwperks
Copy link
Member

cwperks commented Feb 5, 2025

Is your feature request related to a problem?

Many plugins in the default distribution already run integ tests w/ security as a PR check (see example from ISM or recent contribution to AD to use testclusters for security testing).

During 2.19 testing, an issue was discovered in the skill repo related to a recent change in ml-commons that required wrapping a call with the sdkClient in a stashedContext.

The skills repo has a PR check w/ security that caught the issue even though the issue came from ml-commons. Currently ml-commons does not have a PR check to run integ tests with security. See their workflows here: https://github.com/opensearch-project/ml-commons/tree/main/.github/workflows

This issue should track adding a PR check to all components in the default distribution to run integ tests w/ security for every PR.

@cwperks cwperks added enhancement New feature or request untriaged Require the attention of the repository maintainers and may need to be prioritized labels Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request untriaged Require the attention of the repository maintainers and may need to be prioritized
Projects
None yet
Development

No branches or pull requests

1 participant