OCPBUGS-55671: Remove MultiArchInstallAWS featuregate

barbacbd · barbacbd · commit 7a35525823fc · 2025-05-21T07:16:02.000-04:00
** The MultiArchInstallAWS feature gate has been enabled by default. This change removes the check for the feature gate during aws installs, and the feature gate is treated as enabled by default.
diff --git a/features.md b/features.md
@@ -81,7 +81,6 @@
 | ManagedBootImages| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
 | ManagedBootImagesAWS| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
 | MetricsCollectionProfiles| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
-| MultiArchInstallAWS| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
 | NetworkDiagnosticsConfig| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
 | NetworkLiveMigration| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
 | NetworkSegmentation| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
diff --git a/features/features.go b/features/features.go
@@ -603,14 +603,6 @@ var (
 						enableIn(configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
 						mustRegister()
 
-	FeatureGateMultiArchInstallAWS = newFeatureGate("MultiArchInstallAWS").
-					reportProblemsToJiraComponent("Installer").
-					contactPerson("r4f4").
-					productScope(ocpSpecific).
-					enhancementPR(legacyFeatureGateWithoutEnhancement).
-					enableIn(configv1.Default, configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
-					mustRegister()
-
 	FeatureGateMultiArchInstallAzure = newFeatureGate("MultiArchInstallAzure").
 						reportProblemsToJiraComponent("Installer").
 						contactPerson("r4f4").
diff --git a/payload-manifests/featuregates/featureGate-Hypershift-Default.yaml b/payload-manifests/featuregates/featureGate-Hypershift-Default.yaml
@@ -258,9 +258,6 @@
                     {
                         "name": "MetricsCollectionProfiles"
                     },
-                    {
-                        "name": "MultiArchInstallAWS"
-                    },
                     {
                         "name": "NetworkDiagnosticsConfig"
                     },
diff --git a/payload-manifests/featuregates/featureGate-Hypershift-DevPreviewNoUpgrade.yaml b/payload-manifests/featuregates/featureGate-Hypershift-DevPreviewNoUpgrade.yaml
@@ -200,9 +200,6 @@
                     {
                         "name": "MixedCPUsAllocation"
                     },
-                    {
-                        "name": "MultiArchInstallAWS"
-                    },
                     {
                         "name": "NetworkDiagnosticsConfig"
                     },
diff --git a/payload-manifests/featuregates/featureGate-Hypershift-TechPreviewNoUpgrade.yaml b/payload-manifests/featuregates/featureGate-Hypershift-TechPreviewNoUpgrade.yaml
@@ -212,9 +212,6 @@
                     {
                         "name": "MixedCPUsAllocation"
                     },
-                    {
-                        "name": "MultiArchInstallAWS"
-                    },
                     {
                         "name": "NetworkDiagnosticsConfig"
                     },
diff --git a/payload-manifests/featuregates/featureGate-SelfManagedHA-Default.yaml b/payload-manifests/featuregates/featureGate-SelfManagedHA-Default.yaml
@@ -255,9 +255,6 @@
                     {
                         "name": "MetricsCollectionProfiles"
                     },
-                    {
-                        "name": "MultiArchInstallAWS"
-                    },
                     {
                         "name": "NetworkDiagnosticsConfig"
                     },
diff --git a/payload-manifests/featuregates/featureGate-SelfManagedHA-DevPreviewNoUpgrade.yaml b/payload-manifests/featuregates/featureGate-SelfManagedHA-DevPreviewNoUpgrade.yaml
@@ -185,9 +185,6 @@
                     {
                         "name": "MixedCPUsAllocation"
                     },
-                    {
-                        "name": "MultiArchInstallAWS"
-                    },
                     {
                         "name": "NetworkDiagnosticsConfig"
                     },
diff --git a/payload-manifests/featuregates/featureGate-SelfManagedHA-TechPreviewNoUpgrade.yaml b/payload-manifests/featuregates/featureGate-SelfManagedHA-TechPreviewNoUpgrade.yaml
@@ -197,9 +197,6 @@
                     {
                         "name": "MixedCPUsAllocation"
                     },
-                    {
-                        "name": "MultiArchInstallAWS"
-                    },
                     {
                         "name": "NetworkDiagnosticsConfig"
                     },

Original file line number	Diff line number	Diff line change
`@@ -258,9 +258,6 @@`
`258`	`258`	`{`
`259`	`259`	`"name": "MetricsCollectionProfiles"`
`260`	`260`	`},`
`261`		`- {`
`262`		`- "name": "MultiArchInstallAWS"`
`263`		`- },`
`264`	`261`	`{`
`265`	`262`	`"name": "NetworkDiagnosticsConfig"`
`266`	`263`	`},`
Original file line number	Diff line number	Diff line change
`@@ -200,9 +200,6 @@`
`200`	`200`	`{`
`201`	`201`	`"name": "MixedCPUsAllocation"`
`202`	`202`	`},`
`203`		`- {`
`204`		`- "name": "MultiArchInstallAWS"`
`205`		`- },`
`206`	`203`	`{`
`207`	`204`	`"name": "NetworkDiagnosticsConfig"`
`208`	`205`	`},`
Original file line number	Diff line number	Diff line change
`@@ -212,9 +212,6 @@`
`212`	`212`	`{`
`213`	`213`	`"name": "MixedCPUsAllocation"`
`214`	`214`	`},`
`215`		`- {`
`216`		`- "name": "MultiArchInstallAWS"`
`217`		`- },`
`218`	`215`	`{`
`219`	`216`	`"name": "NetworkDiagnosticsConfig"`
`220`	`217`	`},`
Original file line number	Diff line number	Diff line change
`@@ -255,9 +255,6 @@`
`255`	`255`	`{`
`256`	`256`	`"name": "MetricsCollectionProfiles"`
`257`	`257`	`},`
`258`		`- {`
`259`		`- "name": "MultiArchInstallAWS"`
`260`		`- },`
`261`	`258`	`{`
`262`	`259`	`"name": "NetworkDiagnosticsConfig"`
`263`	`260`	`},`
Original file line number	Diff line number	Diff line change
`@@ -185,9 +185,6 @@`
`185`	`185`	`{`
`186`	`186`	`"name": "MixedCPUsAllocation"`
`187`	`187`	`},`
`188`		`- {`
`189`		`- "name": "MultiArchInstallAWS"`
`190`		`- },`
`191`	`188`	`{`
`192`	`189`	`"name": "NetworkDiagnosticsConfig"`
`193`	`190`	`},`
Original file line number	Diff line number	Diff line change
`@@ -197,9 +197,6 @@`
`197`	`197`	`{`
`198`	`198`	`"name": "MixedCPUsAllocation"`
`199`	`199`	`},`
`200`		`- {`
`201`		`- "name": "MultiArchInstallAWS"`
`202`		`- },`
`203`	`200`	`{`
`204`	`201`	`"name": "NetworkDiagnosticsConfig"`
`205`	`202`	`},`