Skip to content

Add validate command #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Add validate command #573

wants to merge 2 commits into from

Conversation

@vimalk78
Copy link
Contributor

@vimalk78 vimalk78 commented Sep 19, 2025

Added a command to validate syntax of another command, using existing validation logic.

validate <command> - Check command syntax without executing

requires merging #571

@vimalk78
feat: improve Slack bot UX with robust parsing and progressive help
2f1b0f0 
  - Replace monolithic help with categorized progressive help system
  - Add dedicated help functions for each command category
  - Handle trailing commas/spaces in ParseImageInput without errors
  - Add fuzzy matching with "Did you mean?" suggestions for typos
  - Add comprehensive test coverage for parsing edge cases

Signed-off-by: Vimal Kumar <[email protected]>
@vimalk78
feat: add validate command for dry-run testing
62e73a7 
  - Add validate command to check syntax without execution
  - Support validation for launch, test, and build commands
  - Include detailed error messages and configuration preview
  - Update help documentation with validate examples
  - Use existing CheckValidJobConfiguration for validation logic

Signed-off-by: Vimal Kumar <[email protected]>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 19, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 19, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 19, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vimalk78
Once this PR has been reviewed and has the lgtm label, please assign jupierce for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Sep 27, 2025

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vimalk78 @openshift-merge-robot