[release-4.20] OCPBUGS-64742: Fix capacity calculation #188

openshift-cherrypick-robot · 2025-11-06T16:19:51Z

This is an automated cherry-pick of #184

/assign kyrtapz

The previous capacity calculation incorrectly only counted CloudPrivateIPConfigs that had the status set. This is racy and can lead to artificially reduced capacity. Fix it by accounting for all CloudPrivateIPConfigs that are or were assigned to the matching node. Change the calculation in openstack to only consider IPs that were assigned to the port by using `allowed_address_pairs`. Signed-off-by: Patryk Diak <[email protected]>

To avoid the following error being returned when trying to add/remove multiple IPs at once: err: googleapi: Error 412: Invalid fingerprint. From the docs: The request will fail with error 400 Bad Request if the fingerprint is not provided, or 412 Precondition Failed if the fingerprint is out of date. Signed-off-by: Patryk Diak <[email protected]>

Signed-off-by: Patryk Diak <[email protected]>

openshift-ci-robot · 2025-11-06T16:20:02Z

@openshift-cherrypick-robot: Jira Issue OCPBUGS-63348 has been cloned as Jira Issue OCPBUGS-64742. Will retitle bug to link to clone.
/retitle [release-4.20] OCPBUGS-64742: Fix capacity calculation

In response to this:

This is an automated cherry-pick of #184

/assign kyrtapz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2025-11-06T16:20:09Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci-robot · 2025-11-06T16:20:31Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-64742, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected dependent Jira Issue OCPBUGS-63348 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #184

/assign kyrtapz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

huiran0826 · 2025-11-07T04:11:56Z

/verified by @huiran0826

openshift-ci-robot · 2025-11-07T04:12:07Z

@huiran0826: This PR has been marked as verified by @huiran0826.

In response to this:

/verified by @huiran0826

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

kyrtapz · 2025-11-07T07:15:20Z

/retest-required

kyrtapz · 2025-11-07T08:18:14Z

even though it is very unlikely to be related I am retesting the okd job to see if the UDN failure is consistent(we might have an issue elsewhere)
/test okd-scos-e2e-aws-ovn

kyrtapz · 2025-11-07T08:18:22Z

/jira refresh

openshift-ci-robot · 2025-11-07T08:18:26Z

@kyrtapz: This pull request references Jira Issue OCPBUGS-64742, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected dependent Jira Issue OCPBUGS-63348 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

kyrtapz · 2025-11-07T08:39:56Z

/test okd-scos-e2e-aws-ovn

kyrtapz · 2025-11-07T09:58:34Z

/test okd-scos-e2e-aws-ovn

openshift-ci · 2025-11-07T12:37:58Z

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/security	`ed46ba9`	link	false	`/test security`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

kyrtapz · 2025-11-07T13:29:03Z

/cherry-pick release-4.19

openshift-cherrypick-robot · 2025-11-07T13:29:06Z

@kyrtapz: once the present PR merges, I will cherry-pick it on top of release-4.19 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

pperiyasamy · 2025-11-07T13:32:21Z

/lgtm

openshift-ci · 2025-11-07T13:32:41Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, pperiyasamy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [pperiyasamy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kyrtapz · 2025-11-07T13:35:56Z

/jira refresh

openshift-ci-robot · 2025-11-07T13:36:01Z

@kyrtapz: This pull request references Jira Issue OCPBUGS-64742, which is invalid:

expected dependent Jira Issue OCPBUGS-63348 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

anuragthehatter · 2025-11-07T19:12:57Z

Looks good as per same steps

/verified by @anuragthehatter

openshift-ci-robot · 2025-11-07T19:13:09Z

@anuragthehatter: This PR has been marked as verified by @anuragthehatter.

In response to this:

Looks good as per same steps

/verified by @anuragthehatter

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

huiran0826 · 2025-11-10T01:28:51Z

/jira refresh

openshift-ci-robot · 2025-11-10T01:28:59Z

@huiran0826: This pull request references Jira Issue OCPBUGS-64742, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.20.z) matches configured target version for branch (4.20.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
release note type set to "Release Note Not Required"
dependent bug Jira Issue OCPBUGS-63348 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-63348 targets the "4.21.0" version, which is one of the valid target versions: 4.21.0
bug has dependents

Requesting review from QA contact:
/cc @huiran0826

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

kyrtapz · 2025-11-12T08:00:10Z

/label backport-risk-assessed

openshift-ci-robot · 2025-11-12T08:04:00Z

@openshift-cherrypick-robot: Jira Issue Verification Checks: Jira Issue OCPBUGS-64742
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-64742 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

In response to this:

This is an automated cherry-pick of #184

/assign kyrtapz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-cherrypick-robot · 2025-11-12T08:04:49Z

@kyrtapz: new pull request created: #190

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

kyrtapz added 3 commits November 6, 2025 16:19

Cleanup in-memory node state on node removal

ed46ba9

Signed-off-by: Patryk Diak <[email protected]>

openshift-cherrypick-robot assigned kyrtapz Nov 6, 2025

openshift-cherrypick-robot mentioned this pull request Nov 6, 2025

OCPBUGS-63348: Fix capacity calculation #184

Merged

openshift-ci bot changed the title ~~[release-4.20] OCPBUGS-63348: Fix capacity calculation~~ [release-4.20] OCPBUGS-64742: Fix capacity calculation Nov 6, 2025

openshift-ci bot requested review from jcaamano and ricky-rav November 6, 2025 16:22

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 7, 2025

openshift-ci bot assigned pperiyasamy Nov 7, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2025

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2025

openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Nov 10, 2025

openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Nov 10, 2025

openshift-ci bot requested a review from huiran0826 November 10, 2025 01:29

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Nov 12, 2025

openshift-ci bot assigned anuragthehatter, asood-rh, barbora137, huiran0826, jechen0648, Meina-rh, mffiedler and qiowang721 Nov 12, 2025

openshift-merge-bot bot merged commit d22915b into openshift:release-4.20 Nov 12, 2025
13 of 14 checks passed

openshift-cherrypick-robot mentioned this pull request Nov 12, 2025

[release-4.19] OCPBUGS-65513: Fix capacity calculation #190

Merged

[release-4.20] OCPBUGS-64742: Fix capacity calculation #188

[release-4.20] OCPBUGS-64742: Fix capacity calculation #188

Uh oh!

Conversation

openshift-cherrypick-robot commented Nov 6, 2025

Uh oh!

openshift-ci-robot commented Nov 6, 2025

Uh oh!

coderabbitai bot commented Nov 6, 2025

Review skipped

Uh oh!

openshift-ci-robot commented Nov 6, 2025

Uh oh!

huiran0826 commented Nov 7, 2025

Uh oh!

openshift-ci-robot commented Nov 7, 2025

Uh oh!

kyrtapz commented Nov 7, 2025

Uh oh!

kyrtapz commented Nov 7, 2025

Uh oh!

kyrtapz commented Nov 7, 2025

Uh oh!

openshift-ci-robot commented Nov 7, 2025

Uh oh!

kyrtapz commented Nov 7, 2025

Uh oh!

kyrtapz commented Nov 7, 2025

Uh oh!

openshift-ci bot commented Nov 7, 2025

Uh oh!

kyrtapz commented Nov 7, 2025

Uh oh!

openshift-cherrypick-robot commented Nov 7, 2025

Uh oh!

pperiyasamy commented Nov 7, 2025

Uh oh!

openshift-ci bot commented Nov 7, 2025

Uh oh!

kyrtapz commented Nov 7, 2025

Uh oh!

openshift-ci-robot commented Nov 7, 2025

Uh oh!

anuragthehatter commented Nov 7, 2025

Uh oh!

openshift-ci-robot commented Nov 7, 2025

Uh oh!

huiran0826 commented Nov 10, 2025

Uh oh!

openshift-ci-robot commented Nov 10, 2025

Uh oh!

kyrtapz commented Nov 12, 2025

Uh oh!

Uh oh!

openshift-ci-robot commented Nov 12, 2025

Uh oh!

openshift-cherrypick-robot commented Nov 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants