Skip to content

Conversation

@orenc1
Copy link
Contributor

@orenc1 orenc1 commented Nov 28, 2025

currently, the openshift-network-console namespace is lacking the openshift.io/node-selector: "" annotation.
because of this, if defaultNodeSelector is being set in the default scheduler, the pods in this namespace are also affected, and therefore in some cases they cannot be scheduled.

…-network-console namespace

currently, the openshift-network-console namespace is lacking the openshift.io/node-selector annotation.
because of this, if defaultNodeSelector is being set in the default scheduler, the pods in this namespace are also affected,
and therefore in some cases they cannot be scheduled.

Signed-off-by: Oren Cohen <[email protected]>
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 28, 2025
@openshift-ci-robot
Copy link
Contributor

@orenc1: This pull request references Jira Issue OCPBUGS-56949, which is invalid:

  • expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

currently, the openshift-network-console namespace is lacking the openshift.io/node-selector: "" annotation.
because of this, if defaultNodeSelector is being set in the default scheduler, the pods in this namespace are also affected, and therefore in some cases they cannot be scheduled.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from ricky-rav and tssurya November 28, 2025 12:30
@coderabbitai
Copy link

coderabbitai bot commented Nov 28, 2025

Walkthrough

A new annotation openshift.io/node-selector: "" was added to the metadata.annotations section of the OpenShift Namespace manifest for the openshift-network-console resource.

Changes

Cohort / File(s) Change Summary
Namespace Annotation Addition
bindata/networking-console-plugin/000-namespace.yaml
Added openshift.io/node-selector: "" annotation to namespace metadata.annotations

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between a3935d6 and e3ab5b0.

📒 Files selected for processing (1)
  • bindata/networking-console-plugin/000-namespace.yaml (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**

⚙️ CodeRabbit configuration file

-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.

Files:

  • bindata/networking-console-plugin/000-namespace.yaml
🔇 Additional comments (1)
bindata/networking-console-plugin/000-namespace.yaml (1)

10-10: Annotation correctly prevents default node selector application.

The openshift.io/node-selector: "" annotation is the correct OpenShift mechanism to prevent pods in this namespace from being affected by the cluster-wide defaultNodeSelector. The empty string value signals to the scheduler to skip applying any default selectors to workloads in openshift-network-console.

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@ricky-rav ricky-rav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 28, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: orenc1, ricky-rav
Once this PR has been reviewed and has the lgtm label, please assign jacobtanenbaum for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@orenc1
Copy link
Contributor Author

orenc1 commented Nov 29, 2025

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 29, 2025

@orenc1: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-upgrade e3ab5b0 link true /test e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-windows e3ab5b0 link true /test e2e-aws-ovn-windows
ci/prow/security e3ab5b0 link false /test security
ci/prow/e2e-metal-ipi-ovn-dualstack-bgp e3ab5b0 link true /test e2e-metal-ipi-ovn-dualstack-bgp

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@orenc1 orenc1 changed the title OCPBUGS-56949: Add openshift.io/node-selector annotation to openshift-network-console namespace OCPBUGS-66159: Add openshift.io/node-selector annotation to openshift-network-console namespace Nov 30, 2025
@openshift-ci-robot
Copy link
Contributor

@orenc1: This pull request references Jira Issue OCPBUGS-66159, which is invalid:

  • expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

currently, the openshift-network-console namespace is lacking the openshift.io/node-selector: "" annotation.
because of this, if defaultNodeSelector is being set in the default scheduler, the pods in this namespace are also affected, and therefore in some cases they cannot be scheduled.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@orenc1
Copy link
Contributor Author

orenc1 commented Nov 30, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 30, 2025
@openshift-ci-robot
Copy link
Contributor

@orenc1: This pull request references Jira Issue OCPBUGS-66159, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants