-
Notifications
You must be signed in to change notification settings - Fork 265
OCPBUGS-66159: Add openshift.io/node-selector annotation to openshift-network-console namespace
#2848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
OCPBUGS-66159: Add openshift.io/node-selector annotation to openshift-network-console namespace
#2848
Conversation
…-network-console namespace currently, the openshift-network-console namespace is lacking the openshift.io/node-selector annotation. because of this, if defaultNodeSelector is being set in the default scheduler, the pods in this namespace are also affected, and therefore in some cases they cannot be scheduled. Signed-off-by: Oren Cohen <[email protected]>
|
@orenc1: This pull request references Jira Issue OCPBUGS-56949, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughA new annotation Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes ✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Cache: Disabled due to data retention organization setting Knowledge base: Disabled due to 📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (1)**⚙️ CodeRabbit configuration file
Files:
🔇 Additional comments (1)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Comment |
ricky-rav
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: orenc1, ricky-rav The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
@orenc1: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift.io/node-selector annotation to openshift-network-console namespaceopenshift.io/node-selector annotation to openshift-network-console namespace
|
@orenc1: This pull request references Jira Issue OCPBUGS-66159, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@orenc1: This pull request references Jira Issue OCPBUGS-66159, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
currently, the
openshift-network-consolenamespace is lacking theopenshift.io/node-selector: ""annotation.because of this, if
defaultNodeSelectoris being set in the default scheduler, the pods in this namespace are also affected, and therefore in some cases they cannot be scheduled.