Skip to content

Commit c004395

Browse files
committed
Address comments
1 parent ae49b02 commit c004395

File tree

1 file changed

+96
-87
lines changed

1 file changed

+96
-87
lines changed

.golangci.yaml

Lines changed: 96 additions & 87 deletions
Original file line numberDiff line numberDiff line change
@@ -5,125 +5,134 @@ run:
55
allow-parallel-runners: true
66
linters:
77
enable:
8-
- asciicheck
9-
- containedctx
10-
- copyloopvar
11-
- decorder
12-
- dogsled
13-
- errorlint
14-
- goconst
15-
- gocritic
16-
- gocyclo
17-
- godot
18-
- gosec
19-
- importas
20-
- misspell
21-
- nakedret
22-
- prealloc
23-
- predeclared
24-
- revive
25-
- staticcheck
26-
- thelper
27-
- unconvert
28-
- whitespace
8+
- asciicheck
9+
- containedctx
10+
- copyloopvar
11+
- decorder
12+
- dogsled
13+
- errorlint
14+
- goconst
15+
- gocritic
16+
- gocyclo
17+
- godot
18+
- gosec
19+
- importas
20+
- misspell
21+
- nakedret
22+
- prealloc
23+
- predeclared
24+
- revive
25+
- staticcheck
26+
- thelper
27+
- unconvert
28+
- whitespace
2929
settings:
3030
errcheck:
3131
disable-default-exclusions: true
3232
check-type-assertions: false
3333
check-blank: true
3434
exclude-functions:
35-
- io/ioutil.ReadFile
36-
- io.Copy(*bytes.Buffer)
37-
- io.Copy(os.Stdout)
35+
- io/ioutil.ReadFile
36+
- io.Copy(*bytes.Buffer)
37+
- io.Copy(os.Stdout)
3838
errorlint:
3939
errorf: true
4040
asserts: true
4141
comparison: true
4242
gosec:
4343
excludes:
44-
- G115
44+
- G115
45+
staticcheck:
46+
checks:
47+
# Default
48+
- all
49+
# Disable check for one at least one comment in a package
50+
- -ST1000
51+
# Disable quickfix checks
52+
- -QF1001
53+
- -QF1008
4554
revive:
4655
rules:
47-
- name: blank-imports
48-
- name: context-as-argument
49-
- name: context-keys-type
50-
- name: dot-imports
51-
- name: error-return
52-
- name: error-strings
53-
- name: error-naming
54-
- name: exported
55-
- name: if-return
56-
- name: increment-decrement
57-
- name: var-naming
58-
- name: var-declaration
59-
- name: range
60-
- name: receiver-naming
61-
- name: time-naming
62-
- name: unexported-return
63-
- name: indent-error-flow
64-
- name: errorf
65-
- name: superfluous-else
66-
- name: unreachable-code
67-
- name: redefines-builtin-id
68-
- name: bool-literal-in-expr
69-
- name: constant-logical-expr
56+
- name: blank-imports
57+
- name: context-as-argument
58+
- name: context-keys-type
59+
- name: dot-imports
60+
- name: error-return
61+
- name: error-strings
62+
- name: error-naming
63+
- name: exported
64+
- name: if-return
65+
- name: increment-decrement
66+
- name: var-naming
67+
- name: var-declaration
68+
- name: range
69+
- name: receiver-naming
70+
- name: time-naming
71+
- name: unexported-return
72+
- name: indent-error-flow
73+
- name: errorf
74+
- name: superfluous-else
75+
- name: unreachable-code
76+
- name: redefines-builtin-id
77+
- name: bool-literal-in-expr
78+
- name: constant-logical-expr
7079
exclusions:
7180
generated: lax
7281
presets:
73-
- common-false-positives
74-
- legacy
75-
- std-error-handling
82+
- common-false-positives
83+
- legacy
84+
- std-error-handling
7685
rules:
77-
- linters:
78-
- goconst
79-
path: _test\.go
86+
- linters:
87+
- goconst
88+
path: _test\.go
8089
paths:
81-
- ^bin
82-
- ^cluster-api
83-
- ^data/data
84-
- ^docs
85-
- ^hack
86-
- ^images
87-
- ^scripts
88-
- ^terraform
89-
- ^upi
90-
- ^pkg/asset/manifests/azure/stack/v1beta1
91-
- third_party$
92-
- builtin$
93-
- examples$
90+
- ^bin
91+
- ^cluster-api
92+
- ^data/data
93+
- ^docs
94+
- ^hack
95+
- ^images
96+
- ^scripts
97+
- ^terraform
98+
- ^upi
99+
- ^pkg/asset/manifests/azure/stack/v1beta1
100+
- third_party$
101+
- builtin$
102+
- examples$
94103
issues:
95104
uniq-by-line: false
96105
formatters:
97106
enable:
98-
- gofmt
99-
- goimports
107+
- gofmt
108+
- goimports
100109
settings:
101110
gci:
102111
sections:
103-
- standard
104-
- default
105-
- prefix(github.com/openshift)
106-
- blank
112+
- standard
113+
- default
114+
- prefix(github.com/openshift)
115+
- blank
107116
custom-order: true
108117
gofumpt:
109118
module-path: github.com/openshift/installer
110119
extra-rules: true
111120
goimports:
112121
local-prefixes:
113-
- github.com/openshift
122+
- github.com/openshift
114123
exclusions:
115124
generated: lax
116125
paths:
117-
- ^bin
118-
- ^cluster-api
119-
- ^data/data
120-
- ^docs
121-
- ^hack
122-
- ^images
123-
- ^scripts
124-
- ^terraform
125-
- ^upi
126-
- ^pkg/asset/manifests/azure/stack/v1beta1
127-
- third_party$
128-
- builtin$
129-
- examples$
126+
- ^bin
127+
- ^cluster-api
128+
- ^data/data
129+
- ^docs
130+
- ^hack
131+
- ^images
132+
- ^scripts
133+
- ^terraform
134+
- ^upi
135+
- ^pkg/asset/manifests/azure/stack/v1beta1
136+
- third_party$
137+
- builtin$
138+
- examples$

0 commit comments

Comments
 (0)