Upgrade GolangCI-lint to v2 #10121
Upgrade GolangCI-lint to v2 #10121
Conversation
openshift-merge-robot
added
the
needs-rebase
barbacbd
left a comment
barbacbd
left a comment
There was a problem hiding this comment.
@sebrandon1 It looks like this change would definitely help (I was looking at this the other day too). First, it looks like CI tests need to be updated too
golangci-lint has version 1.64.8 built with go1.24.1 from 8b37f141 on 2025-03-17T20:41:53Z
There is a conflict that needs to be resolved.
Also can we add some of the comments back to the file.
sebrandon1
force-pushed
the
golangci-lint-upgrade
branch
from
62da86f to
ffcf677
Compare
openshift-merge-robot
removed
the
needs-rebase
sebrandon1
force-pushed
the
golangci-lint-upgrade
branch
from
ffcf677 to
ae49b02
Compare
The current version (1.64.8) is insufficient on all platforms to find lint errors. A PR in the openshift installer (openshift/installer#10121) will update the golangci-lint yaml file to version v2.
sebrandon1
force-pushed
the
golangci-lint-upgrade
branch
from
0c96395 to
c004395
Compare
|
golint failure is expected until openshift/release#72011 merges |
The current version (1.64.8) is insufficient on all platforms to find lint errors. A PR in the openshift installer (openshift/installer#10121) will update the golangci-lint yaml file to version v2.
barbacbd
left a comment
barbacbd
left a comment
There was a problem hiding this comment.
/approve
Waiting to see the way forward but this PR looks good.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: barbacbd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
background: We are going to move the changes for golangci-lint v2 config to a new file. Let this merge and set a specific path in CI. Then when everything is all working we can go back over and rename/move things. |
sebrandon1
force-pushed
the
golangci-lint-upgrade
branch
from
c004395 to
e1a2701
Compare
sebrandon1
force-pushed
the
golangci-lint-upgrade
branch
from
e1a2701 to
4a75423
Compare
|
@sebrandon1: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
Tracking: redhat-best-practices-for-k8s/telco-bot#49
Attempting to upgrade the golangci.yml to v2.