CORS-4212: AWS: Add the ability to configure throughput on GP3 volumes #10132

tthvo · 2025-11-26T18:36:42Z

Descriptions

GP3 volumes have the ability to configure throughput from 125 MiB/s to 2000 MiB/s. This allows the ability to set this at install time in the install-config.

This is a take-2 of #9945 after it was reverted in #10131 due to aws serial test failure.

Notes

The following new changes are introduced:

The throughput field is now a int32 pointer to match openshift/api. It does break the convention with iops, but at least it gives us an option to represent specified vs left-empty.
A nil check is performed before passing throughput to CAPA and MAPI.
A set of unit tests to introduce to double-check the validations for throughput.

openshift-ci-robot · 2025-11-26T18:36:46Z

@tthvo: This pull request references CORS-4212 which is a valid jira issue.

In response to this:

Descriptions

GP3 volumes have the ability to configure throughput from 125 MiB/s to 2000 MiB/s. This allows the ability to set this at install time in the install-config.

This is a take-2 of #9945 after it was reverted in #10131 due to aws serial test failure.

Notes

The following new changes are introduced:

The throughput field is now a int32 pointer to match openshift/api. It does break the convention with iops, but at least it gives us an option to represent specified vs left-empty.

A nil check is performed before passing throughput to CAPA and MAPI.

A set of unit tests to introduce to double-check the validations for throughput.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

tthvo · 2025-11-26T18:39:43Z

/cc @patrickdillon @jianlinliu @yunjiang29 @liweinan

tthvo · 2025-11-26T18:43:19Z

/payload-job periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-serial-1of2

openshift-ci · 2025-11-26T18:43:23Z

@tthvo: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-serial-1of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c7bb9e60-caf7-11f0-854d-0994ba12b72e-0

tthvo · 2025-11-26T18:43:43Z

/label platform/aws

tthvo · 2025-11-26T18:55:55Z

/test e2e-aws-ovn-public-subnets e2e-aws-ovn-public-ipv4-pool e2e-aws-ovn-custom-iam-profile e2e-aws-overlay-mtu-ovn-1200

tthvo · 2025-11-26T19:52:48Z

/cc @JoelSpeed

tthvo · 2025-11-26T22:41:16Z

/retest

Test failures seem fine (unrelated) 👀

tthvo · 2025-11-26T22:42:11Z

* periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-serial-1of2
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c7bb9e60-caf7-11f0-854d-0994ba12b72e-0

Payload passed this time 👍

openshift-ci · 2025-11-27T01:41:24Z

@tthvo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-overlay-mtu-ovn-1200	`d636ff2`	link	false	`/test e2e-aws-overlay-mtu-ovn-1200`
ci/prow/e2e-aws-ovn-heterogeneous	`d636ff2`	link	false	`/test e2e-aws-ovn-heterogeneous`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

liweinan · 2025-11-27T14:30:20Z

Used the build: https://prow.ci.openshift.org/view/gs/test-platform-results/logs/release-openshift-origin-installer-launch-aws-modern/1993960674010599424

Verified by the script locally: https://github.com/openshift/release/pull/71426/files#diff-5e156492e6ec7b6cc1782f27eb74071576df36e33d3caf3f92f73084af22a03f

cd /Users/weli/works/oc-swarm/release && SHARED_DIR=/tmp/work4-shared CLUSTER_PROFILE_DIR=/tmp/work4-shared bash ci-operator/step-registry/cucushift/installer/check/aws/rootvolume/cucushift-installer-check-aws-rootvolume-commands.sh
Cluster ID: weli-test-8fm49
Region: us-east-1
Expected compute throughput: 1000 MiB/s
Expected control plane throughput: 1200 MiB/s
Expected worker rootVolume size: 120 GiB
Expected control-plane rootVolume size: 150 GiB
Checking worker nodes
PASS: ip-10-0-39-111.ec2.internal volume vol-034246304384809e8 type=gp3 size=120GiB iops=5000 throughput=1000MiB/s
PASS: ip-10-0-4-150.ec2.internal volume vol-05f55a2f17af0cf1c type=gp3 size=120GiB iops=5000 throughput=1000MiB/s
PASS: ip-10-0-64-225.ec2.internal volume vol-08f7acd7aa708a280 type=gp3 size=120GiB iops=5000 throughput=1000MiB/s
Checking control plane nodes
PASS: ip-10-0-30-251.ec2.internal volume vol-097a2aef4a22e5f3f type=gp3 size=150GiB iops=5000 throughput=1200MiB/s
PASS: ip-10-0-51-181.ec2.internal volume vol-084b2e4af55d5e006 type=gp3 size=150GiB iops=5000 throughput=1200MiB/s
PASS: ip-10-0-64-82.ec2.internal volume vol-0aab6f02caafe824c type=gp3 size=150GiB iops=5000 throughput=1200MiB/s
==========================================
Test Summary
All root volume throughput checks passed.

/verified by liweinan

openshift-ci-robot · 2025-11-27T14:30:32Z

@liweinan: This PR has been marked as verified by liweinan.

In response to this:

Used the build: https://prow.ci.openshift.org/view/gs/test-platform-results/logs/release-openshift-origin-installer-launch-aws-modern/1993960674010599424

Verified by the script locally: https://github.com/openshift/release/pull/71426/files#diff-5e156492e6ec7b6cc1782f27eb74071576df36e33d3caf3f92f73084af22a03f

cd /Users/weli/works/oc-swarm/release && SHARED_DIR=/tmp/work4-shared CLUSTER_PROFILE_DIR=/tmp/work4-shared bash ci-operator/step-registry/cucushift/installer/check/aws/rootvolume/cucushift-installer-check-aws-rootvolume-commands.sh
Cluster ID: weli-test-8fm49
Region: us-east-1
Expected compute throughput: 1000 MiB/s
Expected control plane throughput: 1200 MiB/s
Expected worker rootVolume size: 120 GiB
Expected control-plane rootVolume size: 150 GiB
Checking worker nodes
PASS: ip-10-0-39-111.ec2.internal volume vol-034246304384809e8 type=gp3 size=120GiB iops=5000 throughput=1000MiB/s
PASS: ip-10-0-4-150.ec2.internal volume vol-05f55a2f17af0cf1c type=gp3 size=120GiB iops=5000 throughput=1000MiB/s
PASS: ip-10-0-64-225.ec2.internal volume vol-08f7acd7aa708a280 type=gp3 size=120GiB iops=5000 throughput=1000MiB/s
Checking control plane nodes
PASS: ip-10-0-30-251.ec2.internal volume vol-097a2aef4a22e5f3f type=gp3 size=150GiB iops=5000 throughput=1200MiB/s
PASS: ip-10-0-51-181.ec2.internal volume vol-084b2e4af55d5e006 type=gp3 size=150GiB iops=5000 throughput=1200MiB/s
PASS: ip-10-0-64-82.ec2.internal volume vol-0aab6f02caafe824c type=gp3 size=150GiB iops=5000 throughput=1200MiB/s
==========================================
Test Summary
All root volume throughput checks passed.

/verified by liweinan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

JoelSpeed · 2025-12-01T10:23:36Z

pkg/asset/machines/aws/machines.go

+			Encrypted:  pointer.Bool(true),
+			KMSKey:     machineapi.AWSResourceReference{ARN: pointer.String(in.root.KMSKeyARN)},
+		}
+		if in.root.Throughput != nil && *in.root.Throughput > 0 {


If an end users explicitly sets this to zero, wouldn't the validateThroughput catch it before we get here?

I think the nil check is probably sufficient

I don't think we even need the nil check, we can just assign the value, nil or not.

Ah, it is a bit of a tricky situation: The validateThroughput only runs when the machine pool defines the EBS volume type (i.e. similar to how validateIOPS and validateVolumeSize). See here and block below:

if p.EC2RootVolume.Type != "" { allErrs = append(allErrs, validateVolumeSize(p, fldPath)...) allErrs = append(allErrs, validateIOPS(p, fldPath)...) allErrs = append(allErrs, validateThroughput(p, fldPath)...) }

This makes sense because the volume type is optional as we set the default type later when generating the machine manifests. But it means the installer can skip validating throughput.

I think everyone's suggestion is the right way 👍 and the problem is that the validation should catch this. So, I updated the PR to set the volume type default (if empty) early so that the throughput validation path runs, avoiding any 0 throughput value.

PTAL 🙏

we set the default type later when generating the machine manifests

By this, I meant the code block below 👇 The commit here just uses the same logic to set the volume type somewhere earlier.

installer/pkg/asset/machines/worker.go

Lines 102 to 117 in fd5a518

func defaultAWSMachinePoolPlatform(poolName string) awstypes.MachinePool {

defaultEBSType := awstypes.VolumeTypeGp3

// gp3 is not offered in all local-zones locations used by Edge Pools.

// Once it is available, it can be used as default for all machine pools.

// https://aws.amazon.com/about-aws/global-infrastructure/localzones/features

if poolName == types.MachinePoolEdgeRoleName {

defaultEBSType = awstypes.VolumeTypeGp2

}

return awstypes.MachinePool{

EC2RootVolume: awstypes.EC2RootVolume{

Type: defaultEBSType,

Size: decimalRootVolumeSize,

},

}

}

patrickdillon · 2025-12-01T20:22:59Z

/approve

this lgtm, but some nits for discussion from joel & me

openshift-ci · 2025-12-01T20:23:25Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [patrickdillon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

GP3 volumes have the ability to configure throughput from 125 MiB/s to 2000 MiB/s. This allows the ability to set this at install time in the install-config. https://issues.redhat.com/browse/CORS-4212

Set the default type EBS volume for machine pools: - Controlplane, arbiter and worker pool default to gp3 volume. - Edge pool default to gp2 volume. The default decision is taken from existing code [0]. This commit just makes the defaulting earlier. Reference [0] https://github.com/openshift/installer/blob/fd5a518e4951510b82705eee8184b3dd4f2723b2/pkg/asset/machines/worker.go#L102-L117

tthvo · 2025-12-02T01:47:03Z

/approve

this lgtm, but some nits for discussion from joel & me

Thank you! I updated the PR. PTAL again 🙏

tthvo · 2025-12-02T01:56:09Z

/test e2e-aws-ovn-shared-vpc-edge-zones

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 26, 2025

openshift-ci bot requested review from jhixson74 and mtulio November 26, 2025 18:38

openshift-ci bot requested review from jianlinliu, liweinan, patrickdillon and yunjiang29 November 26, 2025 18:39

tthvo mentioned this pull request Nov 26, 2025

CORS-4212: AWS: Add the ability to configure throughput on GP3 volumes #9945

Merged

openshift-ci bot added the platform/aws label Nov 26, 2025

openshift-ci bot requested a review from JoelSpeed November 26, 2025 19:52

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 27, 2025

JoelSpeed reviewed Dec 1, 2025

View reviewed changes

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2025

jhixson74 added 3 commits December 1, 2025 17:12

Bump openshift/api for AWS GP3 changes

c17a0ff

go mod vendor for AWS GP3 changes

d05387a

AWS: Add the ability to configure throughput on GP3 volumes

d93d030

GP3 volumes have the ability to configure throughput from 125 MiB/s to 2000 MiB/s. This allows the ability to set this at install time in the install-config. https://issues.redhat.com/browse/CORS-4212

tthvo force-pushed the CORS-4212 branch from d636ff2 to f430036 Compare December 2, 2025 01:19

openshift-ci-robot removed the verified Signifies that the PR passed pre-merge verification criteria label Dec 2, 2025

	func defaultAWSMachinePoolPlatform(poolName string) awstypes.MachinePool {
	defaultEBSType := awstypes.VolumeTypeGp3

	// gp3 is not offered in all local-zones locations used by Edge Pools.
	// Once it is available, it can be used as default for all machine pools.
	// https://aws.amazon.com/about-aws/global-infrastructure/localzones/features
	if poolName == types.MachinePoolEdgeRoleName {
	defaultEBSType = awstypes.VolumeTypeGp2
	}
	return awstypes.MachinePool{
	EC2RootVolume: awstypes.EC2RootVolume{
	Type: defaultEBSType,
	Size: decimalRootVolumeSize,
	},
	}
	}

CORS-4212: AWS: Add the ability to configure throughput on GP3 volumes #10132

Are you sure you want to change the base?

CORS-4212: AWS: Add the ability to configure throughput on GP3 volumes #10132

Conversation

tthvo commented Nov 26, 2025

Descriptions

Notes

Uh oh!

openshift-ci-robot commented Nov 26, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Descriptions

Notes

Uh oh!

tthvo commented Nov 26, 2025

Uh oh!

tthvo commented Nov 26, 2025

Uh oh!

openshift-ci bot commented Nov 26, 2025

Uh oh!

tthvo commented Nov 26, 2025

Uh oh!

tthvo commented Nov 26, 2025

Uh oh!

tthvo commented Nov 26, 2025

Uh oh!

tthvo commented Nov 26, 2025

Uh oh!

tthvo commented Nov 26, 2025

Uh oh!

openshift-ci bot commented Nov 27, 2025

Uh oh!

liweinan commented Nov 27, 2025

Uh oh!

openshift-ci-robot commented Nov 27, 2025

Uh oh!

JoelSpeed Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

patrickdillon Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

tthvo Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

tthvo Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

patrickdillon commented Dec 1, 2025

Uh oh!

openshift-ci bot commented Dec 1, 2025

Uh oh!

tthvo commented Dec 2, 2025

Uh oh!

tthvo commented Dec 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

openshift-ci-robot commented Nov 26, 2025 •

edited by openshift-ci bot

Loading